1069: Descoped duplication

Author: danhalson

app/models/school.rb

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 class School < ApplicationRecord
-  class DuplicateSchoolError < StandardError; end
-
   has_many :classes, class_name: :SchoolClass, inverse_of: :school, dependent: :destroy
   has_many :lessons, dependent: :nullify
   has_many :projects, dependent: :nullify
@@ -42,7 +40,6 @@ class DuplicateSchoolError < StandardError; end
   before_validation :normalize_district_fields
   before_validation :normalize_school_roll_number
 
-  before_save :prevent_duplicate_school
   before_save :format_uk_postal_code, if: :should_format_uk_postal_code?
 
   after_commit :generate_code!, on: :create, if: -> { FeatureFlags.immediate_school_onboarding? }
@@ -155,29 +152,4 @@ def format_uk_postal_code
     # ensures UK postcodes are always formatted correctly (as the inward code is always 3 chars long)
     self.postal_code = "#{cleaned_postal_code[0..-4]} #{cleaned_postal_code[-3..]}"
   end
-
-  def prevent_duplicate_school
-    name_threshold = 0.6
-    municipality_threshold = 0.7
-    postal_code_threshold = 0.8
-    max_edit_distance = 3
-
-    normalized_postal = postal_code.to_s.gsub(/\s+/, '')
-
-    duplicate_school = School
-                       .where.not(id:)
-                       .where(country_code:)
-                       .where(
-                         'similarity(lower(name), ?) >= ? AND levenshtein(lower(name), ?) <= ?',
-                         name.to_s, name_threshold, name.to_s, max_edit_distance
-                       )
-                       .where('similarity(lower(municipality), ?) >= ?', municipality.to_s, municipality_threshold)
-                       .where(
-                         "similarity(lower(replace(postal_code, ' ', '')), ?) >= ?",
-                         normalized_postal, postal_code_threshold
-                       )
-                       .first
-
-    raise DuplicateSchoolError, I18n.t('validations.school.duplicate_school') if duplicate_school
-  end
 end

db/migrate/20251218143924_enable_pg_trgm_extension.rb

@@ -13,10 +13,6 @@ def call(school_params:, creator_id:, token:)
           SchoolOnboardingService.new(response[:school]).onboard(token:) if FeatureFlags.immediate_school_onboarding?
         end
 
-        response
-      rescue School::DuplicateSchoolError => e
-        response[:error] = e.message
-        response[:error_type] = :duplication_error
         response
       rescue StandardError => e
         Sentry.capture_exception(e)

db/schema.rb

@@ -9,10 +9,6 @@ def call(school:, school_params:)
         response[:school].assign_attributes(school_params)
         response[:school].save!
         response
-      rescue School::DuplicateSchoolError => e
-        Sentry.capture_exception(e)
-        response[:error] = e.message
-        response
       rescue StandardError => e
         Sentry.capture_exception(e)
         errors = response[:school].errors.full_messages.join(',')

lib/concepts/school/operations/create.rb

@@ -330,105 +330,6 @@
     it 'sets the user_origin to for_education by default' do
       expect(school.user_origin).to eq('for_education')
     end
-
-    describe 'duplicate detection' do
-      let(:existing_school) do
-        create(:school,
-               name: 'Riverside Academy',
-               municipality: 'Greenville',
-               postal_code: 'GV1 2XY',
-               administrative_area: 'Greenshire')
-      end
-
-      before { existing_school }
-
-      it 'allows schools with the same name in different countries' do
-        duplicate = build(:school,
-                          name: existing_school.name,
-                          municipality: existing_school.municipality,
-                          postal_code: existing_school.postal_code,
-                          administrative_area: existing_school.administrative_area,
-                          country_code: 'US')
-        expect(duplicate).to be_valid
-      end
-
-      it 'allows schools with the same name in different cities' do
-        duplicate = build(:school,
-                          name: existing_school.name,
-                          municipality: 'Bluetown',
-                          postal_code: 'BT3 4ZW',
-                          administrative_area: 'Blueshire')
-        expect(duplicate).to be_valid
-      end
-
-      it 'allows schools with the same name but very different postal codes' do
-        duplicate = build(:school,
-                          name: existing_school.name,
-                          municipality: existing_school.municipality,
-                          postal_code: 'NE1 7RU',
-                          administrative_area: existing_school.administrative_area)
-        expect(duplicate).to be_valid
-      end
-
-      it 'blocks duplicate with missing apostrophe in name' do
-        duplicate = build(:school,
-                          name: 'Riverside Acadmy',
-                          municipality: existing_school.municipality,
-                          postal_code: existing_school.postal_code,
-                          administrative_area: existing_school.administrative_area)
-        expect { duplicate.save! }.to raise_error(School::DuplicateSchoolError, I18n.t('validations.school.duplicate_school'))
-      end
-
-      it 'blocks duplicate with typo in name' do
-        duplicate = build(:school,
-                          name: 'Riversid Academy',
-                          municipality: existing_school.municipality,
-                          postal_code: existing_school.postal_code,
-                          administrative_area: existing_school.administrative_area)
-        expect { duplicate.save! }.to raise_error(School::DuplicateSchoolError, I18n.t('validations.school.duplicate_school'))
-      end
-
-      it 'blocks duplicate with similar municipality spelling' do
-        duplicate = build(:school,
-                          name: existing_school.name,
-                          municipality: 'Greenvile',
-                          postal_code: existing_school.postal_code,
-                          administrative_area: existing_school.administrative_area)
-        expect { duplicate.save! }.to raise_error(School::DuplicateSchoolError, I18n.t('validations.school.duplicate_school'))
-      end
-
-      it 'blocks duplicate with slightly different postal code spacing' do
-        duplicate = build(:school,
-                          name: existing_school.name,
-                          municipality: existing_school.municipality,
-                          postal_code: 'GV12XY',
-                          administrative_area: existing_school.administrative_area)
-        expect { duplicate.save! }.to raise_error(School::DuplicateSchoolError, I18n.t('validations.school.duplicate_school'))
-      end
-
-      it 'allows updating existing school without triggering duplicate detection' do
-        existing_school.update(address_line_1: Faker::Address.street_address)
-        expect(existing_school).to be_valid
-      end
-
-      it 'allows school with very different name despite same location' do
-        duplicate = build(:school,
-                          name: 'Completely Different Academy',
-                          municipality: existing_school.municipality,
-                          postal_code: existing_school.postal_code,
-                          administrative_area: existing_school.administrative_area)
-        expect(duplicate).to be_valid
-      end
-
-      it 'allows schools with similar but sufficiently different names in same location' do
-        duplicate = build(:school,
-                          name: 'Riverside Institute',
-                          municipality: existing_school.municipality,
-                          postal_code: existing_school.postal_code,
-                          administrative_area: existing_school.administrative_area)
-        expect(duplicate).to be_valid
-      end
-    end
   end
 
   describe '#creator' do