An nces district id is 7 digits

Author: danhalson

app/models/school.rb

@@ -22,7 +22,7 @@ class School < ApplicationRecord
             if: :united_kingdom?
   validates :district_nces_id,
             uniqueness: { conditions: -> { where(rejected_at: nil) }, case_sensitive: false, allow_blank: true, message: I18n.t('validations.school.district_nces_id_exists') },
-            format: { with: /\A\d{12}\z/, allow_nil: true, message: I18n.t('validations.school.district_nces_id') },
+            format: { with: /\A\d{7}\z/, allow_nil: true, message: I18n.t('validations.school.district_nces_id') },
             presence: true,
             if: :united_states?
   validates :district_name, presence: true, if: :united_states?

config/locales/en.yml

@@ -17,7 +17,7 @@ en:
       website: "must be a valid URL"
       reference: "must be 5-6 digits (e.g., 100000)"
       reference_urn_exists: "URN number already exists"
-      district_nces_id: "must be 12 digits (e.g., 010000000001)"
+      district_nces_id: "must be 7 digits (e.g., 0100000)"
       district_nces_id_exists: "NCES ID already exists"
       school_roll_number: "must be numbers followed by letters (e.g., 01572D)"
       school_roll_number_exists: "School roll number already exists"

spec/features/admin/schools_spec.rb

@@ -79,7 +79,7 @@
 
     describe 'when the school is in the United States and has a postal code' do
       before do
-        school.update(country_code: 'US', postal_code: '90210', district_name: 'Some District', district_nces_id: '010000000001', reference: nil)
+        school.update(country_code: 'US', postal_code: '90210', district_name: 'Some District', district_nces_id: '0100000', reference: nil)
         get admin_school_path(school)
       end
 

spec/jobs/school_import_job_spec.rb

@@ -19,7 +19,7 @@
           country_code: 'US',
           owner_email: 'owner1@example.com',
           district_name: 'Some District',
-          district_nces_id: '010000000001'
+          district_nces_id: '0100000'
         },
         {
           name: 'Test School 2',
@@ -29,7 +29,7 @@
           country_code: 'US',
           owner_email: 'owner2@example.com',
           district_name: 'Other District',
-          district_nces_id: '010000000002'
+          district_nces_id: '0100001'
         }
       ]
     end
@@ -130,7 +130,7 @@
             'country_code' => 'us',
             'owner_email' => 'owner1@example.com',
             'district_name' => 'Some District',
-            'district_nces_id' => '010000000001'
+            'district_nces_id' => '0100000'
           }
         ]
       end

spec/models/school_spec.rb

@@ -6,7 +6,7 @@
   let(:student) { create(:student, school:) }
   let(:teacher) { create(:teacher, school:) }
   let(:school) { create(:school, creator_id: SecureRandom.uuid) }
-  let!(:us_school) { create(:school, country_code: 'US', district_name: 'Some District', district_nces_id: '010000000001', creator_id: SecureRandom.uuid) }
+  let!(:us_school) { create(:school, country_code: 'US', district_name: 'Some District', district_nces_id: '0100000', creator_id: SecureRandom.uuid) }
   let!(:ireland_school) { create(:school, country_code: 'IE', school_roll_number: '01572D', creator_id: SecureRandom.uuid) }
 
   describe 'associations' do
@@ -238,38 +238,38 @@
     end
 
     it 'requires district_nces_id to be unique if provided' do
-      duplicate_school = build(:school, country_code: 'US', district_nces_id: '010000000001')
+      duplicate_school = build(:school, country_code: 'US', district_nces_id: '0100000')
       expect(duplicate_school).not_to be_valid
     end
 
     it 'returns error if district_nces_id is not unique' do
-      duplicate_school = build(:school, country_code: 'US', district_nces_id: '010000000001')
+      duplicate_school = build(:school, country_code: 'US', district_nces_id: '0100000')
       duplicate_school.valid?
       expect(duplicate_school.errors.details[:district_nces_id]).to include(hash_including(error: :taken))
     end
 
-    it 'accepts a valid district_nces_id format (12 digits)' do
-      us_school.district_nces_id = '010000000001'
+    it 'accepts a valid district_nces_id format (7 digits)' do
+      us_school.district_nces_id = '0100000'
       expect(us_school).to be_valid
     end
 
     it 'rejects a district_nces_id with non-digit characters' do
-      us_school.district_nces_id = '01000000000A'
+      us_school.district_nces_id = '010000A'
       expect(us_school).not_to be_valid
-      expect(us_school.errors[:district_nces_id]).to include('must be 12 digits (e.g., 010000000001)')
+      expect(us_school.errors[:district_nces_id]).to include('must be 7 digits (e.g., 0100000)')
     end
 
     it 'rejects a district_nces_id with wrong length' do
-      us_school.district_nces_id = '12345678901'
+      us_school.district_nces_id = '123456'
       expect(us_school).not_to be_valid
-      expect(us_school.errors[:district_nces_id]).to include('must be 12 digits (e.g., 010000000001)')
+      expect(us_school.errors[:district_nces_id]).to include('must be 7 digits (e.g., 0100000)')
     end
 
     it 'allows district_nces_id reuse when original school is rejected' do
-      us_school.district_nces_id = '010000000001'
+      us_school.district_nces_id = '0100000'
       us_school.reject
 
-      new_school = build(:school, country_code: 'US', district_name: 'Some District', district_nces_id: '010000000001')
+      new_school = build(:school, country_code: 'US', district_name: 'Some District', district_nces_id: '0100000')
       expect(new_school).to be_valid
       expect { new_school.save! }.not_to raise_error
     end