Move Salesforce Sync into Flipper Flag

This commit removes the SALESFORCE_ENABLED env var in favour of using
Flipper feature flags.

Author: fspeirs

.env.example

@@ -59,7 +59,6 @@ RESEED_API_KEY=changeme
 ENABLE_IMMEDIATE_SCHOOL_ONBOARDING=true
 
 # Salesforce Connect
-SALESFORCE_ENABLED=true
 SALESFORCE_CONNECT_HOST=salesforce_connect
 SALESFORCE_CONNECT_PORT=4101
 SALESFORCE_CONNECT_DB=salesforce_development

app/jobs/salesforce/salesforce_sync_job.rb

@@ -27,8 +27,7 @@ class SkipBecauseSalesforceIsDisabled < StandardError
     queue_as :salesforce_sync
 
     before_perform do |_job|
-      salesforce_enabled = ENV.fetch('SALESFORCE_ENABLED', 'true') == 'true'
-      raise SkipBecauseSalesforceIsDisabled, 'SALESFORCE_ENABLED is not true.' unless salesforce_enabled
+      raise SkipBecauseSalesforceIsDisabled, 'salesforce_sync Flipper flag is not enabled.' unless Flipper.enabled?(:salesforce_sync)
     end
 
     def perform(*)

spec/jobs/salesforce/contact_sync_job_spec.rb

@@ -5,6 +5,8 @@
 RSpec.describe Salesforce::ContactSyncJob do
   subject(:perform_job) { described_class.perform_now(school_id: school.id) }
 
+  before { Flipper.enable(:salesforce_sync) }
+
   let(:school) { create(:school, creator_agree_to_ux_contact: true) }
   let!(:sf_contact) { create(:salesforce_contact, pi_accounts_unique_id__c: school.creator_id) }
 
@@ -41,12 +43,8 @@
     end
   end
 
-  context 'when SALESFORCE_ENABLED is false' do
-    around do |example|
-      ClimateControl.modify(SALESFORCE_ENABLED: 'false') do
-        example.run
-      end
-    end
+  context 'when the salesforce_sync Flipper flag is disabled' do
+    before { Flipper.disable(:salesforce_sync) }
 
     it 'discards the job without syncing' do
       sf_contact.update!(experiencecsagreetouxcontact__c: false)

spec/jobs/salesforce/role_sync_job_spec.rb

@@ -5,6 +5,8 @@
 RSpec.describe Salesforce::RoleSyncJob do
   subject(:perform_job) { described_class.perform_now(role_id: role.id) }
 
+  before { Flipper.enable(:salesforce_sync) }
+
   let(:role) { create(:role) }
 
   context 'when the job has run' do
@@ -43,12 +45,8 @@
     end
   end
 
-  context 'when SALESFORCE_ENABLED is false' do
-    around do |example|
-      ClimateControl.modify(SALESFORCE_ENABLED: 'false') do
-        example.run
-      end
-    end
+  context 'when the salesforce_sync Flipper flag is disabled' do
+    before { Flipper.disable(:salesforce_sync) }
 
     it 'discards the job without syncing' do
       perform_job

spec/jobs/salesforce/school_sync_job_spec.rb

@@ -5,6 +5,8 @@
 RSpec.describe Salesforce::SchoolSyncJob do
   subject(:perform_job) { described_class.perform_now(school_id: school.id) }
 
+  before { Flipper.enable(:salesforce_sync) }
+
   let(:school) { create(:school) }
 
   context 'when the job has run' do
@@ -62,12 +64,8 @@
     end
   end
 
-  context 'when SALESFORCE_ENABLED is false' do
-    around do |example|
-      ClimateControl.modify(SALESFORCE_ENABLED: 'false') do
-        example.run
-      end
-    end
+  context 'when the salesforce_sync Flipper flag is disabled' do
+    before { Flipper.disable(:salesforce_sync) }
 
     it 'discards the job without syncing' do
       perform_job