Autocorrect failing cops

zetter-rpf · zetter-rpf · commit d1a5fa4c14f4 · 2026-03-02T14:31:11.000Z
diff --git a/spec/features/class_member/creating_a_batch_of_class_members_spec.rb b/spec/features/class_member/creating_a_batch_of_class_members_spec.rb
@@ -181,7 +181,7 @@
 
     it 'responds 422 Unprocessable Entity' do
       post("/api/schools/#{school.id}/classes/#{school_class.id}/members/batch", headers:, params: invalid_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'returns the error message in the operation response' do
diff --git a/spec/features/class_member/creating_a_class_member_spec.rb b/spec/features/class_member/creating_a_class_member_spec.rb
@@ -66,7 +66,7 @@
 
         it 'responds 422 Unprocessable Entity' do
           post("/api/schools/#{school.id}/classes/#{school_class.id}/members", headers:, params: student_params)
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(:unprocessable_content)
         end
 
         it 'returns the error message from the operation response' do
@@ -132,7 +132,7 @@
 
         it 'responds 422 Unprocessable Entity' do
           post("/api/schools/#{school.id}/classes/#{school_class.id}/members", headers:, params: teacher_params)
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(:unprocessable_content)
         end
 
         it 'returns the error message from the operation response' do
@@ -209,7 +209,7 @@
 
     it 'responds 422 Unprocessable Entity when params are invalid' do
       post("/api/schools/#{school.id}/classes/#{school_class.id}/members", headers:, params: invalid_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'returns the error message in the operation response' do
diff --git a/spec/features/feedback/creating_feedback_spec.rb b/spec/features/feedback/creating_feedback_spec.rb
@@ -70,7 +70,7 @@
       end
 
       it 'returns unprocessable entity response' do
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
 
       it 'does not add the feedback to the school project' do
diff --git a/spec/features/lesson/creating_a_copy_of_a_lesson_spec.rb b/spec/features/lesson/creating_a_copy_of_a_lesson_spec.rb
@@ -55,7 +55,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post("/api/lessons/#{lesson.id}/copy", headers:, params: { lesson: { name: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/lesson/creating_a_lesson_spec.rb b/spec/features/lesson/creating_a_lesson_spec.rb
@@ -49,7 +49,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post('/api/lessons', headers:, params: { lesson: { name: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
@@ -151,14 +151,14 @@
       new_params = { lesson: params[:lesson].without(:school_id) }
 
       post('/api/lessons', headers:, params: new_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'responds 422 Unprocessable if school_class_id does not correspond to school_id' do
       new_params = { lesson: params[:lesson].merge(school_id: SecureRandom.uuid) }
 
       post('/api/lessons', headers:, params: new_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'responds 403 Forbidden when the user is a school-owner for a different school' do
@@ -183,7 +183,7 @@
       new_params = { lesson: params[:lesson].merge(user_id:) }
 
       post('/api/lessons', headers:, params: new_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
   end
 end
diff --git a/spec/features/lesson/updating_a_lesson_spec.rb b/spec/features/lesson/updating_a_lesson_spec.rb
@@ -42,7 +42,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     put("/api/lessons/#{lesson.id}", headers:, params: { lesson: { name: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
@@ -125,7 +125,7 @@
       new_params = { lesson: params[:lesson].merge(school_class_id: school_class.id) }
       put("/api/lessons/#{lesson.id}", headers:, params: new_params)
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
   end
 end
diff --git a/spec/features/project/creating_a_project_spec.rb b/spec/features/project/creating_a_project_spec.rb
@@ -53,7 +53,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post('/api/projects', headers:, params: { project: { components: [{ name: ' ' }] } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
@@ -168,21 +168,21 @@
       new_params = { project: project.merge(user_id:) }
 
       post('/api/projects', headers:, params: new_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'responds 422 Unprocessable when lesson_id is provided but school_id is missing' do
       new_params = { project: params[:project].without(:school_id) }
 
       post('/api/projects', headers:, params: new_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'responds 422 Unprocessable when lesson_id does not correspond to school_id' do
       new_params = { project: params[:project].merge(lesson_id: SecureRandom.uuid) }
 
       post('/api/projects', headers:, params: new_params)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'responds 403 Forbidden when the user is a school-owner for a different school' do
diff --git a/spec/features/project/updating_a_project_spec.rb b/spec/features/project/updating_a_project_spec.rb
@@ -48,7 +48,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     put("/api/projects/#{project.id}", headers:, params: { project: { components: [{ name: ' ' }] } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/school/creating_a_school_spec.rb b/spec/features/school/creating_a_school_spec.rb
@@ -50,7 +50,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post('/api/schools', headers:, params: { school: { name: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/school/importing_schools_spec.rb b/spec/features/school/importing_schools_spec.rb
@@ -53,7 +53,7 @@
       it 'responds 422 Unprocessable Entity' do
         post('/api/schools/import', headers:)
 
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
         data = JSON.parse(response.body, symbolize_names: true)
         expect(data[:error][:error_code]).to eq('CSV_FILE_REQUIRED')
       end
diff --git a/spec/features/school/updating_a_school_spec.rb b/spec/features/school/updating_a_school_spec.rb
@@ -43,7 +43,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     put("/api/schools/#{school.id}", headers:, params: { school: { name: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/school_class/creating_a_school_class_spec.rb b/spec/features/school_class/creating_a_school_class_spec.rb
@@ -78,7 +78,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post("/api/schools/#{school.id}/classes", headers:, params: { school_class: { name: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/school_class/importing_a_school_class_spec.rb b/spec/features/school_class/importing_a_school_class_spec.rb
@@ -40,7 +40,7 @@
 
       post(import_url, headers:, params: params_missing_origin)
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
       error_response = JSON.parse(response.body)
       expect(error_response).to have_key('error')
       expect(error_response['error']).to include("Import origin can't be blank")
@@ -52,7 +52,7 @@
 
       post(import_url, headers:, params: params_missing_id)
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
       error_response = JSON.parse(response.body)
       expect(error_response).to have_key('error')
       expect(error_response['error']).to include("Import id can't be blank")
@@ -65,7 +65,7 @@
 
       post(import_url, headers:, params: params_missing_both)
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
       error_response = JSON.parse(response.body)
       expect(error_response).to have_key('error')
       expect(error_response['error']).to include("Import origin can't be blank")
@@ -77,7 +77,7 @@
 
       post(import_url, headers:, params: params_invalid_enum)
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
       error_response = JSON.parse(response.body)
       expect(error_response).to have_key('error')
       expect(error_response['error']).to include('Import origin is not included in the list')
@@ -89,7 +89,7 @@
 
       post(import_url, headers:, params: params_missing_name)
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
       error_response = JSON.parse(response.body)
       expect(error_response).to have_key('error')
       expect(error_response['error']).to include("Name can't be blank")
diff --git a/spec/features/school_class/updating_a_school_class_spec.rb b/spec/features/school_class/updating_a_school_class_spec.rb
@@ -53,7 +53,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     put("/api/schools/#{school.id}/classes/#{school_class.id}", headers:, params: { school_class: { name: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/school_project/complete_spec.rb b/spec/features/school_project/complete_spec.rb
@@ -68,7 +68,7 @@
       end
 
       it 'completes unauthorized response' do
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
 
       it 'completes error message' do
diff --git a/spec/features/school_project/return_spec.rb b/spec/features/school_project/return_spec.rb
@@ -67,7 +67,7 @@
       end
 
       it 'returns unauthorized response' do
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
 
       it 'returns error message' do
diff --git a/spec/features/school_project/submit_spec.rb b/spec/features/school_project/submit_spec.rb
@@ -52,7 +52,7 @@
       end
 
       it 'returns unauthorized response' do
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
 
       it 'returns error message' do
diff --git a/spec/features/school_project/unsubmit_spec.rb b/spec/features/school_project/unsubmit_spec.rb
@@ -74,7 +74,7 @@
       end
 
       it 'returns unauthorized response' do
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
 
       it 'returns error message' do
diff --git a/spec/features/school_student/batch_deleting_school_students_spec.rb b/spec/features/school_student/batch_deleting_school_students_spec.rb
@@ -75,7 +75,7 @@
       delete "/api/schools/#{school.id}/students/batch",
              headers: headers
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
       json = JSON.parse(response.body)
       expect(json['error']).to eq('No student IDs provided')
     end
diff --git a/spec/features/school_student/creating_a_batch_of_school_students_spec.rb b/spec/features/school_student/creating_a_batch_of_school_students_spec.rb
@@ -80,7 +80,7 @@
     expect do
       post("/api/schools/#{school.id}/students/batch", headers:, params:)
     end.not_to change(GoodJob::BatchRecord, :count)
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
 
     active_batches = GoodJob::BatchRecord.where(
       description: school.id,
@@ -126,20 +126,20 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post("/api/schools/#{school.id}/students/batch", headers:, params: { school_students: [] })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 422 Unprocessable Entity with a suitable message when params are invalid' do
     post("/api/schools/#{school.id}/students/batch", headers:, params: bad_params)
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
     expect(response.body).to include('Decryption failed: iv must be 16 bytes')
   end
 
   it 'responds 422 Unprocessable Entity with a JSON array of validation errors' do
     stub_profile_api_create_school_students_validation_error
     stub_profile_api_validate_students_with_validation_error
     post("/api/schools/#{school.id}/students/batch", headers:, params:)
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
     expect(response.body).to eq(
       {
         error: {
diff --git a/spec/features/school_student/creating_a_school_student_spec.rb b/spec/features/school_student/creating_a_school_student_spec.rb
@@ -69,7 +69,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post("/api/schools/#{school.id}/students", headers:, params: { school_student: { username: ' ' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/school_teacher/inviting_a_school_teacher_spec.rb b/spec/features/school_teacher/inviting_a_school_teacher_spec.rb
@@ -32,7 +32,7 @@
 
   it 'responds 422 Unprocessable Entity when params are invalid' do
     post("/api/schools/#{school.id}/teachers", headers:, params: { school_teacher: { email_address: 'invalid' } })
-    expect(response).to have_http_status(:unprocessable_entity)
+    expect(response).to have_http_status(:unprocessable_content)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
diff --git a/spec/features/teacher_invitations/accepting_an_invitation_spec.rb b/spec/features/teacher_invitations/accepting_an_invitation_spec.rb
@@ -73,7 +73,7 @@
         it 'responds 422 Unprocessable entity' do
           put("/api/teacher_invitations/#{token}/accept", headers:)
 
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(:unprocessable_content)
         end
 
         it 'does not give the user the teacher role for the school to which they have been invited' do
@@ -108,7 +108,7 @@
         it 'responds 422 Unprocessable entity' do
           put("/api/teacher_invitations/#{token}/accept", headers:)
 
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(:unprocessable_content)
         end
 
         it 'does not give the user the teacher role for the school to which they have been invited' do
diff --git a/spec/requests/api_controller_spec.rb b/spec/requests/api_controller_spec.rb
@@ -99,7 +99,7 @@ def index
     it 'responds with 422 Unprocessable entity status code' do
       get '/test'
 
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
 
     it 'responds with JSON including exception class & message' do
diff --git a/spec/requests/projects/create_spec.rb b/spec/requests/projects/create_spec.rb
@@ -38,7 +38,7 @@
       it 'returns error' do
         post('/api/projects', headers:)
 
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
     end
   end
diff --git a/spec/requests/projects/update_spec.rb b/spec/requests/projects/update_spec.rb
@@ -75,7 +75,7 @@
 
       it 'returns error response' do
         put("/api/projects/#{project.identifier}", params:, headers:)
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
     end
 
@@ -84,7 +84,7 @@
 
       it 'returns error response' do
         put("/api/projects/#{project.identifier}", params:, headers:)
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:unprocessable_content)
       end
     end
   end
@@ -146,7 +146,7 @@
     it 'returns unprocessable entity if instructions updated' do
       params[:project][:instructions] = 'updated instructions'
       put("/api/projects/#{project.identifier}", params:, headers:)
-      expect(response).to have_http_status(:unprocessable_entity)
+      expect(response).to have_http_status(:unprocessable_content)
     end
   end
 
