Skip to content

Commit d811c4f

Browse files
committed
Start tidy up
1 parent 150692f commit d811c4f

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

app/controllers/api/school_classes_controller.rb

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -102,22 +102,18 @@ def calculate_unread_counts(school_classes)
102102

103103
def user_remixes_for_lessons(lessons)
104104
lessons.filter_map do |lesson|
105-
next nil unless lesson&.project&.remixes&.any?
105+
next nil unless lesson&.project&.remixes&.exists?
106106

107107
user_remix_for_lesson(lesson)
108108
end
109109
end
110110

111111
def user_remix_for_lesson(lesson)
112-
remixes = lesson.project&.remixes
113-
return unless remixes
114-
115-
remixes
116-
.where(user_id: current_user.id)
117-
.accessible_by(current_ability)
118-
.order(created_at: :asc)
119-
.includes(school_project: :feedback)
120-
.first
112+
lesson.project&.remixes&.where(user_id: current_user.id)
113+
&.accessible_by(current_ability)
114+
&.order(created_at: :asc)
115+
&.includes(school_project: :feedback)
116+
&.first
121117
end
122118

123119
def find_or_create_school_class(school_class_params)

0 commit comments

Comments
 (0)