Scope school_roll_number uniqueness to non-rejected schools and allow reapplication with the same roll number after a school is rejected

Author: Mohamed-RPF

app/models/school.rb

@@ -19,7 +19,7 @@ class School < ApplicationRecord
   validates :reference, uniqueness: { case_sensitive: false, allow_nil: true }, presence: false
   validates :district_nces_id, uniqueness: { case_sensitive: false, allow_nil: true }, presence: false
   validates :school_roll_number,
-            uniqueness: { case_sensitive: false, allow_nil: true },
+            uniqueness: { conditions: -> { where(rejected_at: nil) }, case_sensitive: false, allow_nil: true },
             presence: false,
             format: { with: /\A[0-9]+[A-Z]+\z/, allow_nil: true, message: I18n.t('validations.school.school_roll_number') }
   validates :creator_id, presence: true, uniqueness: true

spec/models/school_spec.rb

@@ -202,6 +202,15 @@
       expect(school.school_roll_number).to eq('01572D')
     end
 
+    it 'allows school_roll_number reuse when original school is rejected' do
+      school.school_roll_number = '01572D'
+      school.save!
+      school.reject
+
+      new_school = build(:school, school_roll_number: '01572D')
+      expect(new_school).to be_valid
+    end
+
     it 'requires an address_line_1' do
       school.address_line_1 = ' '
       expect(school).not_to be_valid