1069: Ensure old coverage exists until feature flag removed

Author: danhalson

spec/services/school_verification_service_spec.rb

@@ -8,39 +8,180 @@
   let(:school_creator) { create(:user) }
   let(:service) { described_class.new(school) }
 
-  around do |example|
-    ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'true') do
-      example.run
-    end
-  end
-
   describe '#verify' do
-    describe 'when school can be saved' do
-      it 'saves the school' do
-        service.verify
-        expect(school).to be_persisted
+    describe 'when immediate onboarding is enabled' do
+      # TODO: Remove this block once the feature flag is retired
+      around do |example|
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'true') do
+          example.run
+        end
       end
 
-      it 'sets verified_at to a date' do
-        service.verify
-        expect(school.reload.verified_at).to be_a(ActiveSupport::TimeWithZone)
+      describe 'when school can be saved' do
+        it 'saves the school' do
+          service.verify
+          expect(school).to be_persisted
+        end
+
+        it 'sets verified_at to a date' do
+          service.verify
+          expect(school.reload.verified_at).to be_a(ActiveSupport::TimeWithZone)
+        end
+
+        it 'returns true' do
+          expect(service.verify).to be(true)
+        end
       end
 
-      it 'returns true' do
-        expect(service.verify).to be(true)
+      describe 'when school cannot be saved' do
+        let(:website) { 'invalid' }
+
+        it 'does not save the school' do
+          service.verify
+          expect(school).not_to be_persisted
+        end
+
+        it 'returns false' do
+          expect(service.verify).to be(false)
+        end
       end
     end
 
-    describe 'when school cannot be saved' do
-      let(:website) { 'invalid' }
+    # TODO: Remove these examples once the feature flag is retired
+    describe 'when immediate onboarding is disabled' do
+      let(:token) { 'token' }
 
-      it 'does not save the school' do
-        service.verify
-        expect(school).not_to be_persisted
+      around do |example|
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: nil) do
+          example.run
+        end
       end
 
-      it 'returns false' do
-        expect(service.verify).to be(false)
+      before do
+        allow(ProfileApiClient).to receive(:create_school)
+      end
+
+      describe 'when school can be saved' do
+        it 'saves the school' do
+          service.verify(token:)
+          expect(school).to be_persisted
+        end
+
+        it 'sets verified_at to a date' do
+          service.verify(token:)
+          expect(school.reload.verified_at).to be_a(ActiveSupport::TimeWithZone)
+        end
+
+        it 'generates school code' do
+          service.verify(token:)
+          expect(school.reload.code).to be_present
+        end
+
+        it 'grants the creator the owner role for the school' do
+          service.verify(token:)
+          expect(school_creator).to be_school_owner(school)
+        end
+
+        it 'grants the creator the teacher role for the school' do
+          service.verify(token:)
+          expect(school_creator).to be_school_teacher(school)
+        end
+
+        it 'creates the school in Profile API' do
+          service.verify(token:)
+          expect(ProfileApiClient).to have_received(:create_school).with(token:, id: school.id, code: school.code)
+        end
+
+        it 'returns true' do
+          expect(service.verify(token:)).to be(true)
+        end
+      end
+
+      describe 'when school cannot be saved' do
+        let(:website) { 'invalid' }
+
+        it 'does not save the school' do
+          service.verify(token:)
+          expect(school).not_to be_persisted
+        end
+
+        it 'does not create owner role' do
+          service.verify(token:)
+          expect(school_creator).not_to be_school_owner(school)
+        end
+
+        it 'does not create teacher role' do
+          service.verify(token:)
+          expect(school_creator).not_to be_school_teacher(school)
+        end
+
+        it 'does not create school in Profile API' do
+          expect(ProfileApiClient).not_to have_received(:create_school)
+        end
+
+        it 'returns false' do
+          expect(service.verify(token:)).to be(false)
+        end
+      end
+
+      describe 'when the school cannot be created in Profile API' do
+        before do
+          allow(ProfileApiClient).to receive(:create_school).and_raise(RuntimeError)
+        end
+
+        it 'does not save the school' do
+          service.verify(token:)
+          expect { school.reload }.to raise_error(ActiveRecord::RecordNotFound)
+        end
+
+        it 'does not create owner role' do
+          service.verify(token:)
+          expect(school_creator).not_to be_school_owner(school)
+        end
+
+        it 'does not create teacher role' do
+          service.verify(token:)
+          expect(school_creator).not_to be_school_teacher(school)
+        end
+
+        it 'does not create school in Profile API' do
+          expect(ProfileApiClient).not_to have_received(:create_school)
+        end
+
+        it 'returns false' do
+          expect(service.verify(token:)).to be(false)
+        end
+      end
+
+      describe 'when teacher and owner roles cannot be created because they already have a role in another school' do
+        let(:another_school) { create(:school) }
+
+        before do
+          create(:role, user_id: school.creator_id, school: another_school)
+        end
+
+        it 'does not save the school' do
+          service.verify(token:)
+          expect { school.reload }.to raise_error(ActiveRecord::RecordNotFound)
+        end
+
+        it 'does not create owner role' do
+          service.verify(token:)
+          expect(school_creator).not_to be_school_owner(school)
+        end
+
+        it 'does not create teacher role' do
+          service.verify(token:)
+          expect(school_creator).not_to be_school_teacher(school)
+        end
+
+        it 'does not create school in Profile API' do
+          expect(ProfileApiClient).not_to have_received(:create_school)
+        end
+
+        it 'returns false' do
+          expect(service.verify(token:)).to be(false)
+        end
       end
     end
   end