Remove validation and old tests

Author: jamiebenstead

app/models/teacher_invitation.rb

@@ -6,7 +6,6 @@ class TeacherInvitation < ApplicationRecord
   belongs_to :school
   validates :email_address,
             format: { with: EmailValidator.regexp, message: I18n.t('validations.invitation.email_address') }
-  validate :school_is_verified
   after_create_commit :send_invitation_email
   encrypts :email_address
 
@@ -16,12 +15,6 @@ class TeacherInvitation < ApplicationRecord
 
   private
 
-  def school_is_verified
-    return if school.verified?
-
-    errors.add(:school, 'is not verified')
-  end
-
   def send_invitation_email
     InvitationMailer.with(invitation: self).invite_teacher.deliver_later
   end

lib/concepts/school_student/create.rb

@@ -22,16 +22,15 @@ def create_student(school, school_student_params, token)
         password = DecryptionHelpers.decrypt_password(encrypted_password)
         name = school_student_params.fetch(:name)
 
-        validate(school:, username:, password:, name:)
+        validate(username:, password:, name:)
 
         response = ProfileApiClient.create_school_student(token:, username:, password:, name:, school_id:)
         user_id = response[:created].first
         Role.student.create!(school:, user_id:)
         user_id
       end
 
-      def validate(school:, username:, password:, name:)
-        raise ArgumentError, 'school is not verified' unless school.verified?
+      def validate(username:, password:, name:)
         raise ArgumentError, "username '#{username}' is invalid" if username.blank?
         raise ArgumentError, "password '#{password}' is invalid" if password.size < 8
         raise ArgumentError, "name '#{name}' is invalid" if name.blank?

spec/concepts/school_student/create_spec.rb

@@ -76,15 +76,6 @@
     end
   end
 
-  context 'when the school is not verified' do
-    let(:school) { create(:school) }
-
-    it 'returns the error message in the operation response' do
-      response = described_class.call(school:, school_student_params:, token:)
-      expect(response[:error]).to match(/school is not verified/)
-    end
-  end
-
   context 'when the student cannot be created in profile api because of a 422 response' do
     let(:error) { { 'message' => "something's up with the username" } }
     let(:exception) { ProfileApiClient::Student422Error.new(error) }

spec/concepts/school_teacher/invite_spec.rb

@@ -49,13 +49,4 @@
       expect(Sentry).to have_received(:capture_exception).with(kind_of(StandardError))
     end
   end
-
-  context 'when the school is not verified' do
-    let(:school) { create(:school) }
-
-    it 'returns the error message in the operation response' do
-      response = described_class.call(school:, school_teacher_params:, token:)
-      expect(response[:error]).to match(/School is not verified/)
-    end
-  end
 end