Skip to content
This repository was archived by the owner on Apr 30, 2026. It is now read-only.

Commit d7d145a

Browse files
committed
fix(ci): remove unused cexpr_node_by_id, guard csv memset for -Werror
macOS clang flags -Wunused-function on cexpr_node_by_id (defined but never called). Ubuntu CI GCC -O3 flags -Wstringop-overflow on memset with potentially negative ncols cast to size_t.
1 parent 42568c1 commit d7d145a

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

src/io/csv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1279,7 +1279,7 @@ ray_t* ray_read_csv_opts(const char* path, char delimiter, bool header,
12791279
/* ---- 8b. Pre-allocate nullmaps for all columns ---- */
12801280
uint8_t* col_nullmaps[CSV_MAX_COLS];
12811281
bool col_had_null[CSV_MAX_COLS];
1282-
memset(col_had_null, 0, (size_t)ncols * sizeof(bool));
1282+
if (ncols > 0) memset(col_had_null, 0, (size_t)ncols * sizeof(bool));
12831283

12841284
for (int c = 0; c < ncols; c++) {
12851285
ray_t* vec = col_vecs[c];

src/ops/query.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,9 +315,6 @@ static void cexpr_env_pop(ray_graph_t* g, int n) {
315315
* call (which may grow g->nodes via graph_alloc_node and invalidate
316316
* all previously-returned pointers). The ID is stable; only the
317317
* backing address may change. */
318-
static inline ray_op_t* cexpr_node_by_id(ray_graph_t* g, uint32_t id) {
319-
return &g->nodes[id];
320-
}
321318

322319
/* Compile a Rayfall AST expression into a DAG node */
323320
static ray_op_t* compile_expr_dag(ray_graph_t* g, ray_t* expr) {

0 commit comments

Comments
 (0)