Fixing recent exceptions in assignment-solutions presenter (a situation when no best solution exists).

Author: krulis-martin

app/V1Module/presenters/AssignmentSolutionsPresenter.php

@@ -390,12 +390,12 @@ public function actionSetBonusPoints(string $id)
             $changedSolutions[] = $this->assignmentSolutionViewFactory->getSolutionData($solution);
             if ($assignment) {
                 $best = $this->assignmentSolutions->findBestSolution($assignment, $author);
-                if ($best->getId() !== $oldBest->getId()) {
+                if (!$best || !$oldBest || $best->getId() !== $oldBest->getId()) {
                     // best solution has changed, we need to report this
-                    if ($best->getId() !== $id) {
+                    if ($best && $best->getId() !== $id) {
                         $changedSolutions[] = $this->assignmentSolutionViewFactory->getSolutionData($best);
                     }
-                    if ($oldBest->getId() !== $id) {
+                    if ($oldBest && $oldBest->getId() !== $id) {
                         $changedSolutions[] = $this->assignmentSolutionViewFactory->getSolutionData($oldBest);
                     }
                 }
@@ -498,7 +498,9 @@ public function actionSetFlag(string $id, string $flag)
 
         // finally flush all changed to the database
         $this->assignmentSolutions->flush();
-        $this->assignmentSolutions->refresh($oldBestSolution);
+        if ($oldBestSolution) {
+            $this->assignmentSolutions->refresh($oldBestSolution);
+        }
 
         // send notification email
         $notificationMethod = $flag . 'FlagChanged';
@@ -512,7 +514,6 @@ public function actionSetFlag(string $id, string $flag)
         }
 
         // assemble response (all entities and stats that may have changed)
-        $assignmentId = $solution->getAssignment()->getId();
         $groupOfSolution = $solution->getAssignment()->getGroup();
         if ($groupOfSolution === null) {
             throw new NotFoundException("Group for assignment '$id' was not found");
@@ -528,12 +529,16 @@ public function actionSetFlag(string $id, string $flag)
             $solution->getAssignment(),
             $solution->getSolution()->getAuthor()
         );
-        if ($oldBestSolution->getId() !== $bestSolution->getId()) {
+        if (!$oldBestSolution || !$bestSolution || $oldBestSolution->getId() !== $bestSolution->getId()) {
             // add old and current best solutions as well (since they have changed)
-            $resSolutions[$oldBestSolution->getId()] =
-                $this->assignmentSolutionViewFactory->getSolutionData($oldBestSolution);
-            $resSolutions[$bestSolution->getId()] =
-                $this->assignmentSolutionViewFactory->getSolutionData($bestSolution);
+            if ($oldBestSolution) {
+                $resSolutions[$oldBestSolution->getId()] =
+                    $this->assignmentSolutionViewFactory->getSolutionData($oldBestSolution);
+            }
+            if ($bestSolution) {
+                $resSolutions[$bestSolution->getId()] =
+                    $this->assignmentSolutionViewFactory->getSolutionData($bestSolution);
+            }
         }
 
         $this->sendSuccessResponse([

recodex-api.spec

@@ -2,8 +2,8 @@
 %define short_name api
 %define install_dir /opt/%{name}
 %define version 2.16.1
-%define unmangled_version 9f2e984f03086c228016bc7e420bfa23d8c7e8b9
-%define release 1
+%define unmangled_version 1e145d5253dacbe64a8ed1050883834b05a8deeb
+%define release 2
 
 Summary: ReCodEx core API component
 Name: %{name}