Fixing fetchByIds method to bypass Doctrine problem with empty IN clauses.

krulis-martin · krulis-martin · commit 8e01059afd59 · 2026-01-11T23:25:32.000+01:00
diff --git a/app/model/repository/BaseRepository.php b/app/model/repository/BaseRepository.php
@@ -86,7 +86,8 @@ public function findOneBy(array $criteria)
      */
     public function findByIds(array $ids): array
     {
-        return $this->findBy(["id" => $ids]);
+        // the bypass for empty array is needed to avoid SQL error (Doctrine issue)
+        return empty($ids) ? [] : $this->findBy(["id" => $ids]);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ public function findOneBy(array $criteria)`
`86`	`86`	`*/`
`87`	`87`	`public function findByIds(array $ids): array`
`88`	`88`	`{`
`89`		`- return $this->findBy(["id" => $ids]);`
	`89`	`+ // the bypass for empty array is needed to avoid SQL error (Doctrine issue)`
	`90`	`+ return empty($ids) ? [] : $this->findBy(["id" => $ids]);`
`90`	`91`	`}`
`91`	`92`
`92`	`93`	`/**`