Fixing ACLs policies for exams (students can submit anything in a group before the beginning of an exam).

Author: krulis-martin

app/V1Module/security/Policies/AssignmentPermissionPolicy.php

@@ -123,13 +123,14 @@ public function userIsNotLockedElsewhereStrictly(Identity $identity, Assignment
     }
 
     /**
-     * The assignment is not in an exam group, or it is already after the exam.
+     * The assignment is not in an exam group, or it is still before/already after the exam.
      */
     public function isExamNotInProgress(Identity $identity, Assignment $assignment): bool
     {
         $group = $assignment->getGroup();
         $now = new DateTime();
-        return $group && (!$group->hasExamPeriodSet($now) || $group->getExamEnd() < $now);
+        return $group && (!$group->hasExamPeriodSet($now) ||
+            $now < $group->getExamBegin() || $group->getExamEnd() < $now);
     }
 
     /**

app/V1Module/security/Policies/GroupPermissionPolicy.php

@@ -4,7 +4,6 @@
 
 use App\Model\Entity\Group;
 use App\Model\Entity\Instance;
-use App\Model\Repository\Groups;
 use App\Security\Identity;
 use DateTIme;