feat: add non null check

Author: QuentinTournier40

src/main/java/dev/resms/ReSMS.java

@@ -5,10 +5,10 @@
 import dev.resms.model.request.SendSmsRequest;
 import dev.resms.model.response.SendSmsResponse;
 import dev.resms.service.SmsService;
+import lombok.NonNull;
 
 /** ReSMS Java SDK - Client principal */
 public class ReSMS {
-  private static final int DEFAULT_TIMEOUT = 10;
   private final SmsService smsService;
 
   /**
@@ -17,7 +17,7 @@ public class ReSMS {
    * @param apiKey API key for authentication
    * @param timeoutSeconds HTTP request timeout in seconds
    */
-  public ReSMS(String apiKey, int timeoutSeconds) {
+  public ReSMS(@NonNull String apiKey, int timeoutSeconds) {
     ReSMSConfig config = new ReSMSConfig(apiKey, timeoutSeconds);
     this.smsService = new SmsService(config);
   }
@@ -27,8 +27,13 @@ public ReSMS(String apiKey, int timeoutSeconds) {
    *
    * @param apiKey API key for authentication
    */
-  public ReSMS(String apiKey) {
-    this(apiKey, DEFAULT_TIMEOUT);
+  public ReSMS(@NonNull String apiKey) {
+    ReSMSConfig config = new ReSMSConfig(apiKey);
+    this.smsService = new SmsService(config);
+  }
+
+  public ReSMS(@NonNull ReSMSConfig config) {
+    this.smsService = new SmsService(config);
   }
 
   /**
@@ -39,7 +44,7 @@ public ReSMS(String apiKey) {
    * @return SendSmsResponse containing the message ID and status
    * @throws ReSMSException if fails
    */
-  public SendSmsResponse send(String to, String message) throws ReSMSException {
+  public SendSmsResponse send(@NonNull String to, @NonNull String message) throws ReSMSException {
     return smsService.send(to, message);
   }
 
@@ -50,7 +55,7 @@ public SendSmsResponse send(String to, String message) throws ReSMSException {
    * @return SendSmsResponse containing the message ID and status
    * @throws ReSMSException if fails
    */
-  public SendSmsResponse send(SendSmsRequest request) throws ReSMSException {
+  public SendSmsResponse send(@NonNull SendSmsRequest request) throws ReSMSException {
     return smsService.send(request);
   }
 }

src/main/java/dev/resms/config/ReSMSConfig.java

@@ -3,20 +3,28 @@
 import java.net.http.HttpClient;
 import java.time.Duration;
 import lombok.Getter;
+import lombok.NonNull;
 
 /** Configuration class for ReSMS SDK */
 @Getter
 public class ReSMSConfig {
   public static final String BASE_URL = "https://api.resms.dev/";
+  private static final int DEFAULT_TIMEOUT = 10;
 
   private final String apiKey;
-  private final int timeoutSeconds;
   private final HttpClient httpClient;
 
-  public ReSMSConfig(String apiKey, int timeoutSeconds) {
+  public ReSMSConfig(@NonNull String apiKey, int timeoutSeconds) {
+    if (apiKey.isBlank()) {
+      throw new IllegalArgumentException("API key cannot be blank");
+    }
+
     this.apiKey = apiKey.trim();
-    this.timeoutSeconds = timeoutSeconds;
     this.httpClient =
         HttpClient.newBuilder().connectTimeout(Duration.ofSeconds(timeoutSeconds)).build();
   }
+
+  public ReSMSConfig(String apiKey) {
+    this(apiKey, DEFAULT_TIMEOUT);
+  }
 }

src/main/java/dev/resms/model/request/SendSmsRequest.java

@@ -2,11 +2,12 @@
 
 import lombok.AllArgsConstructor;
 import lombok.Getter;
+import lombok.NonNull;
 
 /** Request object for sending SMS */
 @Getter
 @AllArgsConstructor
 public class SendSmsRequest {
-  private final String to;
-  private final String message;
+  @NonNull private final String to;
+  @NonNull private final String message;
 }

src/main/java/dev/resms/repository/SmsRepository.java

@@ -16,7 +16,6 @@
 import java.net.URI;
 import java.net.http.HttpRequest;
 import java.net.http.HttpResponse;
-import java.time.Duration;
 import org.apache.hc.core5.http.HttpStatus;
 
 /** Generic API client for HTTP requests */
@@ -53,7 +52,6 @@ public SendSmsResponse sendSms(SendSmsRequest requestBody) throws ReSMSException
             .uri(URI.create(ReSMSConfig.BASE_URL + SEND_SMS_PATH))
             .header("Content-Type", "application/json")
             .header("X-Api-Key", config.getApiKey())
-            .timeout(Duration.ofSeconds(config.getTimeoutSeconds()))
             .POST(HttpRequest.BodyPublishers.ofString(jsonBody))
             .build();
 

src/main/java/dev/resms/service/SmsService.java

@@ -6,12 +6,13 @@
 import dev.resms.model.response.SendSmsResponse;
 import dev.resms.repository.SmsRepository;
 import dev.resms.utils.ValidationUtil;
+import lombok.NonNull;
 
 /** SMS service for sending SMS messages */
 public class SmsService {
   private final SmsRepository apiClient;
 
-  public SmsService(ReSMSConfig config) {
+  public SmsService(@NonNull ReSMSConfig config) {
     this.apiClient = new SmsRepository(config);
   }
 
@@ -23,7 +24,7 @@ public SmsService(ReSMSConfig config) {
    * @return SendSmsResponse containing the message ID and status
    * @throws ReSMSException if fails
    */
-  public SendSmsResponse send(String to, String message) throws ReSMSException {
+  public SendSmsResponse send(@NonNull String to, @NonNull String message) throws ReSMSException {
     ValidationUtil.validatePhoneNumber(to);
     ValidationUtil.validateMessage(message);
     SendSmsRequest request = new SendSmsRequest(to, message);
@@ -37,7 +38,7 @@ public SendSmsResponse send(String to, String message) throws ReSMSException {
    * @return SendSmsResponse containing the message ID and status
    * @throws ReSMSException if fails
    */
-  public SendSmsResponse send(SendSmsRequest request) throws ReSMSException {
+  public SendSmsResponse send(@NonNull SendSmsRequest request) throws ReSMSException {
     ValidationUtil.validateSendSmsRequest(request);
     return apiClient.sendSms(request);
   }