fix(settings): label account action "Logout" instead of "Terminate business relationship"#721
Merged
Merged
Conversation
…e business relationship" The settings entry opens a logout flow (confirm sheet -> DeleteCurrentWalletEvent), but its label read "Terminate business relationship" / "Geschaeftsbeziehung beenden", implying account closure rather than signing out. Align the label with the logout wording already used across the confirm sheet (realunitWalletLogout / logout) after tester feedback flagged the original term as misleading.
…m regen The golden-regenerate run rewrote home_page_loaded.png with a ~5-byte sub-pixel/encoder drift unrelated to this change, which only touches the settings logout label. Per the repo convention (tolerate sub-pixel drift rather than churn baselines), restore the staging home baseline and keep only the two settings page baselines that genuinely changed.
The handbook prose still referred to the settings entry as "Geschaeftsbeziehung beenden". Update the three references (settings list, screenshot alt text, and the confirm-sheet description) to "Abmelden" so the handbook matches the renamed in-app label. Only hand-authored prose is touched; the auto-assembled store-listing and legal-downloads blocks are untouched.
The tier-3 handbook flow tapped the settings entry via text selector ".*Geschaeftsbeziehung beenden.*". Since the entry is renamed to "Abmelden", that tap would no longer match and the flow would time out waiting for the confirm sheet. Retarget the selector to ".*Abmelden.*" (still gated on the sheet not yet being visible, so it cannot mis-tap the sheet's own logout button) and update the surrounding comments to match.
TaprootFreak
added
the
tier3:full
Contributor
Author
|
kann man mergen wenn ci grün |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The account action in Settings opens a logout flow but was labelled "Terminate business relationship" (DE: "Geschäftsbeziehung beenden"), implying account closure rather than signing out. Relabel it to "Logout" / "Abmelden", consistent with the wording already used throughout the confirm sheet (
realunitWalletLogout,logout).Why
The settings entry triggers
SettingsConfirmLogoutWalletSheet→DeleteCurrentWalletEvent: a local logout that removes the wallet from the device (hence the recovery-phrase-backup acknowledgement the sheet forces before the action). It does not terminate the DFX business relationship, so the previous label was misleading and caused tester confusion.Only the user-facing string changes. The i18n key (
settingsDeleteWallet) and all logic are intentionally untouched to keep the change focused.Changes
assets/languages/strings_{de,en}.arb:"Geschäftsbeziehung beenden"→"Abmelden","Terminate business relationship"→"Logout".settings_page_default.png,settings_page_bitbox.png); an unrelated ~5 B sub-pixel drift on the home baseline from the regen run was reverted to keep the diff scoped.docs/handbook/de/index.html: synced the three references to the renamed entry (settings list, screenshot alt text, confirm-sheet description)..maestro/handbook/24-settings-delete-wallet.yaml: retargeted the tap selector from.*Geschäftsbeziehung beenden.*to.*Abmelden.*so the tier-3 handbook flow keeps finding the entry (still gated on the confirm sheet not yet being visible).Test plan
Analyze & TestgreenVisual Regressiongreen (settings page baselines reflect the new label)Coverage Floor GategreenHandbook Build Checkgreen