Fix request parameters builder (#22)

Author: slavcodev

src/Schema.php

@@ -310,6 +310,7 @@ private static function fetch($schema, ...$paths)
 
     /**
      * A list of parameters that are applicable for this operation.
+     *
      * If a parameter is already defined at the Path Item,
      * the new definition will override it, but can never remove it.
      *
@@ -323,10 +324,34 @@ private function getRequestParameters($template, $method, $location)
     {
         $path = $this->fetch($this->schema, 'paths', $template);
 
-        $parameters = $this->fetch($path, $method, 'parameters') ?: $this->fetch($path, 'parameters');
+        $operationParameters = $this->normalizeRequestParameters(
+            (array) $this->fetch($path, $method, 'parameters'),
+            $location
+        );
+
+        $pathParameters = $this->normalizeRequestParameters(
+            (array) $this->fetch($path, 'parameters'),
+            $location
+        );
+
+        return $operationParameters + $pathParameters;
+    }
+
+    /**
+     * Normalizes parameters definitions.
+     *
+     * Filter parameters by location, and use name as list index.
+     *
+     * @param array $parameters
+     * @param string $location
+     *
+     * @return object[]
+     */
+    private function normalizeRequestParameters(array $parameters, $location)
+    {
         $schemas = [];
 
-        foreach ((array) $parameters as $parameter) {
+        foreach ($parameters as $parameter) {
             if ($parameter->in !== $location) {
                 continue;
             }

tests/SchemaTest.php

@@ -167,6 +167,57 @@ public function howToUseSwagger(Schema $spec)
         $this->assertNull($responseBody);
     }
 
+    /**
+     * @test
+     */
+    public function shouldGetUnionOfParameters()
+    {
+        $spec = new Schema(
+            $this->createObject(
+                [
+                    'swagger' => '2.0',
+                    'host' => 'localhost',
+                    'paths' => [
+                        '/posts' => [
+                            'parameters' => [
+                                [
+                                    'name' => 'foo',
+                                    'in' => 'header',
+                                    'required' => false,
+                                ],
+                                [
+                                    'name' => 'bar',
+                                    'in' => 'header',
+                                ],
+                            ],
+                            'get' => [
+                                'parameters' => [
+                                    [
+                                        'name' => 'baz',
+                                        'in' => 'header',
+                                    ],
+                                    [
+                                        'name' => 'foo',
+                                        'in' => 'header',
+                                        'required' => true,
+                                    ],
+                                ],
+                            ],
+                        ],
+                    ],
+                ]
+            )
+        );
+
+        $parameters = $spec->getRequestHeaderSchemas('/posts', 'get');
+
+        $this->assertCount(3, $parameters);
+        $this->assertArrayHasKey('foo', $parameters);
+        $this->assertArrayHasKey('bar', $parameters);
+        $this->assertArrayHasKey('baz', $parameters);
+        $this->assertSame(true, $parameters['foo']->required);
+    }
+
     /**
      * @test
      */