From 18712a917eadc001e49697512ec9beb0b00a8293 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ladislav=20Va=C5=A1ina?= Date: Tue, 2 Jun 2026 12:49:34 +0200 Subject: [PATCH] Use timeout with int instead of num_sec --- src/widgetastic_patternfly4/chipgroup.py | 6 +++--- src/widgetastic_patternfly4/navigation.py | 2 +- testing/ouia/test_pagination_ouia.py | 2 +- testing/test_cardview.py | 2 +- testing/test_pagination.py | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/widgetastic_patternfly4/chipgroup.py b/src/widgetastic_patternfly4/chipgroup.py index 8f5676c7..3fbeabb4 100644 --- a/src/widgetastic_patternfly4/chipgroup.py +++ b/src/widgetastic_patternfly4/chipgroup.py @@ -102,7 +102,7 @@ def _gone(): if not self.read_only: self.button.click() - wait_for(_gone, num_sec=3, message="wait for chip to dissappear", delay=0.1) + wait_for(_gone, timeout=3, message="wait for chip to disappear", delay=0.1) else: raise ChipReadOnlyError(self, "Chip is read-only") @@ -131,7 +131,7 @@ def show_more(self): self._text.click() wait_for( func=self._show_less_shown, - num_sec=3, + timeout=3, delay=0.1, message="wait for 'show less' button to appear", ) @@ -142,7 +142,7 @@ def show_less(self): self._text.click() wait_for( self._show_more_shown, - num_sec=3, + timeout=3, delay=0.1, message="wait for 'show more' button to appear", ) diff --git a/src/widgetastic_patternfly4/navigation.py b/src/widgetastic_patternfly4/navigation.py index 33df14f7..14129d8c 100644 --- a/src/widgetastic_patternfly4/navigation.py +++ b/src/widgetastic_patternfly4/navigation.py @@ -41,7 +41,7 @@ def loaded(self): self.logger.info("Navigation not ready yet") wait_for( lambda: self.browser.element(".").get_attribute("data-ouia-safe") == "true", - num_sec=10, + timeout=10, ) elif not out: self.logger.info("Navigation doesn't have 'data-ouia-safe' property") diff --git a/testing/ouia/test_pagination_ouia.py b/testing/ouia/test_pagination_ouia.py index bd8f4803..a9cd95ec 100644 --- a/testing/ouia/test_pagination_ouia.py +++ b/testing/ouia/test_pagination_ouia.py @@ -19,7 +19,7 @@ class TestView(View): paginator = Pagination("pagination-options-menu-top") paginator = TestView(browser).paginator - wait_for(lambda: paginator.is_displayed, num_sec=10) + wait_for(lambda: paginator.is_displayed, timeout=10) yield paginator try: paginator.first_page() diff --git a/testing/test_cardview.py b/testing/test_cardview.py index 9a7e0d79..c3595e4f 100644 --- a/testing/test_cardview.py +++ b/testing/test_cardview.py @@ -33,7 +33,7 @@ def __init__(self, parent, locator=None, logger=None, **kwargs): @pytest.fixture def cards(browser): cards = Cards(browser) - wait_for(lambda: cards.is_displayed, timeout="15s") + wait_for(lambda: cards.is_displayed, timeout=15) return cards diff --git a/testing/test_pagination.py b/testing/test_pagination.py index bf0b7530..4cf1629a 100644 --- a/testing/test_pagination.py +++ b/testing/test_pagination.py @@ -20,7 +20,7 @@ class TestView(View): paginator = paginator_cls(locator="./div") paginator = TestView(browser).paginator - wait_for(lambda: paginator.is_displayed, num_sec=10) + wait_for(lambda: paginator.is_displayed, timeout=10) yield paginator try: paginator.first_page()