Patch to don't block call actor on Stopping state waiting for MmsCallController response

This close #2261

Author: gvagenas

restcomm/restcomm.commons/src/main/java/org/restcomm/connect/commons/faulttolerance/RestcommSupervisorStrategy.java

@@ -22,7 +22,7 @@ public class RestcommSupervisorStrategy implements SupervisorStrategyConfigurato
 
     final SupervisorStrategy.Directive strategy = resume();
 
-    RestcommFaultToleranceStrategy defaultStrategy = new RestcommFaultToleranceStrategy(10, Duration.create("1 minute"),
+   RestcommFaultToleranceStrategy defaultStrategy = new RestcommFaultToleranceStrategy(10, Duration.create("1 minute"),
             new RestcommFaultToleranceDecider());
 
     @Override

restcomm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/Call.java

@@ -378,6 +378,7 @@ public Call(final SipFactory factory, final ActorRef mediaSessionController, fin
         transitions.add(new Transition(this.inProgress, this.leaving));
         transitions.add(new Transition(this.inProgress, this.failed));
         transitions.add(new Transition(this.inProgress, this.inDialogRequest));
+        transitions.add(new Transition(this.inProgress, this.completed));
         transitions.add(new Transition(this.joining, this.inProgress));
         transitions.add(new Transition(this.joining, this.stopping));
         transitions.add(new Transition(this.joining, this.failed));
@@ -1726,6 +1727,11 @@ public Stopping(final ActorRef source) {
         public void execute(Object message) throws Exception {
             // Stops media operations and closes media session
             msController.tell(new CloseMediaSession(), source);
+            if (fail) {
+                fsm.transition(message, failed);
+            } else {
+                fsm.transition(message, completed);
+            }
         }
     }
 
@@ -2473,11 +2479,15 @@ private void onMediaServerControllerStateChanged(MediaServerControllerStateChang
 
             case INACTIVE:
                 if (is(stopping)) {
-                    if (fail) {
-                        fsm.transition(message, failed);
-                    } else {
-                        fsm.transition(message, completed);
+                    if (logger.isDebugEnabled()) {
+                        String msg = String.format("On MediaServerContollerStateChanged, message: INACTIVE, Call state: %s, Fail: %s", fsm.state(), fail);
+                        logger.debug(msg);
                     }
+//                    if (fail) {
+//                        fsm.transition(message, failed);
+//                    } else {
+//                        fsm.transition(message, completed);
+//                    }
                 } else if (is(canceling)) {
                     fsm.transition(message, canceled);
                 } else if (is(failingBusy)) {

restcomm/restcomm.testsuite/src/test/java/org/restcomm/connect/testsuite/telephony/DialRecordingTest.java

@@ -222,7 +222,7 @@ public synchronized void testDialClientAlice_BobDisconnects() throws Interrupted
 		assertNotNull(recording);
 		assertEquals(1, recording.size());
 		double duration = recording.get(0).getAsJsonObject().get("duration").getAsDouble();
-		assertTrue(duration==3.0);
+		assertEquals(3.0, duration, 0);
 	}
 
 	@Test
@@ -422,7 +422,7 @@ public synchronized void testRecordCall() throws InterruptedException, ParseExce
 		assertNotNull(recording);
 		assertEquals(1, recording.size());
 		double duration = recording.get(0).getAsJsonObject().get("duration").getAsDouble();
-		assertEquals(6.0, duration,1);
+		assertEquals(3.0, duration,1);
 
 		metrics = MonitoringServiceTool.getInstance().getMetrics(deploymentUrl.toString(),adminAccountSid, adminAuthToken);
 		assertNotNull(metrics);
@@ -490,7 +490,7 @@ public synchronized void testRecordCallWithAction() throws InterruptedException,
 		assertNotNull(recording);
 		assertEquals(1, recording.size());
 		double duration = recording.get(0).getAsJsonObject().get("duration").getAsDouble();
-		assertEquals(6.0, duration,1);
+		assertEquals(3.0, duration,1);
 
 		metrics = MonitoringServiceTool.getInstance().getMetrics(deploymentUrl.toString(),adminAccountSid, adminAuthToken);
 		assertNotNull(metrics);