improved logging

Author: Maria Farooq

restcomm/restcomm.mgcp/src/main/java/org/restcomm/connect/mgcp/Connection.java

@@ -85,6 +85,7 @@ public final class Connection extends UntypedActor {
     private ActorRef endpoint;
     private EndpointIdentifier endpointId;
     private ConnectionIdentifier connId;
+    private ConnectionIdentifier requestedConnId;
     private ConnectionDescriptor localDesc;
     private ConnectionDescriptor remoteDesc;
     private boolean webrtc;
@@ -198,6 +199,11 @@ public void onReceive(final Object message) throws Exception {
                     fsm.transition(message, open);
                 }
             } else {
+                String err = String.format(
+                        "MGCP Transaction did not executed normally: session: %s | endpointId: %s | requestedConnId: %s | connId: %s",
+                        session.id() + "", endpointId == null ? "null" : endpointId.getLocalEndpointName(),
+                        requestedConnId, connId);
+                logger.error(err);
                 if (modifying.equals(state)) {
                     fsm.transition(message, closing);
                 } else {
@@ -270,7 +276,11 @@ public void execute(final Object message) throws Exception {
             log(ConnectionStateChanged.State.CLOSED);
             // If we timed out log it.
             if (message instanceof ReceiveTimeout) {
-                logger.error("The media gateway failed to respond in the requested timout period.");
+                String err = String.format(
+                        "The media gateway failed to respond in the requested timout period. session: %s | endpointId: %s | requestedConnId: %s | connId: %s",
+                        session.id() + "", endpointId == null ? "null" : endpointId.getLocalEndpointName(),
+                        requestedConnId, connId);
+                logger.error(err);
             }
         }
     }
@@ -435,7 +445,7 @@ public void execute(final Object message) throws Exception {
             final UpdateConnection request = (UpdateConnection) message;
             final String sessionId = Integer.toString(session.id());
             final CallIdentifier callId = new CallIdentifier(sessionId);
-            ConnectionIdentifier requestedConnId = request.connectionIdentifier();
+            requestedConnId = request.connectionIdentifier();
             requestedConnId = requestedConnId==null ? connId:requestedConnId;
             final ModifyConnection mdcx = new ModifyConnection(source, callId, endpointId, requestedConnId);
             final ConnectionMode mode = request.mode();

restcomm/restcomm.mrb/src/main/java/org/restcomm/connect/mrb/MediaResourceBrokerGeneric.java

@@ -20,15 +20,13 @@
  */
 package org.restcomm.connect.mrb;
 
-import akka.actor.ActorRef;
-import akka.actor.Props;
-import akka.actor.UntypedActor;
-import akka.actor.UntypedActorFactory;
-import akka.event.Logging;
-import akka.event.LoggingAdapter;
-import jain.protocol.ip.mgcp.CreateProviderException;
-import jain.protocol.ip.mgcp.JainMgcpProvider;
-import jain.protocol.ip.mgcp.JainMgcpStack;
+import java.net.InetAddress;
+import java.net.URI;
+import java.net.UnknownHostException;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
 import org.apache.commons.configuration.Configuration;
 import org.joda.time.DateTime;
 import org.mobicents.protocols.mgcp.stack.JainMgcpStackImpl;
@@ -43,21 +41,22 @@
 import org.restcomm.connect.dao.entities.ConferenceDetailRecordFilter;
 import org.restcomm.connect.dao.entities.MediaServerEntity;
 import org.restcomm.connect.mgcp.MediaResourceBrokerResponse;
-import org.restcomm.connect.mgcp.PowerOffMediaGateway;
 import org.restcomm.connect.mgcp.PowerOnMediaGateway;
 import org.restcomm.connect.mrb.api.GetConferenceMediaResourceController;
 import org.restcomm.connect.mrb.api.GetMediaGateway;
 import org.restcomm.connect.mrb.api.MediaGatewayForConference;
 import org.restcomm.connect.mrb.api.StartMediaResourceBroker;
 import org.restcomm.connect.telephony.api.ConferenceStateChanged;
 
-import java.net.InetAddress;
-import java.net.URI;
-import java.net.UnknownHostException;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Map;
+import akka.actor.ActorRef;
+import akka.actor.Props;
+import akka.actor.UntypedActor;
+import akka.actor.UntypedActorFactory;
+import akka.event.Logging;
+import akka.event.LoggingAdapter;
+import jain.protocol.ip.mgcp.CreateProviderException;
+import jain.protocol.ip.mgcp.JainMgcpProvider;
+import jain.protocol.ip.mgcp.JainMgcpStack;
 
 /**
  * @author maria.farooq@telestax.com (Maria Farooq)

restcomm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/CallManager.java

@@ -1172,10 +1172,10 @@ private boolean redirectToHostedVoiceApp(final ActorRef self, final SipServletRe
             try {
                 formatedPhone = phoneNumberUtil.format(phoneNumberUtil.parse(phone, "US"), PhoneNumberFormat.E164);
             } catch (NumberParseException e) {
-                if (logger.isInfoEnabled()) {
+                /*if (logger.isInfoEnabled()) {
                     String msg = String.format("Problem while trying to format number %s, exception %s ",phone, e);
                     logger.info(msg);
-                }
+                }*/
             }
         }
         if (formatedPhone == null) {