remove BindOnChangeFlags.ExecuteOnNew for better consistency

Author: RevenantX

LiteEntitySystem/ClientEntityManager.cs

@@ -1077,29 +1077,10 @@ private unsafe void ApplyEntityDelta(
                     if (field.IsPredicted)
                         RefMagic.CopyBlock(predictedData + field.PredictedOffset, fieldData, field.Size);
 
-                    if (field.OnSync != null && insideNewRPC)
-                    {
-                        if ((field.OnSyncFlags & BindOnChangeFlags.ExecuteOnNew) != 0)
-                        {
-                            //execute immediately using temp data buffer inside SetFromAndSync
-                            field.TypeProcessor.SetFromAndSync(target, offset, fieldData, field.OnSync);
-                        }
-                        // call sync calls on first sync in new because constructed will be empty (to reduce datasize)
-                        if (firstSync && (field.OnSyncFlags & BindOnChangeFlags.ExecuteOnSync) != 0)
-                        {
-                            if (field.TypeProcessor.SetFromAndSync(target, offset, fieldData))
-                                _syncCalls[_syncCallsCount++] = new SyncCallInfo(entity, readerPosition, i, !hasData);
-                        }   
-                        //else skip set? because will be triggered in OnConstructed
-                    }
-                    else if (field.OnSync != null && (field.OnSyncFlags & BindOnChangeFlags.ExecuteOnSync) != 0 && field.TypeProcessor.SetFromAndSync(target, offset, fieldData))
-                    {
+                    if (field.OnSync != null && (field.OnSyncFlags & BindOnChangeFlags.ExecuteOnSync) != 0 && field.TypeProcessor.SetFromAndSync(target, offset, fieldData))
                         _syncCalls[_syncCallsCount++] = new SyncCallInfo(entity, readerPosition, i, !hasData);
-                    }
                     else
-                    {
                         field.TypeProcessor.SetFrom(target, offset, fieldData);
-                    }
 
                     if (hasData)
                         readerPosition += field.IntSize;

LiteEntitySystem/ControllerLogic.cs

@@ -38,7 +38,7 @@ protected override void RegisterRPC(ref RPCRegistrator r)
             r.BindOnChange<ControllerLogic, EntitySharedReference>(
                 ref _controlledEntity, 
                 static (e, prev) => e.OnControlledEntityChanged(e.EntityManager.GetEntityById<PawnLogic>(prev)), 
-                BindOnChangeFlags.ExecuteOnSync | BindOnChangeFlags.ExecuteOnNew | BindOnChangeFlags.ExecuteOnServer);
+                BindOnChangeFlags.ExecuteOnSync | BindOnChangeFlags.ExecuteOnServer);
         }
 
         /// <summary>

LiteEntitySystem/RPCRegistrator.cs

@@ -28,11 +28,6 @@ public enum BindOnChangeFlags
         /// </summary>
         ExecuteOnRollbackReset = 1 << 3,
 
-        /// <summary>
-        /// Execute after entity new() called and initial state read before OnConstructed
-        /// </summary>
-        ExecuteOnNew =         1 << 4,
-        
         /// <summary>
         /// Combines ExecuteOnSync, ExecuteOnPrediction and ExecuteOnServer flags
         /// </summary>