Merge pull request #7 from tsvgos/curl-error-handling

Richardds · web-flow · commit c6ebf5bc11ef · 2018-10-24T20:13:35.000+02:00
Improve cURL error handling
diff --git a/src/ECB.php b/src/ECB.php
@@ -73,8 +73,9 @@ private static function fetch(string $url): string
             return $data;
         }
 
+        $curl_error = curl_error($ch);
         curl_close($ch);
 
-        throw new ECBException(curl_error($ch), ECBException::DATA_DOWNLOAD_FAILED);
+        throw new ECBException($curl_error, ECBException::DATA_DOWNLOAD_FAILED);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,9 @@ private static function fetch(string $url): string`
`73`	`73`	`return $data;`
`74`	`74`	`}`
`75`	`75`
	`76`	`+ $curl_error = curl_error($ch);`
`76`	`77`	`curl_close($ch);`
`77`	`78`
`78`		`- throw new ECBException(curl_error($ch), ECBException::DATA_DOWNLOAD_FAILED);`
	`79`	`+ throw new ECBException($curl_error, ECBException::DATA_DOWNLOAD_FAILED);`
`79`	`80`	`}`
`80`	`81`	`}`