Merge pull request DOI-NPS#170 from nationalparkservice/sarah-dev

Remove unnecessary function and dependency

Author: wright13

DESCRIPTION

@@ -1,13 +1,14 @@
 Package: DPchecker
 Title: Checks Data Packages for Congruence
-Version: 1.0.1
+Version: 1.1.0
 Authors@R: c(
     person("Rob", "Baker", email = "robert_baker@nps.gov", role = c("cre", "aut"), comment = c(ORCID = "0000-0001-7591-5035")),
     person(c("Sarah", "E."), "Wright", email = "sarah_wright@nps.gov", role = "aut"),
     person("Issac", "Quevedo", role = "ctb"),
     person("Amelia", "Sherman", role = "ctb"))
 Description: Allows the user (and reviewer) to check a data package and test whether it meets the congruence standards set forth by NPS for upload to DataStore as a datapackage.
 License: MIT + file LICENSE
+BugReports: https://github.com/nationalparkservice/DPchecker/issues
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.3.2
@@ -16,8 +17,7 @@ Suggests:
     here,
     rstudioapi,
     testthat (>= 3.0.0),
-    knitr,
-    EMLeditor
+    knitr
 Config/testthat/edition: 3
 Imports:
     EML,
@@ -33,8 +33,9 @@ Imports:
     httr,
     jsonlite,
     QCkit,
+    EMLeditor,
     lifecycle
 Remotes: 
     https://github.com/nationalparkservice/QCkit,
     https://github.com/nationalparkservice/EMLeditor
-URL: https://nationalparkservice.github.io/DPchecker/
+URL: https://github.com/nationalparkservice/DPchecker, https://nationalparkservice.github.io/DPchecker/

NAMESPACE

@@ -43,7 +43,6 @@ export(test_pii_data_emails)
 export(test_pii_meta_emails)
 export(test_project)
 export(test_pub_date)
-export(test_public_points)
 export(test_publisher)
 export(test_publisher_city)
 export(test_publisher_state)

NEWS.md

@@ -1,4 +1,8 @@
-# DPchecker 1.0.1 (under development)
+# DPchecker 1.1.0 (under development)
+## 2025-04-23
+  * Remove `test_public_points()` function. DataStore previously made GPS coordinates public, even when data files were restricted-access, so this function was written to alert users of that fact. DataStore now applies the same access rules to GPS coordinates and data files, so this check is no longer needed.
+
+# DPchecker 1.0.1
 ## 2025-04-24
   * add function `test_datatable_url_attributes` to test for the appropriate attribute in the xml designation in metadata for urls. 
   * Added unit tests for `test_datatable_url_attributes`, `test_datatable_urls_doi`, and `test_datatable_urls`

R/optional_data_checks.R

@@ -13,51 +13,52 @@
 #' test_pii_data_emails()
 #' }
 test_pii_data_emails <- function(directory = here::here()) {
-
-  #get the full file names and paths for all files in directory
+  # get the full file names and paths for all files in directory
   files <- list.files(directory, full.names = TRUE)
 
-  emails_list <- NULL #list of lists containing offending emails.
-  #populate emails_list with pii emails:
-  for(file in files){
-    data_emails <- NULL #holds  emails
-    email_files <- NULL #holds names of files that contain emails
+  emails_list <- NULL # list of lists containing offending emails.
+  # populate emails_list with pii emails:
+  for (file in files) {
+    data_emails <- NULL # holds  emails
+    email_files <- NULL # holds names of files that contain emails
     personal_emails <- NULL # holds offending emails
-    if(grepl(".csv", file, ignore.case = TRUE)) {
-      #read data line by line, concatenate lines (emails split across a lines)
+    if (grepl(".csv", file, ignore.case = TRUE)) {
+      # read data line by line, concatenate lines (emails split across a lines)
       data_lines <- paste(readLines(file), collapse = " ")
-      #for each csv file, extract all emails and add them to file_emails
+      # for each csv file, extract all emails and add them to file_emails
       data_emails <- suppressWarnings(
-        regmatches(data_lines,gregexpr("([_+a-z0-9-]+(\\.[_+a-z0-9-]+)*@[a-z0-9-]+(\\.[a-z0-9-]+)*(\\.[a-z]{2,14}))", data_lines)))
+        regmatches(data_lines, gregexpr("([_+a-z0-9-]+(\\.[_+a-z0-9-]+)*@[a-z0-9-]+(\\.[a-z0-9-]+)*(\\.[a-z]{2,14}))", data_lines))
+      )
       data_emails <- unlist(data_emails, recursive = FALSE)
 
-      #if a file contains emails, check for offending emails:
-      if(length(seq_along(data_emails)) > 0){
-        for(i in seq_along(data_emails)){
-          #filter out .govs
-          if(!stringr::str_detect(data_emails[i], ".gov")){
+      # if a file contains emails, check for offending emails:
+      if (length(seq_along(data_emails)) > 0) {
+        for (i in seq_along(data_emails)) {
+          # filter out .govs
+          if (!stringr::str_detect(data_emails[i], ".gov")) {
             personal_emails <- append(personal_emails, data_emails[i])
           }
         }
       }
-      if(!is.null(personal_emails)){
+      if (!is.null(personal_emails)) {
         pii_emails <- list(personal_emails)
         names(pii_emails) <- basename(file)
-        emails_list<-append(emails_list, pii_emails)
+        emails_list <- append(emails_list, pii_emails)
       }
     }
   }
-  #if there are offending emails, fail with warning:
-  if(!is.null(emails_list)){
+  # if there are offending emails, fail with warning:
+  if (!is.null(emails_list)) {
     msg <- paste0("--> {.file ", names(emails_list), "}: ", unlist(emails_list))
     names(msg) <- rep(" ", length(msg))
     err <- paste0("The following data files contain emails with potential PII:")
 
     cli::cli_warn(c("!" = err, msg))
-  #if no pii emails (non .gov), pass test:
+    # if no pii emails (non .gov), pass test:
   } else {
     cli::cli_inform(
-      c("v" = "Data files do not appear to contain any personal emails."))
+      c("v" = "Data files do not appear to contain any personal emails.")
+    )
   }
-  #return(invisible(metadata))
+  # return(invisible(metadata))
 }