Fix IndexOutofRange exception

Author: RobThree

TextTableBuilder.Tests/TableBuilderTests.cs

@@ -1,9 +1,19 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
+using System;
 
 namespace TextTableBuilder.Tests;
 
 [TestClass]
 public class TableBuilderTests
 {
-    //TODO...
+    [TestMethod]
+    public void Foo()
+    {
+        var table = new Table()
+            .AddColumns(new[] { "A", "B", "C" })
+            .AddRow(1, Guid.NewGuid(), DateTime.Now);
+
+        var tb = new TableBuilder();
+        var result = tb.Build(table);
+    }
 }

TextTableBuilder/TableBuilder.cs

@@ -38,9 +38,17 @@ public string Build(Table table, ITableRenderer tableRenderer, IFormatProvider f
             throw new ArgumentNullException(nameof(formatProvider));
         }
 
-        // Iterate all rows, creating strings from all values and keep track of column widths
         var cols = table.Columns.ToArray();
+
+        if (cols.Length == 0)
+        {
+            throw new InvalidOperationException("At least one column must be specified");
+        }
+
+        // Determine preliminary columnwidths
         var colwidths = cols.Select((c, i) => Math.Max(cols[i].MinWidth ?? 0, Math.Min(c.Width ?? int.MaxValue, c.Name.Length))).ToArray();  // Initialize column widths to header widths or minimum widths or fixed widths; whichever is larger
+
+        // Iterate all rows, creating strings from all values and keep track of column widths
         var rows = new List<string[]>(table.Rows.Count);
         foreach (var row in table.Rows)
         {
@@ -51,7 +59,9 @@ public string Build(Table table, ITableRenderer tableRenderer, IFormatProvider f
                 ObjectRow or => (ObjectHandlers.GetHandler(or.Value.GetType()) ?? ObjectHandlers.GetHandler(typeof(object))).Handle(or.Value, cols.Length),
                 _ => throw new InvalidOperationException("Unknown rowtype")
             }).Select(
-                    (v, i) => v is null
+                    (v, i) => i >= cols.Length
+                    ? throw new InvalidOperationException($"Number of values must match columns (row index: {rows.Count})")
+                    : v is null
                         // Handle the special null-case with our NullHandler (if any, empty string otherwise)
                         ? (TypeHandlers.NullValueHandler?.Handle(formatProvider) ?? string.Empty)
                         // Use typehandler from colum when specified, else use typehandler from type from value
@@ -60,8 +70,9 @@ public string Build(Table table, ITableRenderer tableRenderer, IFormatProvider f
             // Make sure we have all cells
             if (rowvalues.Length != cols.Length)
             {
-                throw new InvalidOperationException($"Number of values must match columns (row {rows.Count})");
+                throw new InvalidOperationException($"Number of values must match columns (row index: {rows.Count})");
             }
+
             // Add row to internal collection
             rows.Add(rowvalues);
             // Update column widths

TextTableBuilder/TextTableBuilder.csproj

@@ -17,8 +17,8 @@
 		<PackageTags>text;table;simple</PackageTags>
 		<PackageReadmeFile>README.md</PackageReadmeFile>
 		<PackageLicenseExpression>MIT</PackageLicenseExpression>
-		<Version>1.1.0</Version>
-		<PackageReleaseNotes>Added table renderers</PackageReleaseNotes>
+		<Version>1.1.1</Version>
+		<PackageReleaseNotes>Fix IndexOutofRange exception</PackageReleaseNotes>
 	</PropertyGroup>
 
 	<ItemGroup>