Skip to content

Commit 305d9ee

Browse files
committed
style: format py and cpp
1 parent 4509f81 commit 305d9ee

4 files changed

Lines changed: 55 additions & 33 deletions

File tree

python/rcs/__init__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66

77
from gymnasium import register
88
from rcs._core import __version__, common
9-
from rcs.envs.creators import FR3SimplePickUpSimEnvCreator, FR3LabDigitGripperPickUpSimEnvCreator
9+
from rcs.envs.creators import (
10+
FR3LabDigitGripperPickUpSimEnvCreator,
11+
FR3SimplePickUpSimEnvCreator,
12+
)
1013

1114
from rcs import camera, envs, hand, sim
1215

python/rcs/envs/creators.py

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import logging
22
import typing
3+
from functools import partial
34
from typing import Type
45

56
import gymnasium as gym
@@ -27,7 +28,6 @@
2728
SimWrapper,
2829
)
2930
from rcs.envs.utils import default_sim_gripper_cfg, default_sim_robot_cfg
30-
from functools import partial
3131

3232
import rcs
3333
from rcs import sim
@@ -163,7 +163,7 @@ def __call__( # type: ignore
163163
missing_keys = [key for key in required_keys if key not in random_pos_args]
164164
logger.warning(f"Missing random position arguments: {missing_keys}; Defaulting to RandomCubePos")
165165
random_env = partial(RandomObjectPos, **random_pos_args)
166-
166+
167167
env_rel = SimEnvCreator()(
168168
control_mode=control_mode,
169169
robot_cfg=robot_cfg,
@@ -192,7 +192,7 @@ def __call__( # type: ignore
192192
resolution: tuple[int, int] | None = None,
193193
frame_rate: int = 0,
194194
delta_actions: bool = True,
195-
cam_list: list[str] = ["wrist", "bird_eye", "side", "right_side", "left_side", "front"]
195+
cam_list: list[str] = ["wrist", "bird_eye", "side", "right_side", "left_side", "front"],
196196
) -> gym.Env:
197197
if resolution is None:
198198
resolution = (256, 256)
@@ -210,6 +210,7 @@ def __call__( # type: ignore
210210

211211
return SimTaskEnvCreator()(robot_cfg, render_mode, control_mode, delta_actions, cameras)
212212

213+
213214
class FR3LabDigitGripperPickUpSimEnvCreator(EnvCreator):
214215
def __call__( # type: ignore
215216
self,
@@ -219,7 +220,7 @@ def __call__( # type: ignore
219220
frame_rate: int = 0,
220221
delta_actions: bool = True,
221222
cam_list: list[str] = [],
222-
mjcf_path: str = ''
223+
mjcf_path: str = "",
223224
) -> gym.Env:
224225
if resolution is None:
225226
resolution = (256, 256)
@@ -237,20 +238,24 @@ def __call__( # type: ignore
237238
for cam in cam_list
238239
}
239240
robot_cfg = rcs.sim.SimRobotConfig()
240-
robot_cfg.tcp_offset = rcs.common.Pose(translation=np.array([0.0, 0.0, 0.15]), rotation=np.array([[0.707, 0.707, 0], [-0.707, 0.707, 0], [0, 0, 1]]))
241+
robot_cfg.tcp_offset = rcs.common.Pose(
242+
translation=np.array([0.0, 0.0, 0.15]),
243+
rotation=np.array([[0.707, 0.707, 0], [-0.707, 0.707, 0], [0, 0, 1]]),
244+
)
241245
robot_cfg.robot_type = rcs.common.RobotType.FR3
242246
robot_cfg.realtime = False
243-
robot_cfg.add_id("0") # only required for fr3
247+
robot_cfg.add_id("0") # only required for fr3
244248
robot_cfg.mjcf_scene_path = mjcf_path
245-
robot_cfg.kinematic_model_path = rcs.scenes["fr3_empty_world"].mjcf_robot # .urdf (in case for urdf)
246-
print(f"Creating FR3LabDigitGripperPickUpSim with the following parameters: \n"
247-
f" render_mode: {render_mode}\n"
248-
f" control_mode: {control_mode}\n"
249-
f" resolution: {resolution}\n"
250-
f" frame_rate: {frame_rate}\n"
251-
f" delta_actions: {delta_actions}\n"
252-
f" cameras: {cameras}\n"
253-
f" mjcf_path: {mjcf_path}\n"
254-
)
249+
robot_cfg.kinematic_model_path = rcs.scenes["fr3_empty_world"].mjcf_robot # .urdf (in case for urdf)
250+
print(
251+
f"Creating FR3LabDigitGripperPickUpSim with the following parameters: \n"
252+
f" render_mode: {render_mode}\n"
253+
f" control_mode: {control_mode}\n"
254+
f" resolution: {resolution}\n"
255+
f" frame_rate: {frame_rate}\n"
256+
f" delta_actions: {delta_actions}\n"
257+
f" cameras: {cameras}\n"
258+
f" mjcf_path: {mjcf_path}\n"
259+
)
255260

256-
return SimTaskEnvCreator()(robot_cfg, render_mode, control_mode, delta_actions, cameras)
261+
return SimTaskEnvCreator()(robot_cfg, render_mode, control_mode, delta_actions, cameras)

python/rcs/envs/sim.py

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ def env_from_xml_paths(
276276
truncate_on_collision=truncate_on_collision,
277277
)
278278

279+
279280
class RandomObjectPos(SimWrapper):
280281
"""
281282
Wrapper to randomly re-place an object in the lab environments.
@@ -290,12 +291,15 @@ class RandomObjectPos(SimWrapper):
290291
include_rotation (bool): Whether to include rotation in the randomization.
291292
"""
292293

293-
def __init__(self, env: gym.Env,
294-
simulation: sim.Sim,
295-
joint_name: str,
296-
init_object_pose: rcs.common.Pose,
297-
include_position: bool = True,
298-
include_rotation: bool = False):
294+
def __init__(
295+
self,
296+
env: gym.Env,
297+
simulation: sim.Sim,
298+
joint_name: str,
299+
init_object_pose: rcs.common.Pose,
300+
include_position: bool = True,
301+
include_rotation: bool = False,
302+
):
299303
super().__init__(env, simulation)
300304
self.joint_name = joint_name
301305
self.init_object_pose = init_object_pose
@@ -305,33 +309,42 @@ def __init__(self, env: gym.Env,
305309
def reset(
306310
self, seed: int | None = None, options: dict[str, Any] | None = None
307311
) -> tuple[dict[str, Any], dict[str, Any]]:
308-
if(options is not None and "RandomObjectPos.init_object_pose" in options.keys()):
309-
assert isinstance(options["RandomObjectPos.init_object_pose"], rcs.common.Pose), \
310-
"RandomObjectPos.init_object_pose must be a rcs.common.Pose"
312+
if options is not None and "RandomObjectPos.init_object_pose" in options.keys():
313+
assert isinstance(
314+
options["RandomObjectPos.init_object_pose"], rcs.common.Pose
315+
), "RandomObjectPos.init_object_pose must be a rcs.common.Pose"
311316

312317
self.init_object_pose = options["RandomObjectPos.init_object_pose"]
313318
print("Got random object pos!\n", self.init_object_pose)
314319
del options["RandomObjectPos.init_object_pose"]
315320
obs, info = super().reset(seed=seed, options=options)
316321
self.sim.step(1)
317-
318322

319323
pos_z = self.init_object_pose.translation()[2]
320-
if(self.include_position):
324+
if self.include_position:
321325
pos_x = self.init_object_pose.translation()[0] + np.random.random() * 0.2 - 0.1
322326
pos_y = self.init_object_pose.translation()[1] + np.random.random() * 0.2 - 0.1
323327
else:
324328
pos_x = self.init_object_pose.translation()[0]
325329
pos_y = self.init_object_pose.translation()[1]
326330

327-
quat = self.init_object_pose.rotation_q() # xyzw format
331+
quat = self.init_object_pose.rotation_q() # xyzw format
328332
if self.include_rotation:
329-
self.sim.data.joint(self.joint_name).qpos = [pos_x, pos_y, pos_z, 2 * np.random.random() - quat[3], quat[0], quat[1], quat[2]]
333+
self.sim.data.joint(self.joint_name).qpos = [
334+
pos_x,
335+
pos_y,
336+
pos_z,
337+
2 * np.random.random() - quat[3],
338+
quat[0],
339+
quat[1],
340+
quat[2],
341+
]
330342
else:
331343
self.sim.data.joint(self.joint_name).qpos = [pos_x, pos_y, pos_z, quat[3], quat[0], quat[1], quat[2]]
332344

333345
return obs, info
334-
346+
347+
335348
class RandomCubePos(SimWrapper):
336349
"""Wrapper to randomly place cube in the lab environments."""
337350

src/sim/SimRobot.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ void SimRobot::init_ids() {
7575
// Joints
7676
for (size_t i = 0; i < std::size(this->cfg.joints); ++i) {
7777
name = this->cfg.joints[i];
78-
this->ids.joints.push_back(mj_name2id(this->sim->m, mjOBJ_JOINT, name.c_str()));
78+
this->ids.joints.push_back(
79+
mj_name2id(this->sim->m, mjOBJ_JOINT, name.c_str()));
7980
if (this->ids.joints[i] == -1) {
8081
throw std::runtime_error(std::string("No joint named " + name));
8182
}

0 commit comments

Comments
 (0)