Merge pull request #199 from minggangw/fix-publish-return

Minggang Wang · web-flow · commit 366a57c04309 · 2017-11-24T09:56:53.000+08:00
Delete the unnecessary else branch
diff --git a/lib/publisher.js b/lib/publisher.js
@@ -51,12 +51,8 @@ class Publisher extends Entity {
     }
 
     let rawRosMessage = rclMessage.serialize();
-    if (rawRosMessage) {
-      rclnodejs.publish(this._handle, rawRosMessage);
-      debug('Message has been published.');
-    } else {
-      debug('Message was not published:', rclMessage);
-    }
+    rclnodejs.publish(this._handle, rawRosMessage);
+    debug('Message has been published.');
   }
 
   static createPublisher(nodeHandle, typeClass, topic, qos) {

Original file line number	Diff line number	Diff line change
`@@ -51,12 +51,8 @@ class Publisher extends Entity {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`let rawRosMessage = rclMessage.serialize();`
`54`		`- if (rawRosMessage) {`
`55`		`- rclnodejs.publish(this._handle, rawRosMessage);`
`56`		`- debug('Message has been published.');`
`57`		`- } else {`
`58`		`- debug('Message was not published:', rclMessage);`
`59`		`- }`
	`54`	`+ rclnodejs.publish(this._handle, rawRosMessage);`
	`55`	`+ debug('Message has been published.');`
`60`	`56`	`}`
`61`	`57`
`62`	`58`	`static createPublisher(nodeHandle, typeClass, topic, qos) {`