Skip to content

Commit fbf067e

Browse files
author
Minggang Wang
authored
Remove the TODO which has been implemented.
1 parent 691a892 commit fbf067e

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

circle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dependencies:
1818
- export PATH=/usr/local/Cellar/numpy/1.13.1_1/libexec/nose/bin:$PATH && mkdir -p ~/ros2_ws/src && cd ~/ros2_ws && wget https://raw.githubusercontent.com/ros2/ros2/master/ros2.repos && vcs import src < ros2.repos && src/ament/ament_tools/scripts/ament.py build --symlink-install
1919

2020
override:
21-
- node --version && npm --version
21+
- node --version && npm --version && rm -rf ./node_modules/
2222
- source ~/ros2_ws/install/local_setup.bash && git submodule init && git submodule update && npm install && npm run lint
2323

2424
test:

src/rcl_utilities.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ const char* lib_ext = ".dll";
4343
void* GetTypeSupportFunctionByInterfaceSymbolName(
4444
const std::string& symbol_name,
4545
const std::string& lib_name) {
46-
// TODO(Kenny): support *.dll/etc. on other platforms.
4746
void* lib = dlopen(lib_name.c_str(), RTLD_NOW | RTLD_GLOBAL);
4847

4948
if (lib)

0 commit comments

Comments
 (0)