Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Commit 32f78ac

Browse files
authored
Merge branch 'master' into language-change-fix
2 parents e6a051d + e54415c commit 32f78ac

4 files changed

Lines changed: 24 additions & 14 deletions

File tree

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ android {
1818
applicationId "chat.rocket.android"
1919
minSdkVersion versions.minSdk
2020
targetSdkVersion versions.targetSdk
21-
versionCode 2067
22-
versionName "3.4.0"
21+
versionCode 2069
22+
versionName "3.4.1"
2323
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
2424
multiDexEnabled true
2525

app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomPresenter.kt

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,9 +1101,13 @@ class ChatRoomPresenter @Inject constructor(
11011101
}
11021102
}
11031103
}
1104-
} catch (ex: Exception) {
1105-
Timber.e(ex)
1106-
view.showMessage(ex.message!!)
1104+
} catch (exception: Exception) {
1105+
Timber.e(exception)
1106+
exception.message?.let {
1107+
view.showMessage(it)
1108+
}.ifNull {
1109+
view.showGenericErrorMessage()
1110+
}
11071111
}
11081112
}
11091113
}
@@ -1120,8 +1124,13 @@ class ChatRoomPresenter @Inject constructor(
11201124
}
11211125
}
11221126
}
1123-
} catch (ex: Exception) {
1124-
Timber.e(ex)
1127+
} catch (exception: Exception) {
1128+
Timber.e(exception)
1129+
exception.message?.let {
1130+
view.showMessage(it)
1131+
}.ifNull {
1132+
view.showGenericErrorMessage()
1133+
}
11251134
}
11261135
}
11271136
}
@@ -1136,8 +1145,13 @@ class ChatRoomPresenter @Inject constructor(
11361145
client.toggleReaction(messageId, emoji.removeSurrounding(":"))
11371146
}
11381147
logReactionEvent()
1139-
} catch (ex: RocketChatException) {
1140-
Timber.e(ex)
1148+
} catch (exception: RocketChatException) {
1149+
Timber.e(exception)
1150+
exception.message?.let {
1151+
view.showMessage(it)
1152+
}.ifNull {
1153+
view.showGenericErrorMessage()
1154+
}
11411155
}
11421156
}
11431157
}

app/src/main/java/chat/rocket/android/chatrooms/domain/FetchChatRoomsInteractor.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
package chat.rocket.android.chatrooms.domain
22

33
import chat.rocket.android.db.DatabaseManager
4-
import chat.rocket.android.db.model.ChatRoomEntity
5-
import chat.rocket.android.db.model.UserEntity
64
import chat.rocket.android.util.retryIO
75
import chat.rocket.core.RocketChatClient
86
import chat.rocket.core.internal.rest.chatRooms
9-
import chat.rocket.core.model.ChatRoom
10-
import chat.rocket.core.model.userId
117
import timber.log.Timber
128

139
class FetchChatRoomsInteractor(

dependencies.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ ext {
99
dokka : '0.9.16',
1010

1111
// For app
12-
kotlin : '1.3.21',
12+
kotlin : '1.3.31',
1313
coroutine : '1.1.1',
1414

1515
appCompat : '1.0.2',

0 commit comments

Comments
 (0)