Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Commit d078df6

Browse files
authored
Merge branch 'master' into patch-4
2 parents 0a5b062 + b2c013f commit d078df6

10 files changed

Lines changed: 37 additions & 18 deletions

File tree

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ android {
1818
applicationId "chat.rocket.android"
1919
minSdkVersion versions.minSdk
2020
targetSdkVersion versions.targetSdk
21-
versionCode 2067
22-
versionName "3.4.0"
21+
versionCode 2069
22+
versionName "3.4.1"
2323
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
2424
multiDexEnabled true
2525

app/src/main/java/chat/rocket/android/authentication/loginoptions/presentation/LoginOptionsPresenter.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ class LoginOptionsPresenter @Inject constructor(
147147
)
148148
localRepository.saveCurrentUser(url = currentServer, user = user)
149149
saveCurrentServer.save(currentServer)
150+
localRepository.save(LocalRepository.CURRENT_USERNAME_KEY, username)
150151
saveAccount(username)
151152
saveToken(token)
152153
analyticsManager.logLogin(loginMethod, true)

app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomPresenter.kt

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,9 +1101,13 @@ class ChatRoomPresenter @Inject constructor(
11011101
}
11021102
}
11031103
}
1104-
} catch (ex: Exception) {
1105-
Timber.e(ex)
1106-
view.showMessage(ex.message!!)
1104+
} catch (exception: Exception) {
1105+
Timber.e(exception)
1106+
exception.message?.let {
1107+
view.showMessage(it)
1108+
}.ifNull {
1109+
view.showGenericErrorMessage()
1110+
}
11071111
}
11081112
}
11091113
}
@@ -1120,8 +1124,13 @@ class ChatRoomPresenter @Inject constructor(
11201124
}
11211125
}
11221126
}
1123-
} catch (ex: Exception) {
1124-
Timber.e(ex)
1127+
} catch (exception: Exception) {
1128+
Timber.e(exception)
1129+
exception.message?.let {
1130+
view.showMessage(it)
1131+
}.ifNull {
1132+
view.showGenericErrorMessage()
1133+
}
11251134
}
11261135
}
11271136
}
@@ -1136,8 +1145,13 @@ class ChatRoomPresenter @Inject constructor(
11361145
client.toggleReaction(messageId, emoji.removeSurrounding(":"))
11371146
}
11381147
logReactionEvent()
1139-
} catch (ex: RocketChatException) {
1140-
Timber.e(ex)
1148+
} catch (exception: RocketChatException) {
1149+
Timber.e(exception)
1150+
exception.message?.let {
1151+
view.showMessage(it)
1152+
}.ifNull {
1153+
view.showGenericErrorMessage()
1154+
}
11411155
}
11421156
}
11431157
}

app/src/main/java/chat/rocket/android/chatrooms/domain/FetchChatRoomsInteractor.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
package chat.rocket.android.chatrooms.domain
22

33
import chat.rocket.android.db.DatabaseManager
4-
import chat.rocket.android.db.model.ChatRoomEntity
5-
import chat.rocket.android.db.model.UserEntity
64
import chat.rocket.android.util.retryIO
75
import chat.rocket.core.RocketChatClient
86
import chat.rocket.core.internal.rest.chatRooms
9-
import chat.rocket.core.model.ChatRoom
10-
import chat.rocket.core.model.userId
117
import timber.log.Timber
128

139
class FetchChatRoomsInteractor(

app/src/main/java/chat/rocket/android/directory/presentation/DirectoryPresenter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ class DirectoryPresenter @Inject constructor(
136136
}
137137
}
138138

139-
fun tiDirectMessage(username: String, name: String) {
139+
fun toDirectMessage(username: String, name: String) {
140140
launchUI(strategy) {
141141
try {
142142
view.showLoading()

app/src/main/java/chat/rocket/android/directory/ui/DirectoryFragment.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,10 @@ class DirectoryFragment : Fragment(), DirectoryView {
4949
presenter.toChannel(channelId, channelName)
5050
}
5151
override fun onUserSelected(username: String, name: String) {
52-
presenter.tiDirectMessage(username, name)
52+
presenter.toDirectMessage(username, name)
5353
}
5454
override fun onGlobalUserSelected(username: String, name: String) {
55-
presenter.tiDirectMessage(username, name)
55+
presenter.toDirectMessage(username, name)
5656
}
5757
})
5858
private val hashtagDrawable by lazy {

app/src/main/java/chat/rocket/android/main/presentation/MainNavigator.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package chat.rocket.android.main.presentation
22

3+
import android.content.Intent
34
import chat.rocket.android.R
45
import chat.rocket.android.authentication.ui.newServerIntent
56
import chat.rocket.android.chatroom.ui.chatRoomIntent
@@ -100,4 +101,9 @@ class MainNavigator(internal val activity: MainActivity) {
100101
fun toServerScreen() {
101102
activity.startActivity(activity.newServerIntent())
102103
}
104+
105+
fun recreateActivity() {
106+
activity.startActivity(Intent(activity, MainActivity::class.java))
107+
activity.finish()
108+
}
103109
}

app/src/main/java/chat/rocket/android/settings/presentation/SettingsPresenter.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,4 +148,6 @@ class SettingsPresenter @Inject constructor(
148148

149149
fun toLicense(licenseUrl: String, licenseTitle: String) =
150150
navigator.toLicense(licenseUrl, licenseTitle)
151+
152+
fun recreateActivity() = navigator.recreateActivity()
151153
}

app/src/main/java/chat/rocket/android/settings/ui/SettingsFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ class SettingsFragment : Fragment(), SettingsView, AppLanguageView {
132132

133133
override fun updateLanguage(language: String, country: String?) {
134134
presenter.saveLocale(language, country)
135-
activity?.recreate()
135+
presenter.recreateActivity()
136136
}
137137

138138
override fun invalidateToken(token: String) = invalidateFirebaseToken(token)

dependencies.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ ext {
99
dokka : '0.9.16',
1010

1111
// For app
12-
kotlin : '1.3.21',
12+
kotlin : '1.3.31',
1313
coroutine : '1.1.1',
1414

1515
appCompat : '1.0.2',

0 commit comments

Comments
 (0)