Peer Updates

* Make textareas larger to encourage more explanation
* Fix an async crasher when there is a one-sided conversation

Author: bnmnetp

controllers/peer.py

@@ -70,7 +70,7 @@ def dashboard():
         next = "Reset"
     else:
         next = False
-    current_question = _get_current_question(assignment_id, next)
+    current_question, done = _get_current_question(assignment_id, next)
     assignment = db(db.assignments.id == assignment_id).select().first()
 
     db.useinfo.insert(
@@ -105,7 +105,7 @@ def dashboard():
 
 def extra():
     assignment_id = request.vars.assignment_id
-    current_question = _get_current_question(assignment_id, False)
+    current_question, done = _get_current_question(assignment_id, False)
 
     return dict(
         course_id=auth.user.course_name,
@@ -334,7 +334,7 @@ def peer_question():
 
     assignment_id = request.vars.assignment_id
 
-    current_question = _get_current_question(assignment_id, False)
+    current_question, done = _get_current_question(assignment_id, False)
     assignment = db(db.assignments.id == assignment_id).select().first()
 
     return dict(
@@ -550,7 +550,9 @@ def get_async_explainer():
             else:
                 tries += 1
         mess, participants = _get_user_messages(user, div_id, course_name)
-        participants.remove(user)
+        # This is the easy solution, but may result in a one-sided conversation.
+        if user in participants:
+            participants.remove(user)
     else:
         messages = db(
             (db.useinfo.event == "sendmessage")

views/peer/peer_async.html

@@ -34,7 +34,7 @@ <h3>Congratulations, you have completed this assignment!</h3>
             Please provide an explanation for why you answered
             <span id="current_answer">__</span>
         </p>
-        <textarea id="messageText" rows="2" cols="40"> </textarea> <br />
+        <textarea id="messageText" rows="6" cols="80"> </textarea> <br />
         <button type="button" onclick="showPeerEnableVote2()">Submit</button>
         <div>
             <h4>A discussion for you to consider</h4>

views/peer/peer_question.html

@@ -29,7 +29,7 @@ <h2>Peer Instruction: {{=assignment_name}}</h2>
         <div id="peerlist">
         </div>
         <p>Please discuss the answers with your group members</p>
-        <textarea id="messageText" rows="2" cols="40">
+        <textarea id="messageText" rows="6" cols="40">
 </textarea>
         <button id="sendpeermsg" type="button" onclick="sendMessage()">Send</button>
         <div>