Skip to content

Commit a5fbeac

Browse files
fix(shield): add alt to input addon image (#320)
1 parent 79b0a8c commit a5fbeac

3 files changed

Lines changed: 11 additions & 3 deletions

File tree

packages/core/shield/src/form.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ pub enum InputValue {
3636
rename_all_fields = "camelCase"
3737
)]
3838
pub enum InputAddon {
39-
Image { src: String },
39+
Image { alt: String, src: String },
4040
Text { text: String },
4141
}
4242

packages/methods/shield-oauth/src/actions/sign_in.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,11 @@ impl Action<OauthProvider, OauthSession> for OauthSignInAction {
8383
}),
8484
addon_start: provider
8585
.icon_url
86-
.map(|icon_url| InputAddon::Image { src: icon_url }),
86+
.as_ref()
87+
.map(|icon_url| InputAddon::Image {
88+
alt: format!("{} logo", provider.name()),
89+
src: icon_url.clone(),
90+
}),
8791
addon_end: None,
8892
},
8993
],

packages/methods/shield-oidc/src/actions/sign_in.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,11 @@ impl Action<OidcProvider, OidcSession> for OidcSignInAction {
8686
}),
8787
addon_start: provider
8888
.icon_url
89-
.map(|icon_url| InputAddon::Image { src: icon_url }),
89+
.as_ref()
90+
.map(|icon_url| InputAddon::Image {
91+
alt: format!("{} logo", provider.name()),
92+
src: icon_url.clone(),
93+
}),
9094
addon_end: None,
9195
},
9296
],

0 commit comments

Comments
 (0)