Because of how the xAPI spec handles Activity ID comparision, we

can't rely on System.Uri, which normalizes URI's passed to the
string constructor.

So, e.g., "http://foo" would become "http://foo/", which is
considered a different Activity ID.

Instead, we now use String as a representation of Activity IDs,
preferring only to validate via Uri.

Author: Freddie O'Connell

TinCan/Activity.cs

@@ -24,7 +24,17 @@ public class Activity : JsonModel, StatementTarget
         public static readonly String OBJECT_TYPE = "Activity";
         public String ObjectType { get { return OBJECT_TYPE; } }
 
-        public Uri id { get; set; }
+        private String _id;
+        public String id
+        {
+            get { return _id; }
+            set
+            {
+                Uri uri = new Uri(value);
+                _id = value;
+            }
+        }
+
         public ActivityDefinition definition { get; set; }
 
         public Activity() { }
@@ -35,7 +45,9 @@ public Activity(JObject jobj)
         {
             if (jobj["id"] != null)
             {
-                id = new Uri(jobj.Value<String>("id"));
+                String idFromJSON = jobj.Value<String>("id");
+                Uri uri = new Uri(idFromJSON);
+                id = idFromJSON;
             }
             if (jobj["definition"] != null)
             {
@@ -50,7 +62,7 @@ public override JObject ToJObject(TCAPIVersion version)
 
             if (id != null)
             {
-                result.Add("id", id.ToString());
+                result.Add("id", id);
             }
             if (definition != null)
             {

TinCan/StatementsQuery.cs

@@ -25,7 +25,15 @@ public class StatementsQuery
 
         public Agent agent { get; set; }
         public Uri verbId { get; set; }
-        public Uri activityId { get; set; }
+        private String _activityId;
+        public String activityId {
+            get { return _activityId; }
+            set
+            {
+                Uri uri = new Uri(value);
+                _activityId = value;
+            }
+        }
         public Nullable<Guid> registration { get; set; }
         public Nullable<Boolean> relatedActivities { get; set; }
         public Nullable<Boolean> relatedAgents { get; set; }

TinCanTests/Support.cs

@@ -40,7 +40,7 @@ static Support () {
             verb.display.Add("en-US", "experienced");
 
             activity = new Activity();
-            activity.id = new Uri("http://tincanapi.com/TinCanCSharp/Test/Unit/0");
+            activity.id = "http://tincanapi.com/TinCanCSharp/Test/Unit/0";
             activity.definition = new ActivityDefinition();
             activity.definition.type = new Uri("http://id.tincanapi.com/activitytype/unit-test");
             activity.definition.name = new LanguageMap();
@@ -49,7 +49,7 @@ static Support () {
             activity.definition.description.Add("en-US", "Unit test 0 in the test suite for the Tin Can C# library.");
 
             parent = new Activity();
-            parent.id = new Uri("http://tincanapi.com/TinCanCSharp/Test");
+            parent.id = "http://tincanapi.com/TinCanCSharp/Test";
             parent.definition = new ActivityDefinition();
             parent.definition.type = new Uri("http://id.tincanapi.com/activitytype/unit-test-suite");
             //parent.definition.moreInfo = new Uri("http://rusticisoftware.github.io/TinCanCSharp/");