Skip to content

Commit 86dba13

Browse files
committed
Rename things to better match conventions
* Drop use of namespaces in code lines, make them plural * Postfix subclasses with their base class name * Switch 'Base' classes to reflect their intent since no longer from namespace * Prefix Interfaces with 'I' * Switch file/directory names to match
1 parent 64fbf6a commit 86dba13

43 files changed

Lines changed: 253 additions & 247 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

TinCan/About.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ limitations under the License.
1616
using System;
1717
using System.Collections.Generic;
1818
using Newtonsoft.Json.Linq;
19-
using TinCan.json;
19+
using TinCan.Json;
2020

2121
namespace TinCan
2222
{
23-
public class About : JSONBase
23+
public class About : JsonModel
2424
{
2525
public List<TCAPIVersion> version { get; set; }
2626
public Extensions extensions { get; set; }

TinCan/Activity.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ limitations under the License.
1515
*/
1616
using System;
1717
using Newtonsoft.Json.Linq;
18-
using TinCan.json;
18+
using TinCan.Json;
1919

2020
namespace TinCan
2121
{
22-
public class Activity : JSONBase, StatementTarget
22+
public class Activity : JsonModel, StatementTarget
2323
{
2424
public static readonly String OBJECT_TYPE = "Activity";
2525
public String ObjectType { get { return OBJECT_TYPE; } }

TinCan/ActivityDefinition.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ limitations under the License.
1515
*/
1616
using System;
1717
using Newtonsoft.Json.Linq;
18-
using TinCan.json;
18+
using TinCan.Json;
1919

2020
namespace TinCan
2121
{
22-
public class ActivityDefinition : JSONBase
22+
public class ActivityDefinition : JsonModel
2323
{
2424
public Uri type { get; set; }
2525
public Uri moreInfo { get; set; }

TinCan/Agent.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ limitations under the License.
1515
*/
1616
using System;
1717
using Newtonsoft.Json.Linq;
18-
using TinCan.json;
18+
using TinCan.Json;
1919

2020
namespace TinCan
2121
{
22-
public class Agent : JSONBase, StatementTarget
22+
public class Agent : JsonModel, StatementTarget
2323
{
2424
public static readonly String OBJECT_TYPE = "Agent";
2525
public virtual String ObjectType { get { return OBJECT_TYPE; } }

TinCan/AgentAccount.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ limitations under the License.
1515
*/
1616
using System;
1717
using Newtonsoft.Json.Linq;
18-
using TinCan.json;
18+
using TinCan.Json;
1919

2020
namespace TinCan
2121
{
22-
public class AgentAccount : JSONBase
22+
public class AgentAccount : JsonModel
2323
{
2424
// TODO: check to make sure is absolute?
2525
public Uri homePage { get; set; }

TinCan/Context.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ limitations under the License.
1515
*/
1616
using System;
1717
using Newtonsoft.Json.Linq;
18-
using TinCan.json;
18+
using TinCan.Json;
1919

2020
namespace TinCan
2121
{
22-
public class Context : JSONBase
22+
public class Context : JsonModel
2323
{
2424
public Nullable<Guid> registration { get; set; }
2525
public Agent instructor { get; set; }

TinCan/ContextActivities.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ limitations under the License.
1515
*/
1616
using System.Collections.Generic;
1717
using Newtonsoft.Json.Linq;
18-
using TinCan.json;
18+
using TinCan.Json;
1919

2020
namespace TinCan
2121
{
22-
public class ContextActivities : JSONBase
22+
public class ContextActivities : JsonModel
2323
{
2424
public List<Activity> parent { get; set; }
2525
public List<Activity> grouping { get; set; }

TinCan/Document/ActivityProfile.cs renamed to TinCan/Documents/ActivityProfileDocument.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ You may obtain a copy of the License at
1414
limitations under the License.
1515
*/
1616

17-
namespace TinCan.Document
17+
namespace TinCan.Documents
1818
{
19-
public class ActivityProfile : Base
19+
public class ActivityProfileDocument : Document
2020
{
2121
public Activity activity { get; set; }
2222
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ You may obtain a copy of the License at
1414
limitations under the License.
1515
*/
1616

17-
namespace TinCan.Document
17+
namespace TinCan.Documents
1818
{
19-
public class AgentProfile : Base
19+
public class AgentProfileDocument : Document
2020
{
2121
public Agent agent { get; set; }
2222
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ limitations under the License.
1515
*/
1616
using System;
1717

18-
namespace TinCan.Document
18+
namespace TinCan.Documents
1919
{
20-
public abstract class Base
20+
public abstract class Document
2121
{
2222
public String id { get; set; }
2323
public String etag { get; set; }

0 commit comments

Comments
 (0)