collect result releases into a diot before acquiring the semaphore to prevent deadlocks in the future

Author: GreemDev

src/Server/Services/GitLab/VersionCache.cs

@@ -2,6 +2,7 @@
 using Gommon;
 using NGitLab;
 using NGitLab.Models;
+using NuGet.Packaging;
 using Ryujinx.Systems.Update.Common;
 
 namespace Ryujinx.Systems.Update.Server.Services.GitLab;
@@ -132,51 +133,71 @@ public async Task RefreshAsync()
 
         if (releases is null)
             return;
-        
-        await _semaphore.WaitAsync();
-        
-        if (Count > 0)
-        {
-            _logger.LogInformation("Clearing {entryCount} version cache entries for {project}", Count,
-                _cachedProject!.Value.Name);
-            Clear();
-        }
 
-        foreach (var release in releases)
-        {
-            _logger.LogTrace("Adding version cache entry {tag} for {project}", release.TagName, _cachedProject!.Value.Name);
-            this[release.TagName] = new VersionCacheEntry
+        var tempCacheEntries = releases.Select(release =>
+            new VersionCacheEntry
             {
                 Tag = release.TagName,
                 ReleaseUrl = ReleaseUrlFormat.Format(release.TagName),
                 Downloads =
                 {
                     Windows =
                     {
-                        X64 = release.Assets.Links.FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("win_x64"))?.Url ?? string.Empty,
-                        Arm64 = release.Assets.Links.FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("win_arm64"))?.Url ?? string.Empty
+                        X64 = release.Assets.Links
+                            .FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("win_x64"))
+                            ?.Url ?? string.Empty,
+                        Arm64 = release.Assets.Links
+                            .FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("win_arm64"))
+                            ?.Url ?? string.Empty
                     },
                     Linux =
                     {
-                        X64 = release.Assets.Links.FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("linux_x64"))?.Url ?? string.Empty,
-                        Arm64 = release.Assets.Links.FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("linux_arm64"))?.Url ?? string.Empty
+                        X64 = release.Assets.Links
+                            .FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("linux_x64"))
+                            ?.Url ?? string.Empty,
+                        Arm64 = release.Assets.Links
+                            .FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("linux_arm64"))
+                            ?.Url ?? string.Empty
                     },
                     LinuxAppImage =
                     {
-                        X64 = release.Assets.Links.FirstOrDefault(x => x.AssetName.EndsWithIgnoreCase("x64.AppImage"))?.Url ?? string.Empty,
-                        Arm64 = release.Assets.Links.FirstOrDefault(x => x.AssetName.EndsWithIgnoreCase("arm64.AppImage"))?.Url ?? string.Empty
+                        X64 = release.Assets.Links
+                            .FirstOrDefault(x => x.AssetName.EndsWithIgnoreCase("x64.AppImage"))
+                            ?.Url ?? string.Empty,
+                        Arm64 = release.Assets.Links
+                            .FirstOrDefault(x => x.AssetName.EndsWithIgnoreCase("arm64.AppImage"))
+                            ?.Url ?? string.Empty
                     },
-                    MacOS = release.Assets.Links.FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("macos_universal"))?.Url ?? string.Empty
+                    MacOS = release.Assets.Links
+                        .FirstOrDefault(x => x.AssetName.ContainsIgnoreCase("macos_universal"))
+                        ?.Url ?? string.Empty
                 }
-            };
+            }).ToDictionary(x => x.Tag, x => x);
+        
+        await _semaphore.WaitAsync();
+        
+        if (Count > 0)
+        {
+            _logger.LogInformation("Clearing {entryCount} version cache entries for {project}", Count,
+                _cachedProject!.Value.Name);
+            Clear();
         }
 
+        foreach (var (tag, entry) in tempCacheEntries)
+        {
+            _logger.LogTrace("Adding version cache entry {tag} for {project}", tag, _cachedProject!.Value.Name);
+
+            this[tag] = entry;
+        }
+        
+        tempCacheEntries.Clear();
+
         sw.Stop();
+        
+        _semaphore.Release();
 
         _logger.LogInformation("Loaded {entryCount} version cache entries for {project}; took {time}ms.", Count,
             _cachedProject!.Value.Name, sw.ElapsedMilliseconds);
-        
-        _semaphore.Release();
     }
 
     public static void InitializeVersionCaches(WebApplication app)