make major increment helper also reset build number (the build of the previous major should never carry over)

Author: GreemDev

src/Server/Initialization/VersionProvider.cs

@@ -43,8 +43,8 @@ public record Entry
         public ulong Major { get; set; }
         public long Build { get; set; }
 
-        public Entry CopyIncrement() => this with { Build = Build + 1 };
-        public Entry CopyIncrementMajor() => this with { Major = Major + 1 };
+        public Entry NextBuild() => this with { Build = Build + 1 };
+        public Entry NextMajor() => this with { Major = Major + 1, Build = 0 };
 
         public override string ToString() =>
             Format

src/Server/Services/VersionProviderService.cs

@@ -35,19 +35,19 @@ public string GetNextVersion(ReleaseChannel rc, bool isMajorRelease = false) =>
         {
             ReleaseChannel.Stable => (
                 isMajorRelease
-                    ? _data.Stable.CopyIncrementMajor()
-                    : _data.Stable.CopyIncrement()
+                    ? _data.Stable.NextMajor()
+                    : _data.Stable.NextBuild()
             ).ToString(),
-            ReleaseChannel.Canary => _data.Canary.CopyIncrement().ToString(), // canaries cannot move the major release, so ignore that boolean for this branch.
+            ReleaseChannel.Canary => _data.Canary.NextBuild().ToString(), // canaries cannot move the major release, so ignore that boolean for this branch.
             _ => throw new ArgumentOutOfRangeException()
         };
 
     public VersionProvider.Entry IncrementBuild(ReleaseChannel rc)
     {
         var entry = rc switch
         {
-            ReleaseChannel.Stable => _data.Stable = _data.Stable.CopyIncrement(),
-            ReleaseChannel.Canary => _data.Canary = _data.Canary.CopyIncrement(),
+            ReleaseChannel.Stable => _data.Stable = _data.Stable.NextBuild(),
+            ReleaseChannel.Canary => _data.Canary = _data.Canary.NextBuild(),
             _ => throw new ArgumentOutOfRangeException()
         };