Acquire Semaphore lock after the web requests have completed to minimize the downtime of the version cache when refreshing

GreemDev · GreemDev · commit 5f9f82e6e801 · 2025-07-01T03:25:17.000-05:00
diff --git a/src/Server/Services/GitLab/VersionCache.cs b/src/Server/Services/GitLab/VersionCache.cs
@@ -111,8 +111,6 @@ public void Init(ProjectId projectId) => Executor.ExecuteBackgroundAsync(async (
 
     public async Task RefreshAsync()
     {
-        await _semaphore.WaitAsync();
-        
         _logger.LogInformation("Reloading version cache for {project}", _cachedProject!.Value.Name);
 
         _latestTag = (await _gl.GetLatestReleaseAsync(_cachedProject.Value.Id))?.TagName;
@@ -135,6 +133,8 @@ public async Task RefreshAsync()
         if (releases is null)
             goto ReleaseLock;
         
+        await _semaphore.WaitAsync();
+        
         if (Count > 0)
         {
             _logger.LogInformation("Clearing {entryCount} version cache entries for {project}", Count,

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,6 @@ public void Init(ProjectId projectId) => Executor.ExecuteBackgroundAsync(async (`
`111`	`111`
`112`	`112`	`public async Task RefreshAsync()`
`113`	`113`	`{`
`114`		`- await _semaphore.WaitAsync();`
`115`		`-`
`116`	`114`	`_logger.LogInformation("Reloading version cache for {project}", _cachedProject!.Value.Name);`
`117`	`115`
`118`	`116`	`_latestTag = (await _gl.GetLatestReleaseAsync(_cachedProject.Value.Id))?.TagName;`
`@@ -135,6 +133,8 @@ public async Task RefreshAsync()`
`135`	`133`	`if (releases is null)`
`136`	`134`	`goto ReleaseLock;`
`137`	`135`
	`136`	`+ await _semaphore.WaitAsync();`
	`137`	`+`
`138`	`138`	`if (Count > 0)`
`139`	`139`	`{`
`140`	`140`	`_logger.LogInformation("Clearing {entryCount} version cache entries for {project}", Count,`