Skip to content

Commit 68c7c2d

Browse files
committed
made caller more accurate
1 parent 76e31c3 commit 68c7c2d

2 files changed

Lines changed: 23 additions & 10 deletions

File tree

src/Server/Helpers/Http/Client/IHttpClientProxy.cs

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,19 @@ namespace Ryujinx.Systems.Update.Server.Helpers.Http;
55

66
public interface IHttpClientProxy
77
{
8-
public Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, HttpCompletionOption? option = null, CancellationToken? token = null);
8+
/// <summary>
9+
/// </summary>
10+
/// <param name="actualCaller"></param>
11+
/// <param name="request"></param>
12+
/// <param name="option"></param>
13+
/// <param name="token"></param>
14+
/// <returns></returns>
15+
/// <remarks>Do no call. Use an overload.</remarks>
16+
protected Task<HttpResponseMessage> SendAsync(string actualCaller, HttpRequestMessage request, HttpCompletionOption? option = null, CancellationToken? token = null);
17+
18+
public Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, HttpCompletionOption? option = null,
19+
CancellationToken? token = null)
20+
=> SendAsync(nameof(SendAsync), request, option, token);
921

1022
#region Convenience overloads for SendAsync
1123

@@ -48,31 +60,31 @@ public Task<HttpResponseMessage> DeleteAsync(
4860
public Task<HttpResponseMessage> GetAsync(
4961
Uri requestUri,
5062
HttpCompletionOption? option = null, CancellationToken? token = null
51-
) => SendAsync(CreateRequestMessage(HttpMethod.Get, requestUri), option, token);
63+
) => SendAsync(nameof(GetAsync), CreateRequestMessage(HttpMethod.Get, requestUri), option, token);
5264

5365
public Task<HttpResponseMessage> PostAsync(
5466
Uri requestUri,
5567
HttpContent? content = null,
5668
HttpCompletionOption? option = null, CancellationToken? token = null
57-
) => SendAsync(CreateRequestMessageWithContent(HttpMethod.Post, requestUri, content), option, token);
69+
) => SendAsync(nameof(PostAsync), CreateRequestMessageWithContent(HttpMethod.Post, requestUri, content), option, token);
5870

5971
public Task<HttpResponseMessage> PutAsync(
6072
Uri requestUri,
6173
HttpContent? content = null,
6274
HttpCompletionOption? option = null, CancellationToken? token = null
63-
) => SendAsync(CreateRequestMessageWithContent(HttpMethod.Put, requestUri, content), option, token);
75+
) => SendAsync(nameof(PutAsync), CreateRequestMessageWithContent(HttpMethod.Put, requestUri, content), option, token);
6476

6577
public Task<HttpResponseMessage> PatchAsync(
6678
Uri requestUri,
6779
HttpContent? content = null,
6880
HttpCompletionOption? option = null, CancellationToken? token = null
69-
) => SendAsync(CreateRequestMessageWithContent(HttpMethod.Patch, requestUri, content), option, token);
81+
) => SendAsync(nameof(PatchAsync), CreateRequestMessageWithContent(HttpMethod.Patch, requestUri, content), option, token);
7082

7183
public Task<HttpResponseMessage> DeleteAsync(
7284
Uri requestUri,
7385
HttpContent? content = null,
7486
HttpCompletionOption? option = null, CancellationToken? token = null
75-
) => SendAsync(CreateRequestMessageWithContent(HttpMethod.Delete, requestUri, content), option, token);
87+
) => SendAsync(nameof(DeleteAsync), CreateRequestMessageWithContent(HttpMethod.Delete, requestUri, content), option, token);
7688

7789
#endregion
7890

src/Server/Services/DefaultHttpClientProxy.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ public DefaultHttpClientProxy(IConfiguration config, ILogger<IHttpClientProxy> l
2929
DefaultRequestHeaders = { Authorization = AuthenticationHeaderValue.Parse($"Bearer {accessToken}") }
3030
};
3131

32-
_callback = (format, formatArgs, _) =>
32+
_callback = (format, formatArgs, caller) =>
3333
{
3434
#pragma warning disable CA2254
35-
logger.LogInformation(format, formatArgs);
35+
logger.LogInformation(new EventId(1, caller), format, formatArgs);
3636
#pragma warning restore CA2254
3737
};
3838
}
@@ -43,8 +43,9 @@ public DefaultHttpClientProxy(HttpClient httpClient, LogCallback? logCallback =
4343
_callback = logCallback;
4444
}
4545

46+
/// <inheritdoc />
4647
[SuppressMessage("ReSharper", "RedundantAssignment", Justification = "ReSharper cannot comprehend the idea of checking all combinations of 2 objects potentially being null.")]
47-
public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, HttpCompletionOption? option = null, CancellationToken? token = null)
48+
public async Task<HttpResponseMessage> SendAsync(string actualCaller, HttpRequestMessage request, HttpCompletionOption? option = null, CancellationToken? token = null)
4849
{
4950
HttpResponseMessage response;
5051

@@ -61,7 +62,7 @@ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, Htt
6162

6263
sw.Stop();
6364

64-
Log("{method} {uri} -> {statusCode} in {elapsed}ms", GetLogArgs(request, response, sw));
65+
Log("{method} {uri} -> {statusCode} in {elapsed}ms", GetLogArgs(request, response, sw), actualCaller);
6566

6667
return response;
6768
}

0 commit comments

Comments
 (0)