[ci skip] Delegate ReleaseUrl formatting to VersionResponse

Author: GreemDev

src/Common/Models/VersionCacheEntry.cs

@@ -1,5 +1,4 @@
 using System.Text.Json.Serialization;
-using Ryujinx.Systems.Update.Common;
 
 namespace Ryujinx.Systems.Update.Common;
 

src/Common/Models/VersionResponse.cs

@@ -11,9 +11,8 @@ public class VersionResponse
 
     [JsonPropertyName("download_url")]
     public required string ArtifactUrl { get; set; }
-    
-    [JsonPropertyName("web_url")]
-    public required string ReleaseUrl { get; set; }
+
+    [JsonPropertyName("web_url")] public string ReleaseUrl  => string.Format(ReleaseUrlFormat, Version);
 
     [JsonPropertyName("web_url_format")]
     public required string ReleaseUrlFormat { get; set; }

src/Server/Controllers/Api/v1/VersionController.cs

@@ -31,7 +31,6 @@ public async Task<ActionResult<VersionResponse>> GetLatestStable(
         {
             Version = latest.Tag,
             ArtifactUrl = latest.GetUrlFor(supportedPlatform, supportedArch),
-            ReleaseUrl = vcache.FormatReleaseUrl(latest.Tag),
             ReleaseUrlFormat = vcache.ReleaseUrlFormat
         });
     }
@@ -59,7 +58,6 @@ public async Task<ActionResult<VersionResponse>> GetLatestCanary(
         {
             Version = latest.Tag,
             ArtifactUrl = latest.GetUrlFor(supportedPlatform, supportedArch),
-            ReleaseUrl = vcache.FormatReleaseUrl(latest.Tag),
             ReleaseUrlFormat = vcache.ReleaseUrlFormat
         });
     }

src/Server/Controllers/LatestController.cs

@@ -46,7 +46,6 @@ public async Task<ActionResult<VersionResponse>> GetLatestCustom(
         {
             Version = latest.Tag,
             ArtifactUrl = latest.GetUrlFor(supportedPlatform, supportedArch),
-            ReleaseUrl = vcache.FormatReleaseUrl(latest.Tag),
             ReleaseUrlFormat = vcache.ReleaseUrlFormat
         });
     }

src/Server/Services/GitLab/VersionCache.cs

@@ -52,7 +52,6 @@ public VersionCache(IConfiguration config, GitLabService gitlabService, ILogger<
     }
 
     public string ReleaseUrlFormat => $"{_gitlabEndpoint.TrimEnd('/')}/{_cachedProject!.Value.Path}/-/releases/{{0}}";
-    public string FormatReleaseUrl(string tag) => ReleaseUrlFormat.Format(tag);
 
     public void Init(ProjectId projectId) => Executor.ExecuteBackgroundAsync(async () =>
     {
@@ -132,7 +131,7 @@ public async Task RefreshAsync()
             this[release.TagName] = new VersionCacheEntry
             {
                 Tag = release.TagName,
-                ReleaseUrl = FormatReleaseUrl(release.TagName),
+                ReleaseUrl = ReleaseUrlFormat.Format(release.TagName),
                 Downloads =
                 {
                     Windows =