abstract away VersionCacheEntry creation into the Release model class

Author: GreemDev

src/Server/Services/Forgejo/ForgejoVersionCache.cs

@@ -210,47 +210,9 @@ public async Task RefreshAsync()
             }
         }
 
-        var tempCacheEntries = releases.Select(release =>
-            new VersionCacheEntry
-            {
-                Tag = release.TagName,
-                ReleaseUrl = ReleaseUrlFormat.Format(release.TagName),
-                Downloads = new DownloadLinks
-                {
-                    Windows = new DownloadLinks.SupportedPlatform
-                    {
-                        X64 = release.Assets?
-                            .FirstOrDefault(x => x.Name.ContainsIgnoreCase("win_x64"))
-                            ?.DownloadUrl ?? string.Empty,
-                        Arm64 = release.Assets?
-                            .FirstOrDefault(x => x.Name.ContainsIgnoreCase("win_arm64"))
-                            ?.DownloadUrl ?? string.Empty
-                    },
-                    Linux = new DownloadLinks.SupportedPlatform
-                    {
-                        X64 = release.Assets?
-                            .FirstOrDefault(x => x.Name.ContainsIgnoreCase("linux_x64"))
-                            ?.DownloadUrl ?? string.Empty,
-                        Arm64 = release.Assets?
-                            .FirstOrDefault(x => x.Name.ContainsIgnoreCase("linux_arm64"))
-                            ?.DownloadUrl ?? string.Empty
-                    },
-                    LinuxAppImage = new DownloadLinks.SupportedPlatform
-                    {
-                        X64 = release.Assets?
-                            .FirstOrDefault(x => x.Name.EndsWithIgnoreCase("x64.AppImage"))
-                            ?.DownloadUrl ?? string.Empty,
-                        Arm64 = release.Assets?
-                            .FirstOrDefault(x => x.Name.EndsWithIgnoreCase("arm64.AppImage"))
-                            ?.DownloadUrl ?? string.Empty
-                    },
-                    MacOS = release.Assets?
-                        .FirstOrDefault(x =>
-                            x.Name.ContainsIgnoreCase("macos_universal") ||
-                            x.Name.ContainsIgnoreCase("macos_arm64"))
-                        ?.DownloadUrl ?? string.Empty
-                }
-            }).ToDictionary(x => x.Tag, x => x);
+        var tempCacheEntries = releases
+            .Select(release => release.AsCacheEntry(ReleaseUrlFormat))
+            .ToDictionary(x => x.Tag, x => x);
 
         await _semaphore.WaitAsync();
 

src/Server/Services/Forgejo/Model/Release.cs

@@ -1,4 +1,6 @@
 using System.Text.Json.Serialization;
+using Gommon;
+using Ryujinx.Systems.Update.Common;
 
 namespace Ryujinx.Systems.Update.Server.Services.Forgejo;
 
@@ -18,6 +20,41 @@ public class Release
     [JsonPropertyName("upload_url")] public string? UploadUrl { get; set; }
     [JsonPropertyName("url")] public string? Url { get; set; }
     [JsonPropertyName("zipball_url")] public string? ZipballUrl { get; set; }
+
+    public VersionCacheEntry AsCacheEntry(string releaseUrlFormat) =>
+        new()
+        {
+            Tag = Guard.Require(TagName, nameof(TagName)),
+            ReleaseUrl = releaseUrlFormat.Format(TagName),
+            Downloads = new DownloadLinks
+            {
+                Windows = new DownloadLinks.SupportedPlatform
+                {
+                    X64 = GetAttachmentUrl(x => x.Name.ContainsIgnoreCase("win_x64")),
+                    Arm64 = GetAttachmentUrl(x => x.Name.ContainsIgnoreCase("win_arm64"))
+                },
+                Linux = new DownloadLinks.SupportedPlatform
+                {
+                    X64 = GetAttachmentUrl(x => x.Name.ContainsIgnoreCase("linux_x64")),
+                    Arm64 = GetAttachmentUrl(x => x.Name.ContainsIgnoreCase("linux_arm64"))
+                },
+                LinuxAppImage = new DownloadLinks.SupportedPlatform
+                {
+                    X64 = GetAttachmentUrl(x => x.Name.EndsWithIgnoreCase("x64.AppImage")),
+                    Arm64 = GetAttachmentUrl(x => x.Name.EndsWithIgnoreCase("arm64.AppImage"))
+                },
+                MacOS = GetAttachmentUrl(x =>
+                    x.Name.ContainsIgnoreCase("macos_universal") ||
+                    x.Name.ContainsIgnoreCase("macos_arm64")
+                )
+            }
+        };
+
+    public Attachment? GetAttachment(Func<Attachment, bool> predicate) 
+        => Assets?.FirstOrDefault(predicate);
+
+    public string GetAttachmentUrl(Func<Attachment, bool> predicate) 
+        => GetAttachment(predicate)?.DownloadUrl ?? string.Empty;
 }
 
 public class Attachment