Skip to content

Commit b51cb78

Browse files
committed
Minor fix
1 parent e008c37 commit b51cb78

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

datamodel/openapi/openapi-api-apache-sample/src/test/java/com/sap/cloud/sdk/services/openapi/apache/ApiClientWithRequestCustomizerTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
1212
import org.apache.hc.core5.http.Header;
13-
import org.apache.hc.core5.http.io.HttpClientResponseHandler;
1413
import org.apache.hc.core5.http.io.support.ClassicRequestBuilder;
1514
import org.apache.hc.core5.http.protocol.HttpContext;
1615
import org.junit.jupiter.api.Test;
@@ -44,7 +43,7 @@ void testRequestCustomizer()
4443
.containsExactlyInAnyOrder("Accept", "X-Custom-Header");
4544
assertThat(req.getFirstHeader("X-Custom-Header").getValue()).isEqualTo("custom-value");
4645
assertThat(req.getFirstHeader("Accept").getValue()).isEqualTo("application/json");
47-
}).isSuccess()), any(HttpContext.class), any(HttpClientResponseHandler.class));
46+
}).isSuccess()), any(HttpContext.class), any());
4847
}
4948

5049
@Test
@@ -63,7 +62,7 @@ void testRequestCustomizerWithMultipleHeaders()
6362
verify(httpClient).execute(argThat(req -> Try.run(() -> {
6463
assertThat(req.getFirstHeader("X-Correlation-Id").getValue()).isEqualTo("12345");
6564
assertThat(req.getFirstHeader("X-Tenant-Id").getValue()).isEqualTo("tenant-abc");
66-
}).isSuccess()), any(HttpContext.class), any(HttpClientResponseHandler.class));
65+
}).isSuccess()), any(HttpContext.class), any());
6766
}
6867

6968
@Test
@@ -79,7 +78,7 @@ void testBasicApiCall()
7978
assertThat(req.getRequestUri()).isEqualTo("/pets");
8079
assertThat(req.getMethod()).isEqualTo("GET");
8180
assertThat(req.getFirstHeader("Accept").getValue()).isEqualTo("application/json");
82-
}).isSuccess()), any(HttpContext.class), any(HttpClientResponseHandler.class));
81+
}).isSuccess()), any(HttpContext.class), any());
8382
}
8483

8584
@Test
@@ -93,6 +92,6 @@ void testWithBasePath()
9392

9493
verify(httpClient).execute(argThat(req -> Try.run(() -> {
9594
assertThat(req.getUri().toString()).isEqualTo("https://api.example.com/pets");
96-
}).isSuccess()), any(HttpContext.class), any(HttpClientResponseHandler.class));
95+
}).isSuccess()), any(HttpContext.class), any());
9796
}
9897
}

datamodel/openapi/openapi-core-apache/src/main/java/com/sap/cloud/sdk/services/openapi/apache/apiclient/ApiClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public static ApiClient fromHttpClient( @Nonnull final CloseableHttpClient httpC
103103
* @return A new ApiClient instance
104104
*/
105105
@Nonnull
106-
public static ApiClient fromHttpClient( @Nonnull final CloseableHttpClient httpClient, @Nonnull String basePath )
106+
public static ApiClient fromHttpClient( @Nonnull final CloseableHttpClient httpClient, @Nonnull final String basePath )
107107
{
108108
return new ApiClient(httpClient, basePath, createDefaultObjectMapper(), null, r -> {
109109
}, r -> r);
@@ -270,7 +270,7 @@ public static String parameterToString( @Nullable final Object param )
270270
{
271271
if( param == null ) {
272272
return "";
273-
} else if( param instanceof Date date ) {
273+
} else if( param instanceof final Date date ) {
274274
return formatDate(date);
275275
} else if( param instanceof Collection ) {
276276
final StringBuilder b = new StringBuilder();

0 commit comments

Comments
 (0)