Merge pull request #500 from SBNSoftware/bugfix/hlay_mcs_invalid_read_pr

ibsafa · web-flow · commit 2b9cf8d9fd61 · 2025-02-14T12:14:23.000-05:00
Prevent over-extension of vector length
diff --git a/sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx b/sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx
@@ -33,7 +33,7 @@ recob::MCSFitResult TrajectoryMCSFitter::fitMcs(const recob::TrackTrajectory& tr
       if (segradlengths[p]<-100. || segradlengths[p-1]<-100.) {
         dtheta.push_back(-999.);
       } 
-      if (!breakpointsgood[p] || !breakpointsgood[p-1]) {
+      else if (!breakpointsgood[p] || !breakpointsgood[p-1]) {
         dtheta.push_back(-999.);
       }
       else { 

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ recob::MCSFitResult TrajectoryMCSFitter::fitMcs(const recob::TrackTrajectory& tr`
`33`	`33`	`if (segradlengths[p]<-100. \|\| segradlengths[p-1]<-100.) {`
`34`	`34`	`dtheta.push_back(-999.);`
`35`	`35`	`}`
`36`		`- if (!breakpointsgood[p] \|\| !breakpointsgood[p-1]) {`
	`36`	`+ else if (!breakpointsgood[p] \|\| !breakpointsgood[p-1]) {`
`37`	`37`	`dtheta.push_back(-999.);`
`38`	`38`	`}`
`39`	`39`	`else {`