Skip to content

Commit 3e2bcd1

Browse files
authored
Merge pull request #2533 from SCIInstitute/amorris/minor-updates
Minor updates
2 parents a122e54 + 4a24836 commit 3e2bcd1

5 files changed

Lines changed: 38 additions & 4 deletions

File tree

.github/workflows/build-mac-arm64.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,18 @@ jobs:
9595
shell: bash -l {0}
9696
run: conda activate shapeworks && source ./devenv.sh ./build/bin && cd build && ctest -VV
9797

98+
- name: Print crash reports
99+
if: failure()
100+
run: |
101+
echo "=== Crash Reports ==="
102+
for f in ~/Library/Logs/DiagnosticReports/*.crash ~/Library/Logs/DiagnosticReports/*.ips; do
103+
if [ -f "$f" ]; then
104+
echo "--- $f ---"
105+
cat "$f"
106+
echo ""
107+
fi
108+
done
109+
98110
- uses: actions/upload-artifact@v4
99111
with:
100112
name: artifact-${{github.sha}}-mac-arm64

.github/workflows/build-mac.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,18 @@ jobs:
9595
shell: bash -l {0}
9696
run: conda activate shapeworks && source ./devenv.sh ./build/bin && cd build && ctest -VV
9797

98+
- name: Print crash reports
99+
if: failure()
100+
run: |
101+
echo "=== Crash Reports ==="
102+
for f in ~/Library/Logs/DiagnosticReports/*.crash ~/Library/Logs/DiagnosticReports/*.ips; do
103+
if [ -f "$f" ]; then
104+
echo "--- $f ---"
105+
cat "$f"
106+
echo ""
107+
fi
108+
done
109+
98110
- uses: actions/upload-artifact@v4
99111
with:
100112
name: artifact-${{github.sha}}-mac

Python/shapeworks/shapeworks/utils.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -316,11 +316,12 @@ def check_results(args, project_spreadsheet):
316316
if "world" in file:
317317
world_point_files.append(particle_dir + file)
318318
if args.tiny_test or args.verify:
319-
# if verification dir doesn't exist, unzip verification.zip
320-
if not os.path.exists("Data/Verification"):
319+
# if verification dir doesn't exist or zip is newer, unzip verification.zip
320+
zip_path = "Data/Verification.zip"
321+
ver_path = "Data/Verification"
322+
if not os.path.exists(ver_path) or os.path.getmtime(zip_path) > os.path.getmtime(ver_path):
321323
print("Unzipping verification data")
322-
# unzip using python
323-
with zipfile.ZipFile("Data/Verification.zip", 'r') as zip_ref:
324+
with zipfile.ZipFile(zip_path, 'r') as zip_ref:
324325
zip_ref.extractall("Data/")
325326

326327
print("Verifying shape model")

Studio/main.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#include <QMessageBox>
88
#include <QResource>
99
#include <QStandardPaths>
10+
#include <QStyleFactory>
1011
#include <QSurfaceFormat>
1112
#include <iostream>
1213

@@ -18,6 +19,7 @@
1819
// vtk
1920
#include <Applications/Configuration.h>
2021
#include <Interface/ShapeWorksStudioApp.h>
22+
#include <Utils/PlatformUtils.h>
2123
#include <Logging.h>
2224
#include <QVTKOpenGLNativeWidget.h>
2325

@@ -107,6 +109,9 @@ int main(int argc, char** argv) {
107109
SW_LOG("ShapeWorks Studio " SHAPEWORKS_VERSION " initializing...");
108110

109111
OverrideQApplication app(argc, argv);
112+
if (PlatformUtils::is_windows()) {
113+
app.setStyle(QStyleFactory::create("Fusion"));
114+
}
110115
QLocale::setDefault(QLocale(QLocale::English, QLocale::UnitedStates));
111116

112117
auto studio_app = QSharedPointer<ShapeWorksStudioApp>::create();

install_shapeworks.bat

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ REM update anaconda
1010
call conda config --add channels anaconda
1111
call conda config --add channels conda-forge
1212

13+
REM Accept Anaconda TOS for required channels
14+
call conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/main
15+
call conda tos accept --override-channels --channel https://repo.anaconda.com/pkgs/r
16+
1317
REM install shapeworks deps
1418
call conda create --yes --name %CONDAENV% python=3.12.3 pip=24.3.1 openblas=0.3.30 || goto :error
1519
call conda activate %CONDAENV%

0 commit comments

Comments
 (0)