Change the design, do not bind anything on the NSURL. Just pass the metadata as context option, to simplify the issue of weak reference

Author: dreampiggy

SDWebImageLinkPlugin.xcodeproj/project.pbxproj

@@ -10,16 +10,12 @@
 		3253E0BB2387DCB2007ACAD8 /* SDWebImageLinkPlugin.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0B92387DCB2007ACAD8 /* SDWebImageLinkPlugin.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		3253E0CB2387E6B4007ACAD8 /* SDImageLinkLoader.m in Sources */ = {isa = PBXBuildFile; fileRef = 3253E0C22387E6B4007ACAD8 /* SDImageLinkLoader.m */; };
 		3253E0CC2387E6B4007ACAD8 /* SDWebImageLinkDefine.m in Sources */ = {isa = PBXBuildFile; fileRef = 3253E0C32387E6B4007ACAD8 /* SDWebImageLinkDefine.m */; };
-		3253E0CE2387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0C52387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		3253E0CF2387E6B4007ACAD8 /* SDWebImageLinkError.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0C62387E6B4007ACAD8 /* SDWebImageLinkError.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		3253E0D02387E6B4007ACAD8 /* SDImageLinkLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0C72387E6B4007ACAD8 /* SDImageLinkLoader.h */; settings = {ATTRIBUTES = (Public, ); }; };
-		3253E0D12387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.m in Sources */ = {isa = PBXBuildFile; fileRef = 3253E0C82387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.m */; };
 		3253E0D22387E6B4007ACAD8 /* SDWebImageLinkDefine.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0C92387E6B4007ACAD8 /* SDWebImageLinkDefine.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		3253E0D32387E6B4007ACAD8 /* SDWebImageLinkError.m in Sources */ = {isa = PBXBuildFile; fileRef = 3253E0CA2387E6B4007ACAD8 /* SDWebImageLinkError.m */; };
 		3253E0D62387E8C5007ACAD8 /* SDWebImage.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3253E0D52387E8C5007ACAD8 /* SDWebImage.framework */; };
 		3253E0E72387E900007ACAD8 /* SDWebImage.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3253E0E62387E900007ACAD8 /* SDWebImage.framework */; };
-		3253E0EA2387E94D007ACAD8 /* NSURL+SDWebImageLinkPlugin.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0C52387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.h */; settings = {ATTRIBUTES = (Public, ); }; };
-		3253E0EB2387E94D007ACAD8 /* NSURL+SDWebImageLinkPlugin.m in Sources */ = {isa = PBXBuildFile; fileRef = 3253E0C82387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.m */; };
 		3253E0EC2387E94D007ACAD8 /* SDImageLinkLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0C72387E6B4007ACAD8 /* SDImageLinkLoader.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		3253E0ED2387E94D007ACAD8 /* SDImageLinkLoader.m in Sources */ = {isa = PBXBuildFile; fileRef = 3253E0C22387E6B4007ACAD8 /* SDImageLinkLoader.m */; };
 		3253E0EE2387E94D007ACAD8 /* SDWebImageLinkDefine.h in Headers */ = {isa = PBXBuildFile; fileRef = 3253E0C92387E6B4007ACAD8 /* SDWebImageLinkDefine.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -43,10 +39,8 @@
 		3253E0BA2387DCB2007ACAD8 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; name = Info.plist; path = Module/Info.plist; sourceTree = "<group>"; };
 		3253E0C22387E6B4007ACAD8 /* SDImageLinkLoader.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SDImageLinkLoader.m; sourceTree = "<group>"; };
 		3253E0C32387E6B4007ACAD8 /* SDWebImageLinkDefine.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SDWebImageLinkDefine.m; sourceTree = "<group>"; };
-		3253E0C52387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSURL+SDWebImageLinkPlugin.h"; sourceTree = "<group>"; };
 		3253E0C62387E6B4007ACAD8 /* SDWebImageLinkError.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SDWebImageLinkError.h; sourceTree = "<group>"; };
 		3253E0C72387E6B4007ACAD8 /* SDImageLinkLoader.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SDImageLinkLoader.h; sourceTree = "<group>"; };
-		3253E0C82387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSURL+SDWebImageLinkPlugin.m"; sourceTree = "<group>"; };
 		3253E0C92387E6B4007ACAD8 /* SDWebImageLinkDefine.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SDWebImageLinkDefine.h; sourceTree = "<group>"; };
 		3253E0CA2387E6B4007ACAD8 /* SDWebImageLinkError.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = SDWebImageLinkError.m; sourceTree = "<group>"; };
 		3253E0D52387E8C5007ACAD8 /* SDWebImage.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = SDWebImage.framework; path = Carthage/Build/iOS/SDWebImage.framework; sourceTree = "<group>"; };
@@ -113,8 +107,6 @@
 				3253E12E23882AD5007ACAD8 /* LPLinkView+WebCache.m */,
 				3253E1252387EDE7007ACAD8 /* NSImage+SDWebImageLinkPlugin.h */,
 				3253E1242387EDE7007ACAD8 /* NSImage+SDWebImageLinkPlugin.m */,
-				3253E0C52387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.h */,
-				3253E0C82387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.m */,
 				3253E0C72387E6B4007ACAD8 /* SDImageLinkLoader.h */,
 				3253E0C22387E6B4007ACAD8 /* SDImageLinkLoader.m */,
 				3253E0C92387E6B4007ACAD8 /* SDWebImageLinkDefine.h */,
@@ -143,7 +135,6 @@
 			files = (
 				3253E1282387EDE7007ACAD8 /* NSImage+SDWebImageLinkPlugin.h in Headers */,
 				3253E0D02387E6B4007ACAD8 /* SDImageLinkLoader.h in Headers */,
-				3253E0CE2387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.h in Headers */,
 				3253E0D22387E6B4007ACAD8 /* SDWebImageLinkDefine.h in Headers */,
 				3253E13223882AD5007ACAD8 /* LPLinkView+WebCache.h in Headers */,
 				3253E0BB2387DCB2007ACAD8 /* SDWebImageLinkPlugin.h in Headers */,
@@ -158,7 +149,6 @@
 				3253E1292387EDE7007ACAD8 /* NSImage+SDWebImageLinkPlugin.h in Headers */,
 				3253E0EE2387E94D007ACAD8 /* SDWebImageLinkDefine.h in Headers */,
 				3253E0EC2387E94D007ACAD8 /* SDImageLinkLoader.h in Headers */,
-				3253E0EA2387E94D007ACAD8 /* NSURL+SDWebImageLinkPlugin.h in Headers */,
 				3253E13323882AD5007ACAD8 /* LPLinkView+WebCache.h in Headers */,
 				3253E0F02387E94D007ACAD8 /* SDWebImageLinkError.h in Headers */,
 				3253E0F22387E951007ACAD8 /* SDWebImageLinkPlugin.h in Headers */,
@@ -267,7 +257,6 @@
 				3253E13023882AD5007ACAD8 /* LPLinkView+WebCache.m in Sources */,
 				3253E1262387EDE7007ACAD8 /* NSImage+SDWebImageLinkPlugin.m in Sources */,
 				3253E0CB2387E6B4007ACAD8 /* SDImageLinkLoader.m in Sources */,
-				3253E0D12387E6B4007ACAD8 /* NSURL+SDWebImageLinkPlugin.m in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -276,7 +265,6 @@
 			buildActionMask = 2147483647;
 			files = (
 				3253E0F12387E94D007ACAD8 /* SDWebImageLinkError.m in Sources */,
-				3253E0EB2387E94D007ACAD8 /* NSURL+SDWebImageLinkPlugin.m in Sources */,
 				3253E13123882AD5007ACAD8 /* LPLinkView+WebCache.m in Sources */,
 				3253E1272387EDE7007ACAD8 /* NSImage+SDWebImageLinkPlugin.m in Sources */,
 				3253E0EF2387E94D007ACAD8 /* SDWebImageLinkDefine.m in Sources */,

SDWebImageLinkPlugin/Classes/LPLinkView+WebCache.m

@@ -7,8 +7,7 @@
  */
 
 #import "LPLinkView+WebCache.h"
-#import "NSURL+SDWebImageLinkPlugin.h"
-#import "NSImage+SDWebImageLinkPlugin.h"
+#import "SDWebImageLinkDefine.h"
 
 #define LPImageClass @"LPImage"
 @protocol LPImageProtocol <NSObject>
@@ -61,7 +60,7 @@ - (void)sd_setImageWithURL:(nullable NSURL *)url
     __weak typeof(self) wself = self;
     [self sd_internalSetImageWithURL:url placeholderImage:placeholder options:options context:context setImageBlock:^(UIImage * _Nullable image, NSData * _Nullable imageData, SDImageCacheType cacheType, NSURL * _Nullable imageURL) {
         __strong typeof(self) sself = wself;
-        LPLinkMetadata *metadata = imageURL.sd_linkMetadata;
+        LPLinkMetadata *metadata = context[SDWebImageContextLinkMetadata];
         if (metadata) {
             // Already exist
         } else if (image) {

SDWebImageLinkPlugin/Classes/NSURL+SDWebImageLinkPlugin.h

@@ -10,7 +10,6 @@
 #import "SDWebImageLinkDefine.h"
 #import "SDWebImageLinkError.h"
 #import "NSImage+SDWebImageLinkPlugin.h"
-#import "NSURL+SDWebImageLinkPlugin.h"
 #import <LinkPresentation/LinkPresentation.h>
 #if SD_UIKIT
 #import <MobileCoreServices/MobileCoreServices.h>
@@ -75,7 +74,7 @@ - (BOOL)canRequestImageForURL:(NSURL *)url {
 - (id<SDWebImageOperation>)requestImageWithURL:(NSURL *)url options:(SDWebImageOptions)options context:(SDWebImageContext *)context progress:(SDImageLoaderProgressBlock)progressBlock completed:(SDImageLoaderCompletedBlock)completedBlock {
     SDImageLinkLoaderOperation *operation = [SDImageLinkLoaderOperation new];
     // Let's check wether input URL already have an associated LPLinkMetadata
-    LPLinkMetadata *metadata = url.sd_linkMetadata;
+    LPLinkMetadata *metadata = context[SDWebImageContextLinkMetadata];
     if (metadata) {
         [self fetchImageWithMetadata:metadata operation:operation url:url options:options context:context progress:progressBlock completed:completedBlock];
     } else {
@@ -85,12 +84,12 @@ - (BOOL)canRequestImageForURL:(NSURL *)url {
         [provider startFetchingMetadataForURL:url completionHandler:^(LPLinkMetadata * _Nullable metadata, NSError * _Nullable error) {
             if (error) {
                 if (completedBlock) {
-                    completedBlock(nil, nil, error, YES);
+                    dispatch_main_async_safe(^{
+                        completedBlock(nil, nil, error, YES);
+                    });
                 }
                 return;
             }
-            // Associated the link metadata to URL, weak reference
-            url.sd_linkMetadata = metadata;
             [self fetchImageWithMetadata:metadata operation:operation url:url options:options context:context progress:progressBlock completed:completedBlock];
         }];
         operation.provider = provider;
@@ -121,15 +120,15 @@ - (void)fetchImageWithMetadata:(LPLinkMetadata *)metadata operation:(SDImageLink
     }
     if (requestData) {
         // Request the image data and decode
-        [self fetchImageDataWithProvider:imageProvider operation:operation url:url options:options context:context progress:progressBlock completed:completedBlock];
+        [self fetchImageDataWithProvider:imageProvider metadata:metadata operation:operation url:url options:options context:context progress:progressBlock completed:completedBlock];
     } else {
         // Only request the image object, faster
-        [self fetchImageWithProvider:imageProvider operation:operation url:url progress:progressBlock completed:completedBlock];
+        [self fetchImageWithProvider:imageProvider metadata:metadata operation:operation url:url progress:progressBlock completed:completedBlock];
     }
 }
 
 // Fetch image and data with `loadDataRepresentationForTypeIdentifier` API
-- (void)fetchImageDataWithProvider:(NSItemProvider *)imageProvider operation:(SDImageLinkLoaderOperation *)operation url:(NSURL *)url options:(SDWebImageOptions)options context:(SDWebImageContext *)context progress:(SDImageLoaderProgressBlock)progressBlock completed:(SDImageLoaderCompletedBlock)completedBlock {
+- (void)fetchImageDataWithProvider:(NSItemProvider *)imageProvider metadata:(LPLinkMetadata *)metadata operation:(SDImageLinkLoaderOperation *)operation url:(NSURL *)url options:(SDWebImageOptions)options context:(SDWebImageContext *)context progress:(SDImageLoaderProgressBlock)progressBlock completed:(SDImageLoaderCompletedBlock)completedBlock {
     SDImageLinkLoaderContext *loaderContext = [SDImageLinkLoaderContext new];
     loaderContext.url = url;
     loaderContext.progressBlock = progressBlock;
@@ -156,9 +155,9 @@ - (void)fetchImageDataWithProvider:(NSItemProvider *)imageProvider operation:(SD
             error = [NSError errorWithDomain:SDWebImageErrorDomain code:SDWebImageErrorBadImageData userInfo:nil];
         } else {
             // The original metadata contains image data and is large, we pick the metadata info only to avoid double cache of image
-            LPLinkMetadata *metadata = [self.class strippedMetadata:url.sd_linkMetadata];
+            LPLinkMetadata *strippedMetadata = [self.class strippedMetadata:metadata];
             // Save the metadata to extended data
-            image.sd_extendedObject = metadata;
+            image.sd_extendedObject = strippedMetadata;
         }
         if (completedBlock) {
             dispatch_main_async_safe(^{
@@ -173,7 +172,7 @@ - (void)fetchImageDataWithProvider:(NSItemProvider *)imageProvider operation:(SD
 }
 
 // Fetch image with `loadObjectOfClass` API
-- (void)fetchImageWithProvider:(NSItemProvider *)imageProvider operation:(SDImageLinkLoaderOperation *)operation url:(NSURL *)url progress:(SDImageLoaderProgressBlock)progressBlock completed:(SDImageLoaderCompletedBlock)completedBlock {
+- (void)fetchImageWithProvider:(NSItemProvider *)imageProvider metadata:(LPLinkMetadata *)metadata operation:(SDImageLinkLoaderOperation *)operation url:(NSURL *)url progress:(SDImageLoaderProgressBlock)progressBlock completed:(SDImageLoaderCompletedBlock)completedBlock {
     SDImageLinkLoaderContext *loaderContext = [SDImageLinkLoaderContext new];
     loaderContext.url = url;
     loaderContext.progressBlock = progressBlock;
@@ -199,9 +198,9 @@ - (void)fetchImageWithProvider:(NSItemProvider *)imageProvider operation:(SDImag
             error = [NSError errorWithDomain:SDWebImageErrorDomain code:SDWebImageErrorBadImageData userInfo:nil];
         } else {
             // The original metadata contains image data and is large, we pick the metadata info only to avoid double cache of image
-            LPLinkMetadata *metadata = [self.class strippedMetadata:url.sd_linkMetadata];
+            LPLinkMetadata *strippedMetadata = [self.class strippedMetadata:metadata];
             // Save the metadata to extended data
-            image.sd_extendedObject = metadata;
+            image.sd_extendedObject = strippedMetadata;
         }
         if (completedBlock) {
             dispatch_main_async_safe(^{

SDWebImageLinkPlugin/Classes/NSURL+SDWebImageLinkPlugin.m

@@ -8,6 +8,12 @@
 
 @import SDWebImage;
 
+/**
+ A `LPLinkMetadata` object used to fetch image/icon for website. If you provide this value, we don't use `LPMetadataProvider` to fetch the website's metadata again, directlly use your prefetched metadata instead.
+ @note If the provided `LPLinkMetadata` does not have any `imageProvider` or `iconProvider`, a error with code `SDWebImageLinkErrorNoImageProvider` will be returned. (`LPLinkMetadata`)
+ */
+FOUNDATION_EXPORT SDWebImageContextOption _Nonnull const SDWebImageContextLinkMetadata;
+
 /**
  A Bool value specify whether or not, to request the metadata's image, with the Data representation. But default we do not keep data by using `loadObjectOfClass` API. If enable, we'll use `loadDataRepresentationForTypeIdentifier` API instead, and decode the data into image object.
  @note Current implementation, LinkPresentation can retrive UIImage object 5x faster than the Data, so by default, we only request the image object witthout data. But it depends on your own usage, you can trun this on. (NSNumber *)

SDWebImageLinkPlugin/Classes/SDImageLinkLoader.m

@@ -8,4 +8,5 @@
 
 #import "SDWebImageLinkDefine.h"
 
+SDWebImageContextOption _Nonnull const SDWebImageContextLinkMetadata = @"linkMetadata";
 SDWebImageContextOption _Nonnull const SDWebImageContextLinkRequestImageData = @"linkRequestImageData";

SDWebImageLinkPlugin/Classes/SDWebImageLinkDefine.h

@@ -19,6 +19,5 @@ FOUNDATION_EXPORT const unsigned char SDWebImageLinkPluginVersionString[];
 #import <SDWebImageLinkPlugin/SDImageLinkLoader.h>
 #import <SDWebImageLinkPlugin/SDWebImageLinkDefine.h>
 #import <SDWebImageLinkPlugin/SDWebImageLinkError.h>
-#import <SDWebImageLinkPlugin/NSURL+SDWebImageLinkPlugin.h>
 #import <SDWebImageLinkPlugin/NSImage+SDWebImageLinkPlugin.h>
 #import <SDWebImageLinkPlugin/LPLinkView+WebCache.h>