Fix CS and SC

Author: paranoiq

build/spell-checker/custom.dic

@@ -37,10 +37,12 @@ postgresql
 refman
 remstr
 rl
+rdf
 sdi
 sqlftw
 srs
 stm
+subdir
 tagname
 tbl
 termino
@@ -83,6 +85,7 @@ nonpersistible
 subgraph
 unresolvable
 uncastable
+serialisation
 casted
 backticks
 resize

sources/Analyzer/Rules/Charset/CharsetAndCollationCompatibilityRule.php

@@ -22,7 +22,6 @@
 use SqlFtw\Sql\Ddl\Table\CreateTableCommand;
 use SqlFtw\Sql\Ddl\Table\Option\TableOption;
 use SqlFtw\Sql\Expression\DefaultLiteral;
-use SqlFtw\Sql\MysqlVariable;
 use SqlFtw\Sql\Statement;
 use SqlFtw\Sql\TableCommand;
 use function count;
@@ -51,7 +50,7 @@ public function process(Statement $statement, SimpleContext $context, int $flags
     private function processSchema(SchemaCommand $command, SimpleContext $context): array
     {
         $results = [];
-        $options =  $command->getOptions();
+        $options = $command->getOptions();
         $charset = $options->getCharset();
         $collation = $options->getCollation();
         if ($charset !== null && $collation !== null && !$charset->supportsCollation($collation)) {
@@ -68,7 +67,7 @@ private function processSchema(SchemaCommand $command, SimpleContext $context):
     private function processTable(TableCommand $command, SimpleContext $context): array
     {
         $results = [];
-        $options =  $command->getOptions();
+        $options = $command->getOptions();
         /** @var Charset|DefaultLiteral $charset */
         $charset = $options->get(TableOption::CHARACTER_SET);
         if ($charset instanceof DefaultLiteral) {

sources/Parser/Dal/TableMaintenanceCommandsParser.php

@@ -10,8 +10,8 @@
 namespace SqlFtw\Parser\Dal;
 
 use SqlFtw\Parser\TokenList;
-use SqlFtw\Sql\Dal\Table\AnalyzeTableDropHistogramCommand;
 use SqlFtw\Sql\Dal\Table\AnalyzeTableCommand;
+use SqlFtw\Sql\Dal\Table\AnalyzeTableDropHistogramCommand;
 use SqlFtw\Sql\Dal\Table\AnalyzeTableUpdateHistogramCommand;
 use SqlFtw\Sql\Dal\Table\ChecksumTableCommand;
 use SqlFtw\Sql\Dal\Table\CheckTableCommand;

sources/Parser/Ddl/IndexCommandsParser.php

@@ -26,6 +26,7 @@
 use SqlFtw\Sql\Keyword;
 use SqlFtw\Sql\Order;
 use SqlFtw\Sql\SqlMode;
+use function count;
 use function strlen;
 use function strtoupper;
 

sources/Parser/Dml/XaTransactionCommandsParser.php

@@ -106,7 +106,7 @@ private function parseXid(TokenList $tokenList): Xid
             if ($tokenList->hasSymbol(',')) {
                 $format = $tokenList->expectIntLike();
                 if (!$format instanceof UintLiteral && !$format instanceof HexadecimalLiteral) {
-                   throw new ParserException('Transaction format id must be unsigned int or hexadecimal literal.', $tokenList);
+                    throw new ParserException('Transaction format id must be unsigned int or hexadecimal literal.', $tokenList);
                 }
                 if ($format instanceof UintLiteral && (float) $format->getValue() >= (float) PHP_INT_MAX) {
                     throw new ParserException('Transaction format id is too big.', $tokenList);

sources/Parser/RoutineBodyParser.php

@@ -242,7 +242,7 @@ private function parseStatement(TokenList $tokenList): Statement
                 $delimiter = $tokenList->get(TokenType::DELIMITER);
                 if ($delimiter !== null) {
                     $tokenList->appendTrailingDelimiter($delimiter->value);
-                } {
+                } else {
                     if ($tokenList->hasSymbol(';')) {
                         $tokenList->appendTrailingDelimiter(';');
                     }

sources/Parser/exceptions/AnalyzerException.php

@@ -33,7 +33,7 @@ public function __construct(array $results, Command $command, TokenList $tokenLi
     {
         $count = count($results);
         parent::__construct("Static analysis failed with $count errors.", $previous);
-rd($results);
+
         $this->results = $results;
         $this->command = $command;
         $this->tokenList = $tokenList;

sources/Platform/Features/MysqlFeatures.php

@@ -57,8 +57,8 @@
 use SqlFtw\Sql\Dal\Show\ShowTableStatusCommand;
 use SqlFtw\Sql\Dal\Show\ShowTriggersCommand;
 use SqlFtw\Sql\Dal\Show\ShowVariablesCommand;
-use SqlFtw\Sql\Dal\Table\AnalyzeTableDropHistogramCommand;
 use SqlFtw\Sql\Dal\Table\AnalyzeTableCommand;
+use SqlFtw\Sql\Dal\Table\AnalyzeTableDropHistogramCommand;
 use SqlFtw\Sql\Dal\Table\AnalyzeTableUpdateHistogramCommand;
 use SqlFtw\Sql\Dal\Table\ChecksumTableCommand;
 use SqlFtw\Sql\Dal\Table\OptimizeTableCommand;

sources/Session/Session.php

@@ -12,7 +12,6 @@
 use SqlFtw\Platform\Platform;
 use SqlFtw\Sql\Charset;
 use SqlFtw\Sql\Collation;
-use SqlFtw\Sql\EntityType;
 use SqlFtw\Sql\Expression\UnresolvedExpression;
 use SqlFtw\Sql\Expression\Value;
 use SqlFtw\Sql\MysqlVariable;

sources/Sql/Ddl/Schema/SchemaOptions.php

@@ -13,6 +13,7 @@
 use SqlFtw\Sql\Charset;
 use SqlFtw\Sql\Collation;
 use SqlFtw\Sql\Ddl\Table\Option\ThreeStateValue;
+use function implode;
 
 class SchemaOptions implements SchemaCommand
 {