Skip to content

Commit 44f0fc1

Browse files
committed
Improvements
1 parent 12c1e6c commit 44f0fc1

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

sqlmesh/dbt/model.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@
3838
logger = logging.getLogger(__name__)
3939

4040

41+
logger = logging.getLogger(__name__)
42+
43+
4144
INCREMENTAL_BY_TIME_STRATEGIES = set(["delete+insert", "insert_overwrite", "microbatch"])
4245
INCREMENTAL_BY_UNIQUE_KEY_STRATEGIES = set(["merge"])
4346

@@ -521,8 +524,13 @@ def to_sqlmesh(
521524
raise ConfigError(
522525
f"Failed to parse model '{self.canonical_name(context)}' partition_by field '{p}' in '{self.path}': {e}"
523526
) from e
524-
elif isinstance(self.partition_by, dict) and context.target.dialect == "bigquery":
525-
partitioned_by.append(self._big_query_partition_by_expr(context))
527+
elif isinstance(self.partition_by, dict):
528+
if context.target.dialect == "bigquery":
529+
partitioned_by.append(self._big_query_partition_by_expr(context))
530+
else:
531+
logger.warning(
532+
f"Ignoring partition_by config for model '{self.name}' targeting {context.target.dialect}; it is only supported for bigquery."
533+
)
526534

527535
if partitioned_by:
528536
optional_kwargs["partitioned_by"] = partitioned_by

tests/dbt/test_transformation.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1469,6 +1469,9 @@ def test_partition_by(sushi_test_project: Project):
14691469
model_config.partition_by = {"field": "ds", "data_type": "date", "granularity": "day"}
14701470
assert model_config.to_sqlmesh(context).partitioned_by == [exp.to_column("ds", quoted=True)]
14711471

1472+
context.target = DuckDbConfig(name="target", schema="foo")
1473+
assert model_config.to_sqlmesh(context).partitioned_by == []
1474+
14721475

14731476
@pytest.mark.xdist_group("dbt_manifest")
14741477
def test_partition_by_none(sushi_test_project: Project):

0 commit comments

Comments
 (0)