Narrow local-only state skip to format command

In multi-repo projects, lint results depend on models merged from the
prod environment in state during Context.load(), so forcing lint to
never load state changed lint outcomes when upstream models live in
another repo. Per review discussion on PR #5804, lint reverts to
loading state (guarded by a new CLI test) and only format remains
local-only. The lint case stays open in issue #5182.

Signed-off-by: Joe Hartshorn <8881940+j-hartshorn@users.noreply.github.com>

Author: j-hartshorn

sqlmesh/cli/main.py

@@ -41,7 +41,7 @@
     "table_name",
 )
 SKIP_CONTEXT_COMMANDS = ("init", "ui")
-LOCAL_ONLY_COMMANDS = ("format", "lint")
+LOCAL_ONLY_COMMANDS = ("format",)
 
 
 def _sqlmesh_version() -> str:

tests/cli/test_cli.py

@@ -2271,14 +2271,25 @@ def test_format_runs_without_state(runner: CliRunner, tmp_path: Path, mocker):
     mock.assert_not_called()
 
 
-def test_lint_runs_without_state(runner: CliRunner, tmp_path: Path, mocker):
+def test_lint_still_loads_state(runner: CliRunner, tmp_path: Path, mocker):
+    """Guard that `lint` explicitly passes `load_state=True` and still reaches state sync."""
     mock = _setup_local_only_project(tmp_path, mocker)
-    result = runner.invoke(cli, ["--paths", str(tmp_path), "lint"])
-    assert result.exit_code == 0, f"Lint failed: {result.output}\nException: {result.exception}"
-    mock.assert_not_called()
+    init_spy = mocker.spy(Context, "__init__")
+
+    runner.invoke(cli, ["--paths", str(tmp_path), "lint"])
+
+    assert init_spy.called, "Context was never constructed"
+    for call in init_spy.call_args_list:
+        assert "load_state" in call.kwargs, (
+            "CLI didn't pass load_state= explicitly; missing kwarg defaults to True silently"
+        )
+        assert call.kwargs["load_state"] is True, (
+            f"Context was constructed with load_state={call.kwargs['load_state']} for `lint`"
+        )
+    assert mock.called, "state-sync was never accessed during `lint`"
 
 
-@pytest.mark.parametrize("command", ["format", "lint"])
+@pytest.mark.parametrize("command", ["format"])
 def test_local_only_commands_skip_state_multiple_paths(
     runner: CliRunner, tmp_path: Path, mocker, command: str
 ):

tests/core/linter/test_builtin.py

@@ -232,51 +232,3 @@ def test_no_missing_unit_tests(tmp_path, copy_to_temp_path):
         assert len(model_violations) == 0, (
             f"Model {model_name} should not have a violation since it has a test"
         )
-
-
-def test_lint_without_state_load(tmp_path, copy_to_temp_path, mocker) -> None:
-    sushi_paths = copy_to_temp_path("examples/sushi")
-    sushi_path = sushi_paths[0]
-
-    with open(sushi_path / "config.py", "r") as f:
-        read_file = f.read()
-
-    # Set a project name so state-merge code reaches the `self._load_state` guard.
-    project_anchor = "config = Config(\n    gateways="
-    assert project_anchor in read_file, (
-        "sushi config.py shape drifted; update project_anchor in test"
-    )
-    read_file = read_file.replace(
-        project_anchor,
-        'config = Config(\n    project="sushi",\n    gateways=',
-    )
-
-    # Enable one built-in rule so `lint_models` doesn't take the empty-rule-set path.
-    before = """    linter=LinterConfig(
-        enabled=False,
-        rules=[
-            "ambiguousorinvalidcolumn",
-            "invalidselectstarexpansion",
-            "noselectstar",
-            "nomissingaudits",
-            "nomissingowner",
-            "nomissingexternalmodels",
-        ],
-    ),"""
-    after = 'linter=LinterConfig(enabled=True, rules=["nomissingexternalmodels"]),'
-    assert before in read_file, (
-        "sushi config.py LinterConfig block shape drifted; update `before` in test"
-    )
-    read_file = read_file.replace(before, after)
-
-    with open(sushi_path / "config.py", "w") as f:
-        f.write(read_file)
-
-    mock = mocker.patch(
-        "sqlmesh.core.state_sync.db.facade.EngineAdapterStateSync.get_versions",
-        side_effect=RuntimeError("state should not be accessed"),
-    )
-
-    context = Context(paths=[sushi_path], load_state=False)
-    context.lint_models(raise_on_error=False)
-    mock.assert_not_called()