Merge branch '313551801' of https://github.com/SQLab/113-spring-software-testing into 313551801

Author: Annheij

lab1/main_test.js

@@ -2,53 +2,22 @@ const test = require('node:test');
 const assert = require('assert');
 const { MyClass, Student } = require('./main');
 
-test("Test MyClass\'s addStudent", () => {
-    const myClass = new MyClass();
-    const student = new Student();
-    
-    const id = myClass.addStudent(student);
-    assert.strictEqual(id, 0); 
-    
-    const invalidId = myClass.addStudent("invalid student");
-    assert.strictEqual(invalidId, -1); 
+test("Test MyClass's addStudent", () => {
+    // TODO
+    throw new Error("Test not implemented");
 });
 
-test("Test MyClass\'s getStudentById", () => {
-    const myClass = new MyClass();
-    const student = new Student();
-    student.setName("Ann");
-    
-    const id = myClass.addStudent(student);
-    const retrievedStudent = myClass.getStudentById(id);
-    
-    assert.ok(retrievedStudent instanceof Student); 
-    assert.strictEqual(retrievedStudent.getName(), "Ann");
-    
-    assert.strictEqual(myClass.getStudentById(-1), null); 
-    assert.strictEqual(myClass.getStudentById(100), null);
+test("Test MyClass's getStudentById", () => {
+    // TODO
+    throw new Error("Test not implemented");
 });
 
 test("Test Student's setName", () => {
-    const student = new Student();
-    
-    student.setName("Anton");
-    assert.strictEqual(student.getName(), "Anton");
-
-    student.setName(1);
-    assert.strictEqual(student.getName(), "Anton");
-
-    student.setName(null);
-    assert.strictEqual(student.getName(), "Anton");
-
-    student.setName(undefined);
-    assert.strictEqual(student.getName(), "Anton");
+    // TODO
+    throw new Error("Test not implemented");
 });
 
 test("Test Student's getName", () => {
-    const student = new Student();
-    
-    assert.strictEqual(student.getName(), "");
-    
-    student.setName("Cheri");
-    assert.strictEqual(student.getName(), "Cheri");
+    // TODO
+    throw new Error("Test not implemented");
 });

lab2/main.js

@@ -28,15 +28,20 @@ class Application {
         this.people = [];
         this.selected = [];
         this.mailSystem = new MailSystem();
+
+        this.getNames().then(([people, selected]) => {
+            this.people = people;
+            this.selected = selected;
+        });
     }
 
     async getNames() {
         const data = await readFile('name_list.txt', 'utf8');
-        this.people = data.split('\n');
-        this.selected = [];
+        const people = data.split('\n');
+        const selected = [];
+        return [people, selected];
     }
 
-
     getRandomPerson() {
         const i = Math.floor(Math.random() * this.people.length);
         return this.people[i];

lab2/main_test.js

@@ -1,57 +1,6 @@
 const test = require('node:test');
 const assert = require('assert');
 const { Application, MailSystem } = require('./main');
-const sinon = require('sinon');
 
-test('test getRandomPerson in main.js', async () => {
-    const app = new Application();
-    
-    app.getNames = async () => {
-        app.people = ["Annika", "Billy", "Cecilia"];
-        app.selected = [];
-    };
-
-    await app.getNames();  
-
-    const person = app.getRandomPerson();
-    assert.ok(app.people.includes(person), 'the person is not in list');
-});
-
-
-test('test mains selectNextPerson to not select same person twice', async () => {
-    const app = new Application();
-    
-    app.getNames = async () => {
-        app.people = ["Annika", "Billy", "Cecilia"];
-        app.selected = [];
-    };
-
-    await app.getNames();
-
-    const person1 = app.selectNextPerson();
-    const person2 = app.selectNextPerson();
-    
-    assert.notStrictEqual(person1, person2, 'Same person was selected twice');
-});
-
-test('test mains notifySelected that it calls send()', async () => {
-    const mailSystem = new MailSystem();
-    const sendSpy = sinon.spy(mailSystem, 'send');
-
-    const app = new Application();
-    app.mailSystem = mailSystem;
-
-    app.getNames = async () => {
-        app.people = ["Annika", "Billy", "Cecilia"];
-        app.selected = [];
-    };
-
-    await app.getNames();
-
-    const person = app.selectNextPerson();
-    app.selected = [person];
-
-    await app.notifySelected();  
-
-    assert.ok(sendSpy.calledWith(person, `Congrats, ${person}!`), `send() didn't work with args. Captured calls: ${JSON.stringify(sendSpy.args)}`);
-});
+// TODO: write your tests here
+// Remember to use Stub, Mock, and Spy when necessary

lab3/README.md

@@ -0,0 +1,29 @@
+# Lab3
+
+## Introduction
+
+In this lab, you will write unit tests for functions implemented in `main.js`. You can learn how to use classes and functions in it by uncommenting the code in it. (But remember don't commit them on GitHub)
+
+## Preparation (Important!!!)
+
+1. Sync fork on GitHub
+2. `git checkout -b lab3` (**NOT** your student ID !!!)
+
+## Requirement
+
+1. (40%) Write test cases in `main_test.js` and achieve 100% code coverage.
+2. (30%) For each function, parameterize their testcases to test the error-results.
+3. (30%) For each function, use at least 3 parameterized testcases to test the non-error-results.
+
+You can run `validate.sh` in your local to test if you satisfy the requirements.
+
+Please note that you must not alter files other than `main_test.js`. You will get 0 points if
+
+1. you modify other files to achieve requirements.
+2. you can't pass all CI on your PR.
+
+## Submission
+
+You need to open a pull request to your branch (e.g. 312XXXXXX, your student number) and contain the code that satisfies the abovementioned requirements.
+
+Moreover, please submit the URL of your PR to E3. Your submission will only be accepted when you present at both places.

lab3/main.js

@@ -0,0 +1,34 @@
+class Calculator {
+    exp(x) {
+        if (!Number.isFinite(x)) {
+            throw Error('unsupported operand type');
+        }
+        const result = Math.exp(x);
+        if (result === Infinity) {
+            throw Error('overflow');
+        }
+        return result;
+    }
+
+    log(x) {
+        if (!Number.isFinite(x)) {
+            throw Error('unsupported operand type');
+        }
+        const result = Math.log(x);
+        if (result === -Infinity) {
+            throw Error('math domain error (1)');
+        }
+        if (Number.isNaN(result)) {
+            throw Error('math domain error (2)');
+        }
+        return result;
+    }
+}
+
+// const calculator = new Calculator();
+// console.log(calculator.exp(87));
+// console.log(calculator.log(48763));
+
+module.exports = {
+    Calculator
+};

lab3/main_test.js

@@ -0,0 +1,5 @@
+const {describe, it} = require('node:test');
+const assert = require('assert');
+const { Calculator } = require('./main');
+
+// TODO: write your tests here

lab3/validate.sh

@@ -0,0 +1,38 @@
+#!/bin/bash
+
+# Check for unwanted files
+for file in *; do
+  if [[ $file != "main.js" && $file != "main_test.js" && $file != "README.md" && $file != "validate.sh" ]]; then
+    echo "[!] Unwanted file detected: $file."
+    exit 1
+  fi
+done
+
+node=$(which node)
+test_path="${BASH_SOURCE[0]}"
+solution_path="$(realpath .)"
+tmp_dir=$(mktemp -d -t lab3-XXXXXXXXXX)
+
+cd $tmp_dir
+
+rm -rf *
+cp $solution_path/*.js .
+result=$($"node" --test --experimental-test-coverage) ; ret=$?
+if [ $ret -ne 0 ] ; then
+  echo "[!] testing fails"
+  exit 1
+else
+  coverage=$(echo "$result" | grep 'all files' | awk -F '|' '{print $2}' | sed 's/ //g')
+  if (( $(echo "$coverage < 100" | bc -l) )); then
+    echo "[!] Coverage is only $coverage%"
+    exit 1
+  else
+    echo "[V] Coverage is 100%"
+  fi
+fi
+
+rm -rf $tmp_dir
+
+exit 0
+
+# vim: set fenc=utf8 ff=unix et sw=2 ts=2 sts=2: