Skip to content

Commit 0f8a35b

Browse files
INI: make 'ini_*_serialize' API private
This allows to not expose "simplebuffer.h"
1 parent e64069a commit 0f8a35b

6 files changed

Lines changed: 31 additions & 33 deletions

File tree

ini/ini_comment.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
#include <ctype.h>
2626
#include "trace.h"
2727
#include "ref_array.h"
28+
#include "ini_configobj.h"
29+
#include "ini_config_priv.h"
2830
#include "simplebuffer.h"
2931
#include "ini_comment.h"
3032
#include "ini_defines.h"

ini/ini_comment.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525
#include <stdint.h>
2626
#include <stdio.h>
27-
#include "simplebuffer.h"
2827

2928
#ifndef EOK
3029
#define EOK 0
@@ -150,12 +149,6 @@ int ini_comment_copy(struct ini_comment *ic,
150149
int ini_comment_add(struct ini_comment *ic_to_add,
151150
struct ini_comment *ic);
152151

153-
/**
154-
* Serialize comment
155-
*/
156-
int ini_comment_serialize(struct ini_comment *ic,
157-
struct simplebuffer *sbobj);
158-
159152
/**
160153
* Internal function to print comment
161154
*/

ini/ini_config_priv.h

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,32 @@ int access_check_int(struct stat *file_stats,
109109
mode_t mode,
110110
mode_t mask);
111111

112+
/**
113+
* @brief Serialize configuration object
114+
*
115+
* Serialize configuration object into provided buffer.
116+
* Use buffer object functions to manipulate or save
117+
* the buffer to a file/stream.
118+
*
119+
* @param[in] ini_config Configuration object.
120+
* @param[out] sbobj Serialized configuration.
121+
*
122+
* @return 0 - Success.
123+
* @return EINVAL - Invalid parameter.
124+
* @return ENOMEM - No memory.
125+
*/
126+
int ini_config_serialize(struct ini_cfgobj *ini_config,
127+
struct simplebuffer *sbobj);
128+
129+
/* Serialize value */
130+
int value_serialize(struct value_obj *vo,
131+
const char *key,
132+
struct simplebuffer *sbobj);
133+
134+
/* Serialize comment */
135+
int ini_comment_serialize(struct ini_comment *ic,
136+
struct simplebuffer *sbobj);
137+
112138
struct ini_errmsg;
113139

114140
struct ini_errobj {

ini/ini_configobj.h

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#include <unistd.h>
3030
#include <limits.h>
3131
#include <stdio.h>
32-
#include "simplebuffer.h"
3332
#include "ini_valueobj.h"
3433

3534
#ifndef DING_ATTR_FORMAT
@@ -1112,24 +1111,6 @@ int ini_config_augment(struct ini_cfgobj *base_cfg,
11121111
int ini_config_set_wrap(struct ini_cfgobj *ini_config,
11131112
uint32_t boundary);
11141113

1115-
/**
1116-
* @brief Serialize configuration object
1117-
*
1118-
* Serialize configuration object into provided buffer.
1119-
* Use buffer object functions to manipulate or save
1120-
* the buffer to a file/stream.
1121-
*
1122-
* @param[in] ini_config Configuration object.
1123-
* @param[out] sbobj Serialized configuration.
1124-
*
1125-
* @return 0 - Success.
1126-
* @return EINVAL - Invalid parameter.
1127-
* @return ENOMEM - No memory.
1128-
*/
1129-
int ini_config_serialize(struct ini_cfgobj *ini_config,
1130-
struct simplebuffer *sbobj);
1131-
1132-
11331114
/* Functions that add, modify or delete sections and values in
11341115
* the configuration object can be found in section \ref ini_mod.
11351116
*/

ini/ini_valueobj.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
#include <ctype.h>
2727
#include "simplebuffer.h"
2828
#include "ref_array.h"
29+
#include "ini_configobj.h"
30+
#include "ini_config_priv.h"
2931
#include "ini_comment.h"
3032
#include "ini_defines.h"
3133
#include "ini_valueobj.h"

ini/ini_valueobj.h

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#define INI_VALUEOBJ_H
2525

2626
#include "ref_array.h"
27-
#include "simplebuffer.h"
2827
#include "ini_comment.h"
2928

3029
struct value_obj;
@@ -136,12 +135,7 @@ int value_put_comment(struct value_obj *vo,
136135
int value_merge_comment(struct value_obj *vo_donor,
137136
struct value_obj *vo);
138137

139-
/* Serialize value */
140-
int value_serialize(struct value_obj *vo,
141-
const char *key,
142-
struct simplebuffer *sbobj);
143-
144138
/* Print value */
145139
void value_print(const char *key, struct value_obj *vo);
146140

147-
#endif
141+
#endif

0 commit comments

Comments
 (0)