Skip to content

Commit e66dd6d

Browse files
Dan Lavupbrezina
authored andcommitted
minor doc updates and refactoring
* added 'testing' or 'using' to standardize naming * added better examples to naming in concepts * fixed some category indexing * typos here and there
1 parent 1cb51d3 commit e66dd6d

10 files changed

Lines changed: 21 additions & 15 deletions

docs/concepts.rst

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,20 +44,20 @@ Core concepts
4444
Naming tests
4545
************
4646

47-
Name your tests as ``test_feature__case``. For example:
47+
Name your tests as ``test_feature__case``, or ``test_role__case``. For example:
4848

4949
.. code-block:: python
5050
5151
@pytest.mark.topology(KnownTopologyGroup.AnyProvider)
52-
def test_id__shortname():
52+
def test_identity__lookup_user_using_their_shortname():
5353
pass
5454
5555
@pytest.mark.topology(KnownTopologyGroup.AnyProvider)
56-
def test_id__fqn():
56+
def test_identity__lookup_user_using_their_fully_qualified_name():
5757
pass
5858
59-
@pytest.mark.topology(KnownTopologyGroup.AnyProvider)
60-
def test_id__name_with_space():
59+
@pytest.mark.topology(KnownTopology.IPA)
60+
def test_ipa_trust__lookup_user_in_ad():
6161
pass
6262
6363
About using fixtures
@@ -105,6 +105,10 @@ logical to organize tests inside a class, it does not give you any benefit over
105105
plain function and it create just one more level of organization that must be
106106
correctly kept and maintained.
107107

108+
Tests are organized by user stories, also referred to as customer scenarios.
109+
For example, tests related to verifying a user's *identity* will reside in
110+
test_identity.py. Tests related to logins, will reside in test_authentication.py.
111+
108112
.. warning::
109113

110114
**Avoid organizing tests into classes** *unless there is a food reason to

docs/guides/check-sssd-functionality.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Supported features
4040
* ``non-privileged`` - SSSD is built with support of running under non-root
4141

4242
Checking supported functionality in other roles
43-
###############################################
43+
===============================================
4444

4545
Even though the main purpose and default setting of the
4646
``@pytest.mark.builtwith`` marker is to check built functionality of SSSD on the

docs/guides/index.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,19 @@ How to guides
33

44
.. toctree::
55

6-
using-roles
76
check-sssd-functionality
8-
ssh-client
9-
sss_override
10-
pam
7+
using-roles
8+
using-ssh
119
testing-authentication
1210
testing-autofs
1311
testing-dbus
1412
testing-gpo
1513
testing-identity
1614
testing-ldap-krb5
1715
testing-netgroups
16+
testing-sss_override
1817
testing-offline
1918
testing-passkey
19+
testing-pam
2020
testing-ipa-trust
21-
local-users
21+
testing-local-users

docs/guides/testing-gpo.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Testing AD GPO HBAC
2-
====================
2+
###################
33

44
:class:`~sssd_test_framework.roles.ad.AD.GPO`
55
provides Group Policy Objects (GPO) management to configure GPO policies on AD. Allowing us
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

docs/marks.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Additional test metadata
55
************************
66

77
The following metadata are **required** to be present in docstring of each test.
8-
These metadata are used to organize test in Polarion to provide evidency and
8+
These metadata are used to organize test in Polarion to provide evidence and
99
traceability for enterprise releases.
1010

1111
.. code-block:: python
@@ -34,6 +34,8 @@ traceability for enterprise releases.
3434
"""
3535
3636
* **title**: Simple test case description.
37+
* **description** (optional): Any information that is beneficial to understand
38+
the user scenario or any uniqueness pertaining to the test.
3739
* **setup**: All steps required to setup the environment before assertions (e.g.
3840
what users are created).
3941
* **steps**: Individual test or assertion steps.

docs/writing-tests.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
Writing new test
2-
################
1+
Writing new tests
2+
#################
33

44
The tests are written using the `pytest`_ framework, `pytest-mh`_ plugin and
55
SSSD specific extensions that implements related

0 commit comments

Comments
 (0)