Requested changes

Author: antoineatstariongroup

SysML2.NET/Comparer/NullableStringEqualityComparer.cs

@@ -29,8 +29,8 @@ namespace SysML2.NET.Comparer
     public sealed class NullSafeStringComparer : IEqualityComparer<string>
     {
         /// <summary>Determines whether the specified objects are equal.</summary>
-        /// <param name="x">The first object of type <paramref name="T" /> to compare.</param>
-        /// <param name="y">The second object of type <paramref name="T" /> to compare.</param>
+        /// <param name="x">The first <see cref="string"/> to compare.</param>
+        /// <param name="y">The second <see cref="string"/> to compare.</param>
         /// <returns>
         /// <see langword="true" /> if the specified objects are equal; otherwise, <see langword="false" />.</returns>
         public bool Equals(string x, string y)
@@ -49,9 +49,8 @@ public bool Equals(string x, string y)
         }
 
         /// <summary>Returns a hash code for the specified object.</summary>
-        /// <param name="obj">The <see cref="T:System.Object" /> for which a hash code is to be returned.</param>
+        /// <param name="obj">The nullable <see cref="string"/> for which a hash code is to be returned.</param>
         /// <returns>A hash code for the specified object.</returns>
-        /// <exception cref="T:System.ArgumentNullException">The type of <paramref name="obj" /> is a reference type and <paramref name="obj" /> is <see langword="null" />.</exception>
         public int GetHashCode(string? obj)
         {
             return obj?.GetHashCode() ?? 0;

SysML2.NET/Exceptions/IncompleteModelException.cs

@@ -0,0 +1,48 @@
+// -------------------------------------------------------------------------------------------------
+// <copyright file="IncompleteModelException.cs" company="Starion Group S.A.">
+// 
+//   Copyright 2022-2026 Starion Group S.A.
+// 
+//   Licensed under the Apache License, Version 2.0 (the "License");
+//   you may not use this file except in compliance with the License.
+//   You may obtain a copy of the License at
+// 
+//        http://www.apache.org/licenses/LICENSE-2.0
+// 
+//    Unless required by applicable law or agreed to in writing, software
+//    distributed under the License is distributed on an "AS IS" BASIS,
+//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//    See the License for the specific language governing permissions and
+//    limitations under the License.
+// 
+// </copyright>
+// ------------------------------------------------------------------------------------------------
+
+namespace SysML2.NET.Exceptions
+{
+    using System;
+
+    /// <summary>
+    /// The <see cref="ModelException"/> provide custom exception that should be used when a SysML 2 is incomplete and is not compliant with defined multiplicity
+    /// </summary>
+    public class IncompleteModelException: Exception
+    {
+        /// <summary>Initializes a new instance of the <see cref="IncompleteModelException" /> class.</summary>
+        public IncompleteModelException()
+        {
+        }
+
+        /// <summary>Initializes a new instance of the <see cref="IncompleteModelException" /> class with a specified error message.</summary>
+        /// <param name="message">The message that describes the error.</param>
+        public IncompleteModelException(string message) : base(message)
+        {
+        }
+
+        /// <summary>Initializes a new instance of the <see cref="IncompleteModelException" /> class with a specified error message and a reference to the inner exception that is the cause of this exception.</summary>
+        /// <param name="message">The error message that explains the reason for the exception.</param>
+        /// <param name="innerException">The exception that is the cause of the current exception, or a null reference (<see langword="Nothing" /> in Visual Basic) if no inner exception is specified.</param>
+        public IncompleteModelException(string message, Exception innerException) : base(message, innerException)
+        {
+        }
+    }
+}

…2.NET/Exceptions/SysML2ModelException.cs SysML2.NET/Exceptions/ModelException.csSysML2.NET/Exceptions/SysML2ModelException.cs renamed to SysML2.NET/Exceptions/ModelException.cs SysML2.NET/Exceptions/SysML2ModelException.cs renamed to SysML2.NET/Exceptions/ModelException.cs

@@ -1,5 +1,5 @@
 // -------------------------------------------------------------------------------------------------
-// <copyright file="SysMl2ModelException.cs" company="Starion Group S.A.">
+// <copyright file="ModelException.cs" company="Starion Group S.A.">
 // 
 //   Copyright 2022-2026 Starion Group S.A.
 // 
@@ -23,25 +23,25 @@ namespace SysML2.NET.Exceptions
     using System;
 
     /// <summary>
-    /// The <see cref="SysMl2ModelException"/> provide custom exception that should be used when a SysML 2 rule violation appears into a model 
+    /// The <see cref="ModelException"/> provide custom exception that should be used when a SysML 2 constraint violation appears into a model 
     /// </summary>
-    public class SysMl2ModelException: Exception
+    public class ModelException: Exception
     {
-        /// <summary>Initializes a new instance of the <see cref="SysMl2ModelException" /> class.</summary>
-        public SysMl2ModelException()
+        /// <summary>Initializes a new instance of the <see cref="ModelException" /> class.</summary>
+        public ModelException()
         {
         }
 
-        /// <summary>Initializes a new instance of the <see cref="SysMl2ModelException" /> class with a specified error message.</summary>
+        /// <summary>Initializes a new instance of the <see cref="ModelException" /> class with a specified error message.</summary>
         /// <param name="message">The message that describes the error.</param>
-        public SysMl2ModelException(string message) : base(message)
+        public ModelException(string message) : base(message)
         {
         }
 
-        /// <summary>Initializes a new instance of the <see cref="SysMl2ModelException" /> class with a specified error message and a reference to the inner exception that is the cause of this exception.</summary>
+        /// <summary>Initializes a new instance of the <see cref="ModelException" /> class with a specified error message and a reference to the inner exception that is the cause of this exception.</summary>
         /// <param name="message">The error message that explains the reason for the exception.</param>
         /// <param name="innerException">The exception that is the cause of the current exception, or a null reference (<see langword="Nothing" /> in Visual Basic) if no inner exception is specified.</param>
-        public SysMl2ModelException(string message, Exception innerException) : base(message, innerException)
+        public ModelException(string message, Exception innerException) : base(message, innerException)
         {
         }
     }

SysML2.NET/Extend/OwningMembershipExtensions.cs

@@ -51,7 +51,7 @@ internal static IElement ComputeOwnedMemberElement(this IOwningMembership owning
                 throw new ArgumentNullException(nameof(owningMembershipSubject));
             }
 
-            return owningMembershipSubject.OwnedRelatedElement.Count != 1 ? throw new SysMl2ModelException($"{nameof(owningMembershipSubject)} must have exactly one related element") : owningMembershipSubject.OwnedRelatedElement.Single();
+            return owningMembershipSubject.OwnedRelatedElement.Count != 1 ? throw new IncompleteModelException($"{nameof(owningMembershipSubject)} must have exactly one related element") : owningMembershipSubject.OwnedRelatedElement.Single();
         }
 
         /// <summary>