Skip to content

Commit 8f73f25

Browse files
SQ improvement and naming convention context
1 parent 301bb6e commit 8f73f25

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

CLAUDE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,3 +117,4 @@ Auto-generated DTOs use structured namespaces reflecting the KerML/SysML package
117117
- Prefer 'string.IsNullOrWhiteSpace' over 'string.IsNullOrEmpty' when checking the non-nullable value of a string
118118
- Prefer switch expressions/statements over if-else chains when applicable
119119
- Prefer indexer syntax (e.g., 'list[^1]') and range syntax (e.g., 'array[1..^1]') over LINQ methods (e.g., 'list.Last()', 'list.Skip(1).Take(n)') when applicable
120+
- Use meaningful loop variable names instead of single-letter names (e.g., 'charIndex' instead of 'i', 'currentChar' instead of 'c')

SysML2.NET.Tests/Extend/NamespaceExtensionsTestFixture.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,11 @@ public void VerifyComputeNamesOfOperation()
148148
var membership = new Membership { MemberName = "elementName", MemberShortName = "en", MemberElement = element };
149149
namespaceElement.AssignOwnership(membership, element);
150150

151-
Assert.That(namespaceElement.ComputeNamesOfOperation(element), Is.EquivalentTo(new[] { "en", "elementName" }));
151+
Assert.That(namespaceElement.ComputeNamesOfOperation(element), Is.EquivalentTo(["en", "elementName"]));
152152

153153
membership.MemberShortName = null;
154154

155-
Assert.That(namespaceElement.ComputeNamesOfOperation(element), Is.EquivalentTo(new[] { "elementName" }));
155+
Assert.That(namespaceElement.ComputeNamesOfOperation(element), Is.EquivalentTo(["elementName"]));
156156
}
157157

158158
[Test]

SysML2.NET/Extensions/StringExtensions.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,24 +92,24 @@ public static int FindLastQualifiedNameSeparatorIndex(this string qualifiedName)
9292
var lastSeparatorIndex = -1;
9393
var inQuote = false;
9494

95-
for (var i = 0; i < qualifiedName.Length; i++)
95+
for (var charIndex = 0; charIndex < qualifiedName.Length; charIndex++)
9696
{
97-
var c = qualifiedName[i];
97+
var currentChar = qualifiedName[charIndex];
9898

99-
switch (c)
99+
switch (currentChar)
100100
{
101-
case '\\' when inQuote && i + 1 < qualifiedName.Length:
102-
i++;
101+
case '\\' when inQuote && charIndex + 1 < qualifiedName.Length:
102+
charIndex++;
103103
continue;
104104
case '\'':
105105
inQuote = !inQuote;
106106
continue;
107107
}
108108

109-
if (!inQuote && c == ':' && i + 1 < qualifiedName.Length && qualifiedName[i + 1] == ':')
109+
if (!inQuote && currentChar == ':' && charIndex + 1 < qualifiedName.Length && qualifiedName[charIndex + 1] == ':')
110110
{
111-
lastSeparatorIndex = i;
112-
i++;
111+
lastSeparatorIndex = charIndex;
112+
charIndex++;
113113
}
114114
}
115115

0 commit comments

Comments
 (0)