changed conditional_dependencies to private

Author: andrewelamb

synapseclient/extensions/curator/schema_generation.py

@@ -5066,7 +5066,7 @@ class JSONSchema:
         description: An optional description of the object described by this schema.
         properties: A list of property schemas.
         required: A list of properties required by the schema.
-        conditional_dependencies: A mapping of conditional dependencies to be added to the "allOf" keyword in JSON Schema.
+        _conditional_dependencies: A mapping of conditional dependencies to be added to the "allOf" keyword in JSON Schema.
             The key is a tuple of (watched_property, enum_value)
             The value is a list of properties that become required when watched_property has the value enum_value.
     """
@@ -5078,7 +5078,7 @@ class JSONSchema:
     description: str = "TBD"
     properties: dict[str, Property] = field(default_factory=dict)
     required: list[str] = field(default_factory=list)
-    conditional_dependencies: dict[tuple[str, str], list[str]] = field(
+    _conditional_dependencies: dict[tuple[str, str], list[str]] = field(
         default_factory=dict
     )
 
@@ -5106,12 +5106,11 @@ def as_json_schema_dict(
         #  in the correct format to be added as is, and they need to be converted to allOf conditions first.
         # Finally the conditional dependencies are removed from the JSON Schema dict because they are not a
         #  valid JSON Schema keyword
-        if self.conditional_dependencies:
+        if self._conditional_dependencies:
             json_schema_dict["allOf"] = self._convert_conditional_properties_to_all_of(
-                self.conditional_dependencies
+                self._conditional_dependencies
             )
-        json_schema_dict.pop("conditional_dependencies")
-
+        json_schema_dict.pop("_conditional_dependencies")
         return json_schema_dict
 
     def add_required_property(self, name: str) -> None:
@@ -5158,11 +5157,14 @@ def add_conditional_dependency(
             enum_value: The value of the watched property that triggers the condition
             dependent_property: The property that becomes required when the condition is triggered
         """
-        if (watched_property, enum_value) not in self.conditional_dependencies:
-            self.conditional_dependencies[(watched_property, enum_value)] = []
-        self.conditional_dependencies[(watched_property, enum_value)].append(
-            dependent_property
-        )
+        if (watched_property, enum_value) not in self._conditional_dependencies:
+            self._conditional_dependencies[(watched_property, enum_value)] = [
+                dependent_property
+            ]
+        else:
+            self._conditional_dependencies[(watched_property, enum_value)].append(
+                dependent_property
+            )
 
     @staticmethod
     def _convert_conditional_properties_to_all_of(

tests/unit/synapseclient/extensions/unit_test_create_json_schema.py

@@ -7,7 +7,6 @@
 import logging
 import os
 from typing import Any, Optional
-from unittest import mock
 from unittest.mock import Mock
 
 import pytest
@@ -264,7 +263,7 @@ def test_init(self) -> None:
         assert schema.description == "TBD"
         assert not schema.properties
         assert not schema.required
-        assert not schema.conditional_dependencies
+        assert not schema._conditional_dependencies
 
     def test_as_json_schema_dict(self) -> None:
         """Test the JSONSchema.as_json_schema_dict method"""
@@ -1261,7 +1260,7 @@ def test_set_conditional_dependencies(
     _set_conditional_dependencies(
         json_schema=json_schema, graph_state=gts, use_display_labels=False
     )
-    assert json_schema.conditional_dependencies == expected_conditional_dependencies
+    assert json_schema._conditional_dependencies == expected_conditional_dependencies
 
 
 @pytest.mark.parametrize(